Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 01 Oct 2018 23:15:37 -0700 (PDT)
Message-Id: <20181001.231537.589368056102755607.davem@davemloft.net>
To:     haiyangz@microsoft.com, haiyangz@linuxonhyperv.com
Cc:     netdev@vger.kernel.org, kys@microsoft.com, sthemmin@microsoft.com,
        olaf@aepfle.de, vkuznets@redhat.com, devel@linuxdriverproject.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] hv_netvsc: Fix rndis_per_packet_info internal
 field initialization
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20180928144123.11926-1-haiyangz@linuxonhyperv.com>
References: <20180928144123.11926-1-haiyangz@linuxonhyperv.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Haiyang Zhang <haiyangz@linuxonhyperv.com>
Date: Fri, 28 Sep 2018 14:41:23 +0000

> From: Haiyang Zhang <haiyangz@microsoft.com>
> 
> The RSC feature -- a bit field "internal" was added here with total
> size unchanged:
> struct rndis_per_packet_info {
> 	u32 size;
> 	u32 type:31;
> 	u32 internal:1;
> 	u32 ppi_offset;
> };
> 
> On TX path, we put rndis msg into skb head room, which is not zeroed
> before passing to us. We do not use the "internal" field in TX path,
> but it may impact older hosts which use the entire 32 bits as "type".
> 
> To fix the bug, this patch sets the field "internal" to zero.
> 
> Fixes: c8e4eff4675f ("hv_netvsc: Add support for LRO/RSC in the vSwitch")
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>

Applied.