Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1122305imm; Tue, 2 Oct 2018 03:09:30 -0700 (PDT) X-Google-Smtp-Source: ACcGV62FukkwS80VfFha4JxAg1GSnVXrqMkoNNtxc6s2IA/ULD22ODSvHi9RPbnc3wfF13X6a/Zu X-Received: by 2002:a17:902:7401:: with SMTP id g1-v6mr16070480pll.144.1538474970702; Tue, 02 Oct 2018 03:09:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538474970; cv=none; d=google.com; s=arc-20160816; b=hp6TTTuz4GSGVlJRB+pJgDijNmf7ziLfBET+Kqgi3Q3sTSdGwE9U7Kq/Cy2faD5O84 Z6cl/z4WyjQbC+VdZfCQKlcxNMFTkKo7qbeNh00CLrSq3SZeWiSPMENFScWxR/WbNEvs lhsLqqWxinaQadnwfsoyqXCcNGpjdU0KtY/Lx1LQ/ZImHWTZy3sK85lJzMav3NSDge7i yJ8i4WnqMQpDSLdSGkyqrlxsV1m6lvKM9wFTAMyXsMsVZYBc8nMGExb21tTHJOQ3v91j LlStSsljn3t1F3jRXM1rm5LOsQt3ohQhEMpo+Xz9J8OT/eN3pH4jDgh2WLptKNV+VSFt LxBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date; bh=aQEJs1E5Ag5OVfjzHVyN+n4Vg4G+p3isopysym7bUeA=; b=Z8w4RUuf1SinqqM19+dOUsPwniKuW1OOgG+jCTmUN/ZxiP3IPjt6JGzNakNvU9dZ8c A1BBLUi457RBvb/Hm7oGlHLHKfMWMRuF+u3utxLyHBxNSUPJitQ1PqAZZlC3QM/RK9Si bisdlcWe4nBCmMV83e15aVOAf5s3H8CgYAEyh3xJmxGaY6l/EzkkbxUuNZId1vs3SUgm iuHm1Y5etNfiug7QXcMf9ZZD1uzQKzsG1l3TwcWm0lXUk/Ed3p0x1EMG6S3IGxB9l1O5 lL1W2VHsTBifKyyJjlGjNiZejuuPWBumMy4afl0xvGq/hQTGhwd+H+Orc3vbqL8vpz7J MWYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r13-v6si7592440pfb.43.2018.10.02.03.09.15; Tue, 02 Oct 2018 03:09:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727261AbeJBQvV (ORCPT + 99 others); Tue, 2 Oct 2018 12:51:21 -0400 Received: from gateway23.websitewelcome.com ([192.185.50.250]:35811 "EHLO gateway23.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726194AbeJBQvV (ORCPT ); Tue, 2 Oct 2018 12:51:21 -0400 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 125091E60B for ; Tue, 2 Oct 2018 05:08:51 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id 7Hbng3zK8PvAd7HbnguuGk; Tue, 02 Oct 2018 05:08:51 -0500 X-Authority-Reason: nr=8 Received: from 174.206.93.92.rev.sfr.net ([92.93.206.174]:47828 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1g7Hbm-000e3D-Dz; Tue, 02 Oct 2018 05:08:50 -0500 Date: Tue, 2 Oct 2018 12:08:48 +0200 From: "Gustavo A. R. Silva" To: "J. Bruce Fields" , Jeff Layton Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] nfsd: fix fall-through annotations Message-ID: <20181002100848.GA31166@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 92.93.206.174 X-Source-L: No X-Exim-ID: 1g7Hbm-000e3D-Dz X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174.206.93.92.rev.sfr.net (embeddedor) [92.93.206.174]:47828 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace "fallthru" with a proper "fall through" annotation. Also, add an annotation were it is expected to fall through. These fixes are part of the ongoing efforts to enabling -Wimplicit-fallthrough Signed-off-by: Gustavo A. R. Silva --- fs/nfsd/vfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index d74583f..2751976 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -1407,6 +1407,7 @@ do_nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp, *created = 1; break; } + /* fall through */ case NFS4_CREATE_EXCLUSIVE4_1: if ( d_inode(dchild)->i_mtime.tv_sec == v_mtime && d_inode(dchild)->i_atime.tv_sec == v_atime @@ -1415,7 +1416,7 @@ do_nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp, *created = 1; goto set_attr; } - /* fallthru */ + /* fall through */ case NFS3_CREATE_GUARDED: err = nfserr_exist; } -- 2.7.4