Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1211233imm; Tue, 2 Oct 2018 04:47:00 -0700 (PDT) X-Google-Smtp-Source: ACcGV60Fttytz2Oqlo5yj5QMx5go1dG46Pz9JZ9Qf8WqShqgUOXSkRxhW0JJWBCZQq7WY45wMkRl X-Received: by 2002:a65:448a:: with SMTP id l10-v6mr14310898pgq.382.1538480820266; Tue, 02 Oct 2018 04:47:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538480820; cv=none; d=google.com; s=arc-20160816; b=aikMZtQUDcDH/LUeKbsppFShIatxo3U9oaBXpH8HatuhkybCbBin7PFSXZUdYe3wVB ZCOZMxQU+imHczXh4OM98DmSD/xXe8de1ki34gPBH302nBgHtrOmXd6lx3JO1YAkunWV Sfmm+muX0Q8ByJz8hOtEunH6YtTJJCSl0JsrPK29SKEK0flb8vdcY35V+p72zgMUL98h QjuNeS3MFeNRVW4f7dTCSVvtQKMwR7HXbhswhkVvpxfl/SC9IXwxV1FZ+YS5qXCPhbOY TeY29t5ldZBVjSZArK3RTqUi5bBqXwKZagsd7f1HV2UD67T3j7WBQAgUQk0wBYvxkpPY ovPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=kJkZnAckbT8gnaJtzCKAp3vrynTwzD4AmV1ZNNEG6f0=; b=cZXAsWH5cD33749JQWmap7cOFZJTZK/My7s7MKA3iR10hrymQq/w22UZNrMi7fgtFi TmA96NNRzz6oPDXzuY9oAoWxstu/DiLklxegajvnptAQAArC26tTzFFmLvn5TsvNfju2 D4IUinDgBTnQhuT8fssOzQyhTxxjxjTC2dCVXEFn2pc3itKpxFe21KQjlKEbnsVTIcjM CZIHNxxWwzZX8A0yNETVcCG5bz0aCJKwtcuPO8hGdW5OnfqMJCBC0CL5OwJnNTs/avsM H9Yg9xs8HUobYoiAOxHxL0qb/Let56vpt3lyVu9aZhyVqsiByQle87OXO/4lYS+m1i7K Of4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h2-v6si9207061plk.350.2018.10.02.04.46.45; Tue, 02 Oct 2018 04:47:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727644AbeJBS3Z (ORCPT + 99 others); Tue, 2 Oct 2018 14:29:25 -0400 Received: from foss.arm.com ([217.140.101.70]:35514 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727528AbeJBS3Y (ORCPT ); Tue, 2 Oct 2018 14:29:24 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B4007A9; Tue, 2 Oct 2018 04:46:31 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D12E83F5B7; Tue, 2 Oct 2018 04:46:29 -0700 (PDT) Date: Tue, 2 Oct 2018 12:46:27 +0100 From: Mark Rutland To: Hoan Tran Cc: Will Deacon , Tai Nguyen , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Open Source Submission Subject: Re: [PATCH v2] perf: xgene: Add CPU hotplug support Message-ID: <20181002114627.omsungd77lfmbqfj@lakrids.cambridge.arm.com> References: <1537382649-17266-1-git-send-email-hoan.tran@amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1537382649-17266-1-git-send-email-hoan.tran@amperecomputing.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hoan, On Wed, Sep 19, 2018 at 06:44:30PM +0000, Hoan Tran wrote: > This patch adds CPU hotplug support where the PMU migrates the context to > another online CPU when its CPU is offline. > > It fixes the below issue where the user does offline the CPU which is assigned > to this PMU. > > Assuming, CPU0 is assigned for this PMU. When the user does offline CPU0 > [root@(none) ~]# echo 0 > /sys/devices/system/cpu/cpu0/online > This PMU does not work anymore and shows the below error. > [root@(none) ~]# perf stat -a -e l3c0/cycle-count/,l3c0/write/ sleep 1 > Error: > The sys_perf_event_open() syscall returned with 19 (No such device) for event (l3c0/cycle-count/). > /bin/dmesg may provide additional information. > No CONFIG_PERF_EVENTS=y kernel support configured? > > With this patch, when CPU0 is offline, PMU migrates to another online CPU and > works on that CPU. > > Signed-off-by: Hoan Tran > --- > v2: > * Remove the cpuhp instance when unregistering the PMU Unfortunately, this has come through whitespae-damaged, with a disclaimer in the footer. Could you please resend with those two details fixed? Thanks, Mark.