Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1277053imm; Tue, 2 Oct 2018 05:51:45 -0700 (PDT) X-Google-Smtp-Source: ACcGV60o4mLMmjmwu+OzONKJT4pN0ueu9f1o9Wu2YhfL6HT6FD+m9rtZqibiBR9qpHjz5teZFQAf X-Received: by 2002:a63:b709:: with SMTP id t9-v6mr5884222pgf.366.1538484705761; Tue, 02 Oct 2018 05:51:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538484705; cv=none; d=google.com; s=arc-20160816; b=W+7RzMtRBO71x1JyRnPD/iN47kCuRvRSrFVqMKnY6KZefuBP986B8kFbXQLkUNt4x6 6GReem4Maz2/q3gsi0rwRwUOp61aPWWy/RxEnpOpyG2EmxKXOKW4qAQC6F1op+NBmjED T2OSwsSH6jVAlLEXKoNX6KvmIPwQCiFp7xOsUB7HR28ZPpLhxwUCitlavaQ7EGx4U1fs Yq8g0h+uDOt0uTjU9vhSe6OqhDjHCe750Fx9X/bAs6jlzwMryiupU/CNKnOEgGddUNsi CnWPnnv1vzJ1jdyCk6sDZK6wjG2MNgPDGhQeOTuTeFc2iav59Nsdd/Oq1PBiSHqQuza5 FNTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=ksmGJD08Ey5q2A4EhjIeV7maWIK5gZq+9o7pe2CR9Bk=; b=xbK9t5pHCd9QaNOroTEFhaDKUie8e3iT1obrgdUFTGBaPfku6Kkq+DC9dVj1CSSiPz XgOq8BLJH/rJo1yq16rhJ0MIhoO908qEzh8UP07aA1GE+Syw1GvS5pSJFLttR9Wowfn6 5RjMQkeWIr7yrkQ3r5+3RwS/mkI0LXWRKKavK1Tnr5hL4TIOj1+tU8SCb6LO6nymTmaL vQAnS+8nd2A9+QYZLd9aVQocPNgCN6F0SllHIoK5MM8W2VjmRQI0sqxT0yrPDIH94ZW7 nnTjn8CtVGdRaf3zsHr4LmUB9oGwnB85FjNWzkinmFi5s/8it99UzkNbkt1GOYqNT6Fi rfrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="MBfsT2/h"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m126-v6si17495792pfb.126.2018.10.02.05.51.30; Tue, 02 Oct 2018 05:51:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="MBfsT2/h"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727759AbeJBTed (ORCPT + 99 others); Tue, 2 Oct 2018 15:34:33 -0400 Received: from mail-it1-f196.google.com ([209.85.166.196]:36059 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727707AbeJBTed (ORCPT ); Tue, 2 Oct 2018 15:34:33 -0400 Received: by mail-it1-f196.google.com with SMTP id c85-v6so3413605itd.1 for ; Tue, 02 Oct 2018 05:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ksmGJD08Ey5q2A4EhjIeV7maWIK5gZq+9o7pe2CR9Bk=; b=MBfsT2/h9l2o/lpmI9rOxzm8t2zobwWMC+8RlhVlxFYMthPZyNLMYNY21IJFIRWz6U EpUXobCLkzgxstvJmZY6k1RhOVWG3xW8fc4IDqk/TtlLQZMO3zqdQmpkJxQjQaZ/gMDW 7ICrxk3IeNQirpJIETi8kTTjha5rXTFc/DBEE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ksmGJD08Ey5q2A4EhjIeV7maWIK5gZq+9o7pe2CR9Bk=; b=YEH2cH+PAfAuiEGebZHw9shHw39Eu+aAhoJW+qqyVAhhY/hKCcjS37jSYN83KUyA/M Wj75bFQUlMalILcRbs6fgNTQUrjNm9kEOpgP1GVCFmWdUXJm2EqJbSahbujWrA+ygt7n pBFg0YrSqjp6ruqV2kocwYgxTee6tDH50cNrCIQdHw+VHCn4hMotWTbWeP4QXwsQWFUx R6gf4ACDrxyRPKLAfo285HC20nwf2dMERt7/kJPOCkwLCVWh8UPZPix0OWgb17X8tahk Oaurz4vedWTI1K9ByQb30x8aA5Qi1C26xRNE6N8Rbii+WQCMcRGlKOlm5Df2sJ84Fw5W ZaBQ== X-Gm-Message-State: ABuFfogbnKtyMIhwv8h0uwdcDTaPihjz4KXcGU2zw7+tii7qsjfm+kGF DpbVTDf30ZG8PGFsgKlYRL6MwYYuPPfNeSEXF1F2Gw== X-Received: by 2002:a02:2505:: with SMTP id g5-v6mr11686371jag.112.1538484681116; Tue, 02 Oct 2018 05:51:21 -0700 (PDT) MIME-Version: 1.0 References: <20180921103604.13361-1-ricardo.ribalda@gmail.com> <20180921103604.13361-2-ricardo.ribalda@gmail.com> <153803107307.119890.10052910965015646333@swboyd.mtv.corp.google.com> <3e07cab8-0f3e-7474-8f6d-e6bb16e8f998@codeaurora.org> <5aea282d-6fc9-cd70-cec4-10f28aa819b9@codeaurora.org> In-Reply-To: From: Linus Walleij Date: Tue, 2 Oct 2018 14:51:07 +0200 Message-ID: Subject: Re: [PATCH v2] gpiolib: Show correct direction from the beginning To: timur@kernel.org Cc: Ricardo Ribalda Delgado , jhugo@codeaurora.org, Stephen Boyd , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 2, 2018 at 2:26 PM Timur Tabi wrote: > On 10/2/18 2:38 AM, Linus Walleij wrote: > >> But as today the only driver that seems to be using valid_mask is msm, > >> so perhaps a hack is something better and then when we have a second > >> driver that requires it we figure out the real requirements. But it is > >> definately your decision;) > > Please note that MSM is supposed to be the *first* driver, not the only, > driver that needs valid_mask. So let's not make any code changes that > limit this feature to the MSM driver. I just recently encouraged Thierry to reuse this for the Tegra186 driver: https://marc.info/?l=linux-gpio&m=153787164826821&w=2 Yours, Linus Walleij