Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1327585imm; Tue, 2 Oct 2018 06:35:33 -0700 (PDT) X-Google-Smtp-Source: ACcGV60AJunF1aUcESx8q9JkXgK+7Wr7u14/2E/hlr8onFpGywW2M3WZ8ukvm7KZP45tZ9trXmnl X-Received: by 2002:a62:798e:: with SMTP id u136-v6mr16151440pfc.95.1538487333322; Tue, 02 Oct 2018 06:35:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538487333; cv=none; d=google.com; s=arc-20160816; b=hXt6ekzoNgV/kr5bBYc2Bt9tu/NqWqKWscB3VxwInVhGw8MhshXxjHrPzRr+6FlY54 VSOZY7ySZNmunJnZO8zTfKjVcaRa9JlHAszO8ncbdaHw1h1J4U3YsUNGUzVUWd7UuEpr lYV79pV+eearaR5DNk413gfM6QLYlNSgzpFj4U9aMLbbAZuylpPnYClabX5+l0XaCfon 2PGzd4fb/4iCvfWv90K52qL9KRDzDwMzmD62gH6MvV5zPxqYZkBkrX3v5Qa1IxtRjv90 usXOebHeMyUOk5kxvK6r4mzJMgT3SwgBGhMiDlFqO5P7XU6Mk13YcbeBR8bTyL3RbzXi 7TGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=qlJozTbWYQ2MCujw81PczB9eFHqDTuzcu1IVsssRqL4=; b=VLp0uxw9jhII0pBnFen00fvquIzjYC1iZZArYqyTy/cBXz03aMvYrHPLqcxOHwlMoc aJPJXPtvFKA7ej5za3YIJcnaEKVQNaCBGk0cDldhVCU0K96UMH5puaWvZNNRMld1m7wh MxtmUPp0QRszNs8O7GO71EFMwot4tkKddzhqzD6+pFnXgdZm9nClpe85onvtqTGwBkM2 YzsLD4+nbY+/bcAOoHWInaBv9DZGrFhHnSpXAseRC71OnhIaQ/ur27JV38bnCqQgEoi0 MaflSFGmmmiSiuOel1WJ3RGyeVHSFnTEMoPS1ch+vJoesMnz92ly2w+Ltfey7j0U2s3Y 2LbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 38-v6si14623704pgo.7.2018.10.02.06.35.18; Tue, 02 Oct 2018 06:35:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731726AbeJBUQk (ORCPT + 99 others); Tue, 2 Oct 2018 16:16:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34814 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730263AbeJBUQj (ORCPT ); Tue, 2 Oct 2018 16:16:39 -0400 Received: from localhost (24-104-73-23-ip-static.hfc.comcastbusiness.net [24.104.73.23]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id CDC725AA; Tue, 2 Oct 2018 13:33:15 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tony Lindgren , Kalle Valo , Sasha Levin Subject: [PATCH 4.14 064/137] wlcore: Add missing PM call for wlcore_cmd_wait_for_event_or_timeout() Date: Tue, 2 Oct 2018 06:24:25 -0700 Message-Id: <20181002132503.051229405@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002132458.446916963@linuxfoundation.org> References: <20181002132458.446916963@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tony Lindgren [ Upstream commit 4ec7cece87b3ed21ffcd407c62fb2f151a366bc1 ] Otherwise we can get: WARNING: CPU: 0 PID: 55 at drivers/net/wireless/ti/wlcore/io.h:84 I've only seen this few times with the runtime PM patches enabled so this one is probably not needed before that. This seems to work currently based on the current PM implementation timer. Let's apply this separately though in case others are hitting this issue. Signed-off-by: Tony Lindgren Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/ti/wlcore/cmd.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/net/wireless/ti/wlcore/cmd.c +++ b/drivers/net/wireless/ti/wlcore/cmd.c @@ -35,6 +35,7 @@ #include "wl12xx_80211.h" #include "cmd.h" #include "event.h" +#include "ps.h" #include "tx.h" #include "hw_ops.h" @@ -191,6 +192,10 @@ int wlcore_cmd_wait_for_event_or_timeout timeout_time = jiffies + msecs_to_jiffies(WL1271_EVENT_TIMEOUT); + ret = wl1271_ps_elp_wakeup(wl); + if (ret < 0) + return ret; + do { if (time_after(jiffies, timeout_time)) { wl1271_debug(DEBUG_CMD, "timeout waiting for event %d", @@ -222,6 +227,7 @@ int wlcore_cmd_wait_for_event_or_timeout } while (!event); out: + wl1271_ps_elp_sleep(wl); kfree(events_vector); return ret; }