Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1335170imm; Tue, 2 Oct 2018 06:42:42 -0700 (PDT) X-Google-Smtp-Source: ACcGV61bri/RjaPmFzNL7nzu26p/QdDvWQcnFT0jeTFW4/RsXKhiSMwQeOx117mpVzuz56Y58LG5 X-Received: by 2002:a63:a09:: with SMTP id 9-v6mr14820941pgk.318.1538487762516; Tue, 02 Oct 2018 06:42:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538487762; cv=none; d=google.com; s=arc-20160816; b=vMa0q/jaxOJmLDAs4vWT2sVdrMsyH1BkyI6H/Oa4FRIU3HZuarwmV+YHfls1jKggRb VTZPFiSyAASkKIXmQUWudEgNGlevcq/YBiBA8IdaUIa5dax1Bt9cX06nAoA73kki04bh mBuFiCrLF3AJac5i2aGeu3cS70EH4xLJUla039iKjKmFQhax7vq8NEQR/e/oDcfKW7G4 DLwSLe8PIhXq9/m0pWaP3o88W6sKdQ7+CfCWMrZFNozLpzssc7nb3kiHzPpX1OhISDGj MVoET4CD7owLqq3FocgDoaEBkyVYTIyTtU7XI0Pc6JRsnh1HH+rGbqX/98KsLbqALcKE GbMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=Ton10Op0Q9ioCOtuREsBGzKqOrqAmg55oevPYJ3aDJw=; b=yDl8Ww5hV+Q4U7UES1MYOPfQTftjZuQ/GftpRv33F9Xdk+yjocJ9GzPDUtYLYVbT4f zuJ3NNw84pJtbjldknDD2EBnYQnJA8cGz0ANaM61y+ho2XDd/YfVJWCLjA4YupPOdLjW q1GIPax5c2YAkr5nG6zycdmE0Z54t34e+lj8rPGckCEz40wDDLxyETPJMfzpkYZhugVD CMW0yawpvyZ7VmTKm/HarxaD1SKFsp0xyAK2BfMJ+Z5CDoWfX+nPcaYqQnhuaQbngdS0 KhlP4rr4O2bAi1ldEAWtAI2w+FuwYq/OC5SGk1aMk4XTBvSo80YD1TONMmTxxG9zKKfh y5Sw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d127-v6si17424272pfa.189.2018.10.02.06.42.26; Tue, 02 Oct 2018 06:42:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733116AbeJBUTp (ORCPT + 99 others); Tue, 2 Oct 2018 16:19:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36126 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731925AbeJBUTl (ORCPT ); Tue, 2 Oct 2018 16:19:41 -0400 Received: from localhost (24-104-73-23-ip-static.hfc.comcastbusiness.net [24.104.73.23]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id BBA44B2F; Tue, 2 Oct 2018 13:36:16 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zhouyang Jia , Johannes Thumshirn , Manish Rangankar , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.9 46/94] scsi: bnx2i: add error handling for ioremap_nocache Date: Tue, 2 Oct 2018 06:25:00 -0700 Message-Id: <20181002132503.676911018@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002132500.494838053@linuxfoundation.org> References: <20181002132500.494838053@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhouyang Jia [ Upstream commit aa154ea885eb0c2407457ce9c1538d78c95456fa ] When ioremap_nocache fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling ioremap_nocache. Signed-off-by: Zhouyang Jia Reviewed-by: Johannes Thumshirn Acked-by: Manish Rangankar Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/bnx2i/bnx2i_hwi.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/scsi/bnx2i/bnx2i_hwi.c +++ b/drivers/scsi/bnx2i/bnx2i_hwi.c @@ -2742,6 +2742,8 @@ int bnx2i_map_ep_dbell_regs(struct bnx2i BNX2X_DOORBELL_PCI_BAR); reg_off = (1 << BNX2X_DB_SHIFT) * (cid_num & 0x1FFFF); ep->qp.ctx_base = ioremap_nocache(reg_base + reg_off, 4); + if (!ep->qp.ctx_base) + return -ENOMEM; goto arm_cq; }