Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1346049imm; Tue, 2 Oct 2018 06:53:03 -0700 (PDT) X-Google-Smtp-Source: ACcGV619a8bzZZvW9+X2L4Hp+Xr0/p/dJoltNK6QFyVG1862EApmceR1YXhhSIrLSP28pTCk4lGz X-Received: by 2002:a63:bd01:: with SMTP id a1-v6mr14522653pgf.12.1538488383360; Tue, 02 Oct 2018 06:53:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538488383; cv=none; d=google.com; s=arc-20160816; b=TwFt+bnGT6fmEGI/0MOS8Wpt06b9TasTuYzimdhGQ4AV8N2WUy93ZrF9eeX5dP96/+ GhX3ksmcDtilcsLOSIzOYltXjARiB9qMlbI6zJmRN7u92lx0XZMd5CcaOHAqxGThtVXA 14z6Jo41zZvWEq4b+4/xMWBUbX7VpqvTEQuGVN0C24kxT56jve4Px6uFgxSJjO4HPMAN Sjgpa/WSHTIXTy99RRsNQZwK2z1kTcW7IyW+3FqAD0jUZadxrXXihSZkeK7ef2jsTPYk nC874fXBRlhL7/5DFs1Vx+kcpt4wwpW06D50St9vTH2iq59Ae/vpaeC3KTKiPa7wRkIF oGNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=oeTnGQeCDjLjWHitAJjTtlMDoEsNe1VtXFGhBHgBfJ4=; b=NAXtRFHd8p/oCIzs5iJgoGQxeQza2NijmPzpm4Dj56X9gCk5yYtbTAL4cfFHazX6+W 4MSPTXaoYceO6u9l0YCLyhNHNYEN3fVMgxL90u7G2mKUC8ZnPDnEQrhY632Ww45iJIEQ aZq4fVhIO3HwrqAqN2c89AVJm4NAq6nJf6EDBndSzm8SVDpc1w95fZZDQhy6zerzvqlH cLop0jpD5A41tAFuzFDE9OjByeFz6B1we0Voc4wRZpI4W6CSH8pPeX5KaDnbaNWFMLGH uN5mL6Il0FWIy2RjugMN4oDY0aaiBYQtgOiwrDdNfZGYM4COH/3hCNFAIFYKJVop9FmB jbQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i10-v6si7707917pgc.420.2018.10.02.06.52.48; Tue, 02 Oct 2018 06:53:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731779AbeJBUQu (ORCPT + 99 others); Tue, 2 Oct 2018 16:16:50 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34886 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730385AbeJBUQu (ORCPT ); Tue, 2 Oct 2018 16:16:50 -0400 Received: from localhost (24-104-73-23-ip-static.hfc.comcastbusiness.net [24.104.73.23]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 3BFF2B2F; Tue, 2 Oct 2018 13:33:27 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zhouyang Jia , Johannes Thumshirn , Manish Rangankar , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.14 070/137] scsi: bnx2i: add error handling for ioremap_nocache Date: Tue, 2 Oct 2018 06:24:31 -0700 Message-Id: <20181002132503.478169502@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002132458.446916963@linuxfoundation.org> References: <20181002132458.446916963@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhouyang Jia [ Upstream commit aa154ea885eb0c2407457ce9c1538d78c95456fa ] When ioremap_nocache fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling ioremap_nocache. Signed-off-by: Zhouyang Jia Reviewed-by: Johannes Thumshirn Acked-by: Manish Rangankar Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/bnx2i/bnx2i_hwi.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/scsi/bnx2i/bnx2i_hwi.c +++ b/drivers/scsi/bnx2i/bnx2i_hwi.c @@ -2742,6 +2742,8 @@ int bnx2i_map_ep_dbell_regs(struct bnx2i BNX2X_DOORBELL_PCI_BAR); reg_off = (1 << BNX2X_DB_SHIFT) * (cid_num & 0x1FFFF); ep->qp.ctx_base = ioremap_nocache(reg_base + reg_off, 4); + if (!ep->qp.ctx_base) + return -ENOMEM; goto arm_cq; }