Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1365688imm; Tue, 2 Oct 2018 07:09:20 -0700 (PDT) X-Google-Smtp-Source: ACcGV61xbwDqd1N1AfnC1NlLTfVeHFawZs92OP7oSI/iMCrg0ZGqLOizMvWyhoqPdz6BUNirJrvC X-Received: by 2002:a65:664e:: with SMTP id z14-v6mr14286453pgv.347.1538489360056; Tue, 02 Oct 2018 07:09:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538489360; cv=none; d=google.com; s=arc-20160816; b=xn5IgUmiHJzeLWBMQ9OagMath18t4fuYNrdc6fkZuTyUBeQsA9HAchTa2BkVacnYxq ImX86U2LDqTV5E8QZpTzWn9tZfbAYG1X89T4tyWlvZRuNvnqc8vwGE2so7gGwOyjsr6B dxB1YS9B4IZ24MGz8rdwYNN1SATfy3lo5bY+FIJjxBdhMkm1P4R9GbZoQ6FPDuYVnv/q l0qDoyGyjNbxDVBREdxPIwbLmbtwnqpTMb1hy5jHYZcHeAWt8ZVbDgKpNjIqLYYaKU0w dUuolzH0xtyd3KYx/kZkBbPgKlaYfkwaQiNs/rhjJN6lVtoqC6iQSTADRpZJqCobK64i Q1sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=m3kk7SyZk/RHNxztbX62h8LMZ864EYGt/jWnSunuqLI=; b=AqC+AlG7bk5DMidfXzS0kSoo4hBhC8pY8mkvR/Ip9iij1HLDhB9AHvWV43PqyjQq8A k+Ge35uS1ESlknlwQ1KeoYboVuC93dCUyNs5m0NEZxWKI8XjrBovCOqGeuvgkj6Hl/5y HFMwrOFPU+uF5sjRLG0X3xYmkRZWqQ99cqgbIbOJp9vYpbzLVNbrNZEe+jJWQgQzM0KG iuaEnIBXSSLCuv0GWFHAmSiDdT/hqnG/6wF1oj3OLSMqSdDaZUTHCTbUcRULvM8+5m/v LLUs5O5oxEzJsg+Q4mKh1L2K+804I357KLUWIQ7kC3YORUgGO0Xgt/5SBAhdjyQK6ppo 98KA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s11-v6si14967345pgf.427.2018.10.02.07.09.04; Tue, 02 Oct 2018 07:09:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729688AbeJBUvh (ORCPT + 99 others); Tue, 2 Oct 2018 16:51:37 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60914 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729218AbeJBULm (ORCPT ); Tue, 2 Oct 2018 16:11:42 -0400 Received: from localhost (24-104-73-23-ip-static.hfc.comcastbusiness.net [24.104.73.23]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 334D1A67; Tue, 2 Oct 2018 13:28:21 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zhouyang Jia , Johannes Thumshirn , Manish Rangankar , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.18 105/228] scsi: bnx2i: add error handling for ioremap_nocache Date: Tue, 2 Oct 2018 06:23:22 -0700 Message-Id: <20181002132506.510127848@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002132459.032960735@linuxfoundation.org> References: <20181002132459.032960735@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhouyang Jia [ Upstream commit aa154ea885eb0c2407457ce9c1538d78c95456fa ] When ioremap_nocache fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling ioremap_nocache. Signed-off-by: Zhouyang Jia Reviewed-by: Johannes Thumshirn Acked-by: Manish Rangankar Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/bnx2i/bnx2i_hwi.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/scsi/bnx2i/bnx2i_hwi.c +++ b/drivers/scsi/bnx2i/bnx2i_hwi.c @@ -2727,6 +2727,8 @@ int bnx2i_map_ep_dbell_regs(struct bnx2i BNX2X_DOORBELL_PCI_BAR); reg_off = (1 << BNX2X_DB_SHIFT) * (cid_num & 0x1FFFF); ep->qp.ctx_base = ioremap_nocache(reg_base + reg_off, 4); + if (!ep->qp.ctx_base) + return -ENOMEM; goto arm_cq; }