Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1371060imm; Tue, 2 Oct 2018 07:13:43 -0700 (PDT) X-Google-Smtp-Source: ACcGV61hSU+0CD/SmtMyL+2RqEnbSd9ND+hVKxYKtoVIPHiZkoQE2PUuGmzCLt/NjCXVp6GI28Mg X-Received: by 2002:a62:178f:: with SMTP id 137-v6mr15100294pfx.215.1538489622933; Tue, 02 Oct 2018 07:13:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538489622; cv=none; d=google.com; s=arc-20160816; b=r2zLOKv1bOSeza89vXTuLU2zicBq2LL7xF88DsuV5PgP6kY+dDjAs6a0+S/sevgYiD lK55Vn2pNWJhN2zBrBT50aM1N3m4c9le97E80vtqi3GFtJ5lw2ucGPAR12Dmlg8Iro/v B+s8A8Xu11oOBvDcygf4VOTsjSt1dt2SBIsRiVkrVutobME8k0STQ3CAO4vlx5a79WJp BW9o4gGP2w3RTE6KtmRT5E4e35RXuW5acmA/8B39wuIuyZkRW098PlB1MviDr4gVO7mE +4aP37YkTOo0GRS6x4LRhajBpVTFpNvhvY1jGrB37Ao8O/Hw02690QLWli1uYoRYrdAC Ur/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=2FU/ncBh6XaORy75vQeKU2umbE0U63qvflMy4AZK6bE=; b=WS+xE9Vra9RblZxBV99AIVKoCErcxGPEKSgXaopfDuIweJaHb7T+kPxENbeyhm3iMo nSMNjg7K/SN7CbXB/VQvQ3v4M+WKlflOSCelT4tfU8UX1JT91QQaFZEm6gLugp0t5PGu S258GMkvLY+KQaFoNJBrt9ucjk0OoeGePPzVea7sYyfR8//TNdAx7GhY5UPCL3sFe13J cP5Nm4O/m3HNfJ5cSP6iYndzQ4jg59711MMifuyLf+htb/Cqr0Qk+fgKTZPj+oiyzKAn 9HqHrIh5JhVG85oH2bkBi9/VVZYSdrGo2H2AS9pwHmtZgO9D4gJLrTQqzMelDTgjA5rO Pplw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z9-v6si16161571pfg.46.2018.10.02.07.13.27; Tue, 02 Oct 2018 07:13:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728479AbeJBUKl (ORCPT + 99 others); Tue, 2 Oct 2018 16:10:41 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60242 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728384AbeJBUKk (ORCPT ); Tue, 2 Oct 2018 16:10:40 -0400 Received: from localhost (24-104-73-23-ip-static.hfc.comcastbusiness.net [24.104.73.23]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id DD9DDB2F; Tue, 2 Oct 2018 13:27:18 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexey Kardashevskiy , Michael Ellerman , Sasha Levin Subject: [PATCH 4.18 053/228] powerpc/powernv/ioda2: Reduce upper limit for DMA window size Date: Tue, 2 Oct 2018 06:22:30 -0700 Message-Id: <20181002132502.776650588@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002132459.032960735@linuxfoundation.org> References: <20181002132459.032960735@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alexey Kardashevskiy [ Upstream commit d3d4ffaae439981e1e441ebb125aa3588627c5d8 ] We use PHB in mode1 which uses bit 59 to select a correct DMA window. However there is mode2 which uses bits 59:55 and allows up to 32 DMA windows per a PE. Even though documentation does not clearly specify that, it seems that the actual hardware does not support bits 59:55 even in mode1, in other words we can create a window as big as 1<<58 but DMA simply won't work. This reduces the upper limit from 59 to 55 bits to let the userspace know about the hardware limits. Fixes: 7aafac11e3 "powerpc/powernv/ioda2: Gracefully fail if too many TCE levels requested" Signed-off-by: Alexey Kardashevskiy Signed-off-by: Michael Ellerman Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/platforms/powernv/pci-ioda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/powerpc/platforms/powernv/pci-ioda.c +++ b/arch/powerpc/platforms/powernv/pci-ioda.c @@ -2841,7 +2841,7 @@ static long pnv_pci_ioda2_table_alloc_pa level_shift = entries_shift + 3; level_shift = max_t(unsigned, level_shift, PAGE_SHIFT); - if ((level_shift - 3) * levels + page_shift >= 60) + if ((level_shift - 3) * levels + page_shift >= 55) return -EINVAL; /* Allocate TCE table */