Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1412786imm; Tue, 2 Oct 2018 07:51:03 -0700 (PDT) X-Google-Smtp-Source: ACcGV60aXDoSiFiCgd9mElnbokr18Axs0Cer0xIordGIfG5R2W0xeb1fD+pe2QtwWsvkBb7FOyW8 X-Received: by 2002:a63:584f:: with SMTP id i15-v6mr8616550pgm.178.1538491863773; Tue, 02 Oct 2018 07:51:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538491863; cv=none; d=google.com; s=arc-20160816; b=KqoOsqccU+LAevHX7SGph+tv+HukPWTGe2ymI5BngVnied4ooXuqiIgDAtn/Tysb24 Tr6vRO7MRLR8u4nAmelgNry3vVX9cg1KZ6hH7fNSvaUiwvJ7YNRKByikK9t0+BoJdgYR lA6bPZbHSJ84PJglEpZOyEdHe7vWkZ5+39qKW28X5g0HNHwXKzp1QN5KpdD8jJrBXRqo Md0cn4u11Y8d3fzrSCc6g41BxetIfR8uH0zkMnuSAQIuCI8eZGmHthLiaDX3Bunlqm2a LmKW5WfX9rbIdo8AiTr9/qhXxVjRgFZyPLrBgoZV/ElCSnOKWljqf4in2jGYN1nucSmQ N7vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:feedback-id:mime-version:user-agent :references:message-id:in-reply-to:subject:cc:to:from:date :dkim-signature; bh=BdT56fuVqDbQ8CqyioX1+lZD450caI9uP9Ibq592BC4=; b=x/6SF/7TkllkKXwfs2AEofwSEoZ4uTFBxY5IPom2NwL5DD4yfN4bMKQBxvBRvd0sd7 O42w8M+FaEZz4zG3EXfEGMa9tspuiQPbd4DEG2M6xPb+pBHI+T3i9gidyIZNJUwKwDhC uBVod/miCOIP7sMuNJwEGMgtCma5wzoButJzbpQDLo6MNAgSg2RJvIkdn+ByqgiS0mK0 WomsupKbdOkVAl8xluDiFwULtFYp2Bj79eL83C/noLSsbL+S7h2OREYhR7sxCezurEww U+yXzLllM/mBsRc3hpU+xVlotC/CnD8ZNarnBhhIs3mOxtL0MEnLiRoTZLrdrrQi3/JM gyWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazonses.com header.s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug header.b=c7D+Sk9x; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n5-v6si15024180pgg.186.2018.10.02.07.50.48; Tue, 02 Oct 2018 07:51:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazonses.com header.s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug header.b=c7D+Sk9x; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728658AbeJBVeJ (ORCPT + 99 others); Tue, 2 Oct 2018 17:34:09 -0400 Received: from a9-99.smtp-out.amazonses.com ([54.240.9.99]:57718 "EHLO a9-99.smtp-out.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728177AbeJBVeJ (ORCPT ); Tue, 2 Oct 2018 17:34:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug; d=amazonses.com; t=1538491822; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:MIME-Version:Content-Type:Feedback-ID; bh=I2MayZBrUEXwNtt0E/zuGW8V5/zWtFXk+v6KADxyvhI=; b=c7D+Sk9xlCw9v0GMu51DeJrGZibywzZqIjSeSBdthcsqjZ11EYFTZ7WGQKDOEOTS l25Ehr9CW30raPx+UqxG7W+t1AZ/WCGk0eza5Hq6tKUCeEd33M9XDh8U5k8HFz/UlYc MiDWDQrSsQbl3TVZJOc/4nowXsuLzEqurjBdztI4= Date: Tue, 2 Oct 2018 14:50:22 +0000 From: Christopher Lameter X-X-Sender: cl@nuc-kabylake To: Matthew Wilcox cc: Greg KH , zhong jiang , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, mhocko@kernel.org, mgorman@suse.de, vbabka@suse.cz, andrea@kernel.org, kirill@shutemov.name, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [STABLE PATCH] slub: make ->cpu_partial unsigned int In-Reply-To: <20180930132333.GA10872@bombadil.infradead.org> Message-ID: <01000166354231f3-1e953571-f9ec-4a73-a228-ff3692825b41-000000@email.amazonses.com> References: <1538303301-61784-1-git-send-email-zhongjiang@huawei.com> <20180930125038.GA2533@bombadil.infradead.org> <20180930131026.GA25677@kroah.com> <20180930132333.GA10872@bombadil.infradead.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SES-Outgoing: 2018.10.02-54.240.9.99 Feedback-ID: 1.us-east-1.fQZZZ0Xtj2+TD7V5apTT/NrT6QKuPgzCT/IC7XYgDKI=:AmazonSES Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 30 Sep 2018, Matthew Wilcox wrote: > > And the patch in mainline has Christoph's ack... > > I'm not saying there's a problem with the patch. It's that the rationale > for backporting doesn't make any damned sense. There's something going > on that nobody understands. This patch is probably masking an underlying > problem that will pop back up and bite us again someday. Right. That is why I raised the issue. I do not see any harm in backporting but I do not think it fixes the real issue which may be in concurrent use of page struct fields that are overlapping.