Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1833444imm; Tue, 2 Oct 2018 14:59:48 -0700 (PDT) X-Google-Smtp-Source: ACcGV62nBLamUYNrKIex1eaSL23z/UYhPWlF3zIktFembU9BbFFFMtndbo0NMR6Xm52M5aWlshqa X-Received: by 2002:a62:6948:: with SMTP id e69-v6mr18208503pfc.166.1538517588530; Tue, 02 Oct 2018 14:59:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538517588; cv=none; d=google.com; s=arc-20160816; b=a8Zo6bOlkrsPNx68tzOUsbEPkjkq0yP4g2FhkJsTSVO3765k4XJz5lkOXqjQcewYQ2 /xBBdExiX1SFvGT0OFeGZwlWhNVtGEnyq4X9yeLdxEviSae3Rev/UFlseFVZAK3NM0p6 BAu59yV6yVL+QQbsmffeMXltF9NINxD9maC/3RbrwSsWzPjBKzct7KFcnz9iD82m8UdX tRgd/52/kedxHfIWD7HtT9ZxZY6XDOTm2thJI7yIVksBk3O2MjHsXJYfiv/+++quqZR7 wAo4tulbKLwXdVoMANKB86RFLQdax2jRav+zutUbcpKIORyDqXAoxfS9VnZDUEXMKEWI DNKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=3xx56aYYFHl7443plE1wqQFfT6qYVs3QMVUjvian6rE=; b=VlIp8ZWwj81l25Bit9t6xi7PMGv2cD0d/BYTm5S/7EnfE5lu5dJA1eCoP6PmnMqTrp 6CE+5pJU3NJ/gNGX6Gx3kYN5f0LxhTe26bkD4DHmybrtNC0pEQNYb7+dB56leANfpFCA BkncFPB5o9fl5F/vRlzqV5+6K9GedZf4MjPCnQjgp+QNI+Tz6LRNNLqUj8XU98JIGZ5+ CK3RrDtO0DHW90RczbSSvopN/poXDkNNaVN4Dp6LX1zjMHq+tt9+7XmpSUYwtMHvCd8S lI7PodyUK94+GremcXcKDcXFFsGUwed7n23GZ3/qG5XE7Tak3MvgRNzLEaWBFHngiDzX mwfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@micronovasrl.com header.s=dkim header.b=DAtr3yRK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si17494014plz.351.2018.10.02.14.59.33; Tue, 02 Oct 2018 14:59:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@micronovasrl.com header.s=dkim header.b=DAtr3yRK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728757AbeJCEoy (ORCPT + 99 others); Wed, 3 Oct 2018 00:44:54 -0400 Received: from mail.micronovasrl.com ([212.103.203.10]:35798 "EHLO mail.micronovasrl.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727279AbeJCEox (ORCPT ); Wed, 3 Oct 2018 00:44:53 -0400 Received: from mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) by mail.micronovasrl.com (Postfix) with ESMTP id B81C0B00750 for ; Tue, 2 Oct 2018 23:59:22 +0200 (CEST) Authentication-Results: mail.micronovasrl.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=micronovasrl.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=micronovasrl.com; h=references:in-reply-to:x-mailer:message-id:date:date:subject :subject:to:from:from; s=dkim; t=1538517562; x=1539381563; bh=4F HVT5NrrG/QTe2Mj+ppLwr5ncrmz/fzttP4uUPdogc=; b=DAtr3yRK22EQBy7xQq pDYfF6I6uvGA9K+e3Y/nczV/VeNDsWkPoLVDYKZdd9wJf0y+mzy0S1heaqBNZZyp 0PfJCJuWaD+rwgbiVno0XgskYT/3xkDNAwDsp8RuZxKUl5eYsz/1FlEgmqQz0zWi U75I01TLX6fClc4zdedvkaqjI= X-Virus-Scanned: Debian amavisd-new at mail.micronovasrl.com X-Spam-Flag: NO X-Spam-Score: -2.9 X-Spam-Level: X-Spam-Status: No, score=-2.9 tagged_above=-10 required=4.5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9] autolearn=unavailable autolearn_force=no Received: from mail.micronovasrl.com ([127.0.0.1]) by mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2b80q05x1Ukd for ; Tue, 2 Oct 2018 23:59:22 +0200 (CEST) Received: from ubuntu.localdomain (146-241-101-147.dyn.eolo.it [146.241.101.147]) by mail.micronovasrl.com (Postfix) with ESMTPSA id B4A03B00A71; Tue, 2 Oct 2018 23:59:20 +0200 (CEST) From: Giulio Benetti To: Maxime Ripard Cc: David Airlie , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dan Carpenter , Giulio Benetti Subject: [PATCH 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if null Date: Tue, 2 Oct 2018 23:59:17 +0200 Message-Id: <20181002215917.1849-2-giulio.benetti@micronovasrl.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181002215917.1849-1-giulio.benetti@micronovasrl.com> References: <20181001093612.GA13672@mwanda> <20181002215917.1849-1-giulio.benetti@micronovasrl.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If using tcon with VGA, tcon->panel will be null(0), this will cause segmentation fault when trying to dereference tcon->panel->connector. Add tcon->panel null check before calling sun4i_tcon0_mode_set_dithering(). Signed-off-by: Giulio Benetti --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index e4b3bd0307ef..f949287d926c 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c @@ -491,7 +491,8 @@ static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon, sun4i_tcon0_mode_set_common(tcon, mode); /* Set dithering if needed */ - sun4i_tcon0_mode_set_dithering(tcon, tcon->panel->connector); + if (tcon->panel) + sun4i_tcon0_mode_set_dithering(tcon, tcon->panel->connector); /* Adjust clock delay */ clk_delay = sun4i_tcon_get_clk_delay(mode, 0); -- 2.17.1