Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1862414imm;
        Tue, 2 Oct 2018 15:33:52 -0700 (PDT)
X-Google-Smtp-Source: ACcGV62olHY4+X3uUZifrUqBjkMmRTKVYdXYhL7kT27DfzOfthK9u0mK2jw58CmpOks8+1hVRTo3
X-Received: by 2002:a17:902:968d:: with SMTP id n13-v6mr18729975plp.33.1538519632701;
        Tue, 02 Oct 2018 15:33:52 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1538519632; cv=none;
        d=google.com; s=arc-20160816;
        b=PGrsxxSwXe41h3PXzYCm1bpU1OGRhux4ULdsfp3DC2HT1g8q1At8wI+KyQH9a8dQaF
         d8QLDSwY1Ly76ltLtnybF23NtuA8YWZ6xKWR+8QD7TkUBJwe9SVPzwgZyd5MpcPXcnu+
         0VA+0F1+OIF7tMUpsjE917V2VbF+hbpK3UmpE01kFaZD4IYX7tG5Fu1ko5ZBvRPX6YTJ
         F0PMG95U/55tVo+ibyoxXTNUc6oxdMdRTLAyXCOK2VwTeD7YHTIoOn165I2tOn9RHibH
         seOe1ghXjt6N4C+1HwcVz2E0TAGL8wzQNtH8MfSI2d8oaX33dxaZxpQKENFWmeu9gHyq
         9Kdg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=xCgUao/VoX6wJZSXuI4jNo34hbMdFPxS1XNXPzsvnvg=;
        b=fDGDqLvZjZaxmh04hAv8rU9qUOkN3tqR3Lzd/zZf2/3+iHWd0+w7LlucwGr4ddcn/M
         39HwsZX4wY7QimnuqNVioeZKMoQappUZ0evqdP/Er7g17iKfOMJm6NQ6+o3WJVKyjLF/
         POE35G2ac1Jwscfp4hqxGXPmTHUqxk9os7W+jwYLfm+W2yMrcQklVV/kiFdWS0r/phqL
         iUOLJgPT7wEkoWtxvTJGWyBoeYdYSbDpfjhwPmtIe901gtCfXw/9brdhkpvFZCzzNmDM
         FfYuVr0T4PiNFDKGORBCpfcWxNMA62YucW6CvHHwDrMqqaF5mT3FUD6nGFZTQQxlmEF3
         oWcw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@google.com header.s=20161025 header.b=Vxd2X6no;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id v23-v6si8473896pgh.581.2018.10.02.15.33.37;
        Tue, 02 Oct 2018 15:33:52 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@google.com header.s=20161025 header.b=Vxd2X6no;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727287AbeJCFTD (ORCPT <rfc822;learnos2017@gmail.com>
        + 99 others); Wed, 3 Oct 2018 01:19:03 -0400
Received: from mail-lj1-f170.google.com ([209.85.208.170]:40004 "EHLO
        mail-lj1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725198AbeJCFTD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 3 Oct 2018 01:19:03 -0400
Received: by mail-lj1-f170.google.com with SMTP id r83-v6so3261877ljr.7
        for <linux-kernel@vger.kernel.org>; Tue, 02 Oct 2018 15:33:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=xCgUao/VoX6wJZSXuI4jNo34hbMdFPxS1XNXPzsvnvg=;
        b=Vxd2X6nou+R95Ctj+AV+z2G0YPm0Iq8KbHcBQ0yZI5JBROgsxc5SuzTPliO6TChPaH
         SbNEr5U9sGDA2NlFF2TNbqpvrXJ50XqMCRWQt1qwDbBtGMqMEJUad1WYxHhnk3fLJb21
         BaGtx+ZxQVamkyJoRaCOzth975IKy5jo0K6IGNDgKdnNcUmxa4R2KxbXHaZaRRWYAJmt
         WGQ3oo5Wy5D1epmRFpuAMV2P+7QsLb/XkCJP0I+uDEO5neHt6tDE1WidF0wwVPpaLeqb
         Z6wQ1CUIT6ILXV/ka/a4/GuhRW24xFxCoGsa5QXySTG4ann7u14lEpf1JqlCt8fkWgpM
         I/oA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=xCgUao/VoX6wJZSXuI4jNo34hbMdFPxS1XNXPzsvnvg=;
        b=gQ5PBukN8/IdNuRpJEc2w4cvHhC7XASKfvLJLKrAD8Qa13IcKY7gfGpC0cnyahwyxb
         ExfIjUBuac+VpXDxz3IRnydExDk6qaKxWcS6jKi6w7QIRG0+hUUqxUYDUOede51clRtj
         JfxT+XbZTK0kKLCmLcG9bZpaCZTMDbJ6MpSSt/SOyJZox0C89bmk/D6+WCc/jZYGGbFS
         nWvljlZKRsyxtVA4eQ8tFCqf688N0/PiwenRvBSiZJxnof16S9CAsrXNcs6zmddKmg7B
         SWYIUv2Bq2zbE1o53yZdHSJKBacpX94SYkACyw4aUFciz2KiLUVJL7LRQv7qRZToV5g8
         UsBA==
X-Gm-Message-State: ABuFfogOZnt3m52KzqjrJL76g9Int7Dtt+0NykgiIaFioVZfE7niu7S4
        kyeCTa3rf+ihR4XGSNIABKvWYjfBIYvfNn+R0SR8apDsh+8=
X-Received: by 2002:a2e:8457:: with SMTP id u23-v6mr9332726ljh.154.1538519603236;
 Tue, 02 Oct 2018 15:33:23 -0700 (PDT)
MIME-Version: 1.0
References: <20181002221903.19476-1-rkir@google.com> <20181002223021.GA30567@kroah.com>
In-Reply-To: <20181002223021.GA30567@kroah.com>
From:   Roman Kiryanov <rkir@google.com>
Date:   Tue, 2 Oct 2018 15:33:11 -0700
Message-ID: <CAOGAQer-MSSsUocmjing7FhJb1SEV0T5v9StYr=DDPdTJeU0cw@mail.gmail.com>
Subject: Re: [PATCH 01/15] platform: goldfish: pipe: Remove the
 goldfish_interrupt_tasklet global variable
To:     gregkh@linuxfoundation.org
Cc:     linux-kernel@vger.kernel.org, Todd Kjos <tkjos@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> I don't see a "global" variable here, what are you referring to.
>
> This one:
>
> > -static DECLARE_TASKLET(goldfish_interrupt_tasklet, goldfish_interrupt_task, 0);
>
> ?

Yes.

> That looks static to this file to me.
> what am I missing here?

It has a global lifetime but it is visible only in this file. How do I
say better, just drop the word "global"?