Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2061184imm; Tue, 2 Oct 2018 20:12:04 -0700 (PDT) X-Google-Smtp-Source: ACcGV62mbPe2+9kMdcnsAik77uorSl71FYGAMepMyqdIOGBpZGsdIhcELZb3cLzCNNtN7A5D3yfy X-Received: by 2002:a17:902:b585:: with SMTP id a5-v6mr19079135pls.259.1538536324592; Tue, 02 Oct 2018 20:12:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538536324; cv=none; d=google.com; s=arc-20160816; b=b7UY355lfnTPAQexZDs82KPIV+m/JcrQeo4Rm/4YtFgSAtWASeh56/QlDloKmeis5j qbEqShsPHfu1tJa5T42kK9MOp2/RvAGt6dpxStLs7cuY8gY30jiK7vbBqkRnZZ4rh19F OaQHZ6eW9/RE24oPKcEW0aP6qWocG5nb/LJcJk10hWwRmyNK1vfMNA9mc2QziXKWKHFK qwwcqJF52YT2DNB1cPvY0q34aK7kkxRxC0Y7Xv9QBEYddQlEiPDE4AQxC/QNUAHQ5EXo F8b321nEYE47yemYRHiwjNwUSQU6KLZqdP9q7MgTpKNI/uuqDXe79ZdO1HaJ4PWxfaL+ IMug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=HcMnms5NkXMIpyt2lpAkPgNHfGYOEJWkWhpGM08wkq4=; b=vIrFdF0UPWp8kdTFmOadRQ4/ebY1l1UcMt2auvPfDtHr9Xmz3GCtqntno9DoZd7lFp 8yPJ5jzaMN0aVDRsRM3cwAil9dC1Gr19MChhk5T4beK+w2U2gPDu7qMhPC332rtPZuGF UmXZnesyX/8KXD7moFmqlvPL5206uYs6XSn4wPD0UA4XrSCXXo1ptd6138cuHYJU4GE/ fKWcNJS835ZWGtseOXnFn8tAnb1vosvBlcgp+KaqnX3vRwmCg3g28BVu+inhbdQ6GDUz EGCJsQkxslU6fep9jpgR8rRbiOY05mmnt/oqQTIZk09uUh5IMyf8PIHlk6Tv8lDVuFgT o//Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=vBrAsMr2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w3-v6si5517988plb.355.2018.10.02.20.11.15; Tue, 02 Oct 2018 20:12:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=vBrAsMr2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726547AbeJCJ5h (ORCPT + 99 others); Wed, 3 Oct 2018 05:57:37 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:56429 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbeJCJ5h (ORCPT ); Wed, 3 Oct 2018 05:57:37 -0400 Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 5121f873; Wed, 3 Oct 2018 03:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; s=mail; bh=yOvHGQSsuxbS9p8SsM8HIZThH+g=; b=vBrAsM r2cGPNYOoICgxJ9s9fg5ccUs9WruKiFEAHby7tHqJpZqFU9rhQZ+9ZwAZdOkVwaD THgViWxlQO5SM/q/jeNMLpf4wtTOqg5muZbuCSn3PWOOz6AqPGwOrYFJIvs6H1AF FB2SJQ80t7bNVn4cimeJ7X8UyQRHfUqBxG8mk3ZhZxU5WIn3P7jjWk4z+0j0YBko hcO+0m5xhoejFRlP9NtoXStrDjWWLd1/Uw/6S4tC9LroJvvwDryYPg8JVYAZH/VA NwgEQJpgOrNhLwnGPhm9zcM26AKbaJiKq9wjjB+F22BDNS7cAH7vyag5N/BtAzNd k7oaUzuRHExeKJow== Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 6c7026f7 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Wed, 3 Oct 2018 03:11:02 +0000 (UTC) Received: by mail-ot1-f43.google.com with SMTP id 36-v6so4094034oth.11; Tue, 02 Oct 2018 20:11:09 -0700 (PDT) X-Gm-Message-State: ABuFfoiXyTNRqa0uCR6tTLv3Ncvh0wpbFJEntqldin1P0Sapplw4RxS6 Y3XwyS7nLiMf8SML1+Dq/6QQH6bxIQ9h1+5v74o= X-Received: by 2002:a9d:17d0:: with SMTP id j74-v6mr5198870otj.268.1538536268191; Tue, 02 Oct 2018 20:11:08 -0700 (PDT) MIME-Version: 1.0 References: <20180925145622.29959-1-Jason@zx2c4.com> <20180925145622.29959-20-Jason@zx2c4.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Wed, 3 Oct 2018 05:10:56 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next v6 19/23] zinc: Curve25519 ARM implementation To: Ard Biesheuvel Cc: LKML , Netdev , Linux Crypto Mailing List , David Miller , Greg Kroah-Hartman , Samuel Neves , Andrew Lutomirski , Jean-Philippe Aumasson , Russell King - ARM Linux , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 2, 2018 at 6:59 PM Ard Biesheuvel wrote: > Could you elaborate on what qhasm is exactly? And, as with the other > patches, I would prefer it if we could have your changes as a separate > patch (although having the qhasm base would be preferred) By the way, as of a few minutes ago, if you look in the development tree at the commit called "zinc: Curve25519 ARM implementation", that now shows the diffs to the original, as you requested. I'll probably obsess over that a little bit more before v7, but if you see anything gnarly there beforehand, I'd be happy to hear. Jason