Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2254708imm; Wed, 3 Oct 2018 00:35:12 -0700 (PDT) X-Google-Smtp-Source: ACcGV60FSZYwvFxEVeZoJa9OrhMb4YNO83I4IXkcz3B7Ve+wE8XxY/hdfGURlSo+ysoTO7dVTcfB X-Received: by 2002:a63:fe13:: with SMTP id p19-v6mr179829pgh.265.1538552112372; Wed, 03 Oct 2018 00:35:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538552112; cv=none; d=google.com; s=arc-20160816; b=G2qtdvJolISuRu53xn83QZk85A6XKE2/1cNk8oVOhq02LcMzyyZAfw8qDftFlxsLxR SspPFZOouZhtVSLwtvYxJQ3uJnviYzpZEuH4aEAIFw20cgOKzmKNOsgYUZWutLIgJvsO CVQkWKwJRW4R0ctn5zcXeimAXBL0BENPdiNHCus2ZacDDWV8AZusvu6fjOva7+OGNoxw RZZxOAAa+2Jbb/Kd9B1sTVAaSya80V/nTrHH1oQk7T3qjQRdDAKyNmu5wC9GfuBVABht bXInDOiQdWstTdnbBBpXBvp6Gc6buEJNSmeojWYr0HLuj6THtlwp2+9pjyPkJ0P3TDeQ 0rDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=43ifib7ypSd2V53d9a28LJVezvVvL18XUDyY9WlTsjA=; b=EoCXUO8qSVM4QMkNBPuaLBboW+CuVS4hPwS9QNazPa0kuFXxwk6+L3X5xLVhIM1Tiw iH4hsEA8sHT7cPDjBkJZK6sniMolF1VJmUrtfjHelllKmaQJmfUyTyfzPVjBVfi5mBLO iFeoQhPSjNguWYdLh6sFmLVxSLEc0fJGmYCzcqleqE14CXhCeLE81ucbTfOQNgH47crH MEAvrVjEtc/6uaesubM2rd09OCiJuQP2g9rnzZS5o2e4P2ZPHrJtjbFvOiiOFQ1sy5xa iXxeJeJO3WZP1jDC36Vm3FhPKMm558jp94sq7Xv+VCigwpdVa/cRGiAWSj/Z5sGMZrja 2yWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 7-v6si537410pgw.401.2018.10.03.00.34.57; Wed, 03 Oct 2018 00:35:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726970AbeJCOVh (ORCPT + 99 others); Wed, 3 Oct 2018 10:21:37 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:42724 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726672AbeJCOVh (ORCPT ); Wed, 3 Oct 2018 10:21:37 -0400 Received: by mail-ed1-f66.google.com with SMTP id n2-v6so4374060edo.9 for ; Wed, 03 Oct 2018 00:34:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=43ifib7ypSd2V53d9a28LJVezvVvL18XUDyY9WlTsjA=; b=UhxWt2dd3kusk+2k5/3lshnJJjTSZ1iMpfSIk1oUgjpTB0ljPMczXkZiF51GxI+24D g1bt1LNAStfr7Q4u+TPAd4smALP08nrWphriQ19p0C3WT/X1gHy4spkr1TnuDKjFPqic l1mwcigapxnsDJt4va1pUqZbdDjjXKCKCwpUHu/v6/wB88W1T16UAfteVc8JJBYdMeMg kJ/5Wh1Lw2usQaV7wGRRTCXtwj2Pal39Xs7h8NBrp5PlisnkQ3mItiEZTHaptk+WkdcU f7GqYA1DGmJoMp/7TDBO0BkpWL86n+KZTOnh85KGWLF9uttgu/WgyEBRGikkmEPIzYGN zGfQ== X-Gm-Message-State: ABuFfohcYHViTeJGimxMcsEupvVQ96We8lVhQaci0vfQTekKJAmKtzA6 VP2BpW7sZGzeN6Td1jTFTR+4z//N X-Received: by 2002:a50:9386:: with SMTP id o6-v6mr843264eda.248.1538552064623; Wed, 03 Oct 2018 00:34:24 -0700 (PDT) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com. [209.85.128.45]) by smtp.gmail.com with ESMTPSA id c18-v6sm135191ejz.68.2018.10.03.00.34.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Oct 2018 00:34:24 -0700 (PDT) Received: by mail-wm1-f45.google.com with SMTP id 143-v6so4616910wmf.1 for ; Wed, 03 Oct 2018 00:34:23 -0700 (PDT) X-Received: by 2002:a1c:8dd1:: with SMTP id p200-v6mr497362wmd.145.1538552063478; Wed, 03 Oct 2018 00:34:23 -0700 (PDT) MIME-Version: 1.0 References: <20181001093612.GA13672@mwanda> <20181002215917.1849-1-giulio.benetti@micronovasrl.com> <20181002215917.1849-2-giulio.benetti@micronovasrl.com> In-Reply-To: <20181002215917.1849-2-giulio.benetti@micronovasrl.com> From: Chen-Yu Tsai Date: Wed, 3 Oct 2018 15:34:09 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if null To: Giulio Benetti Cc: Maxime Ripard , David Airlie , dri-devel , linux-arm-kernel , linux-kernel , Dan Carpenter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 3, 2018 at 5:59 AM Giulio Benetti wrote: > > If using tcon with VGA, tcon->panel will be null(0), this will cause > segmentation fault when trying to dereference tcon->panel->connector. > > Add tcon->panel null check before calling > sun4i_tcon0_mode_set_dithering(). > > Signed-off-by: Giulio Benetti Fixes: f11adcecbd5f ("drm/sun4i: tcon: Add dithering support for RGB565/RGB666 LCD panels") Reviewed-by: Chen-Yu Tsai