Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <8c61fd04-969a-cb09-6595-7ee23d214ab1@canonical.com>
 <99f1353a-e1a0-5ade-4aad-3eb62ea42a66@canonical.com> <1538515983.4348.93.camel@arista.com>
In-Reply-To: <1538515983.4348.93.camel@arista.com>
From:   Guilherme Piccoli <gpiccoli@canonical.com>
Date:   Wed, 3 Oct 2018 07:46:14 -0300
Message-ID: <CAHD1Q_xv4PSsJ3AcKd5i+QZ8On9jqPZsa+p46bCiKubhzVJerQ@mail.gmail.com>
Subject: Re: [PATCHv5 3/7] tty: Hold tty_ldisc_lock() during tty_reopen()
To:     dima@arista.com
Cc:     linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 2, 2018 at 6:33 PM Dmitry Safonov <dima@arista.com> wrote:
> [...]
> Well, v5 passes 0day, so all previous reports are fixed.
> But there is a new one about reboot on parisc platform which takes ~3
> mins after the patch with ldisc locked on tty_reopen().
>
> I believe it's related to holding read side for too long..
> So, the patches still need another fix, heh.
>
> Unfortunately, I was a bit busy with other bugs hitting more in Arista.

Hi Dmitry, thank you! Yeah, I saw that reading the whole thread after
sending this email heheh
That's a bummer =/

Unfortunately, I don't have a reproducer to exercise your patch. Do you
have some recipe on how to reproduce it easily?
I'll try more, in order I can validate the reboot behavior here.


> > > I'd like to ask you if you did respin the patch with Greg's
> > > suggestion
> > > for the tag - I couldn't find it in LKML heheh
> > >
> > > Oh, if you can CC me in future spins of this patch (in case there
> > > any),
> > > I'd really be glad.
>
> Sure, will enlarge Cc list ;)
>

Thanks again!
Cheers,


Guilherme