Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2429723imm; Wed, 3 Oct 2018 03:51:17 -0700 (PDT) X-Google-Smtp-Source: ACcGV62N/+WZBAWykIoeR6iaTeCjzC/qkBWd4IS6I0oT86OlHtQkpNYmdjgUjaXq6g/sxuDgsGzq X-Received: by 2002:a62:e511:: with SMTP id n17-v6mr992147pff.210.1538563877616; Wed, 03 Oct 2018 03:51:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538563877; cv=none; d=google.com; s=arc-20160816; b=emcrjDGCiHqOteTLSyhd2g8SfvYkrFepMzPy5WhXHYcy+V5tkOEhtUkWcNZQztkJPG jx3IuqS1B4XWCu3ZRqFmkhywjHVkZfUSWVKczERvFu9HnmVC7NqJavXFvXW67Ut5L1Be cWKN4CfE/gafSbZqhyWzv++LZOod94GCOjhpb2RaVOEEGcuevN5TnNlsmIJOTfn9923v 8wTFFvFtObzKk+5uEQ6vTZYhI8wF8BVxCtFViDC2dsqQuHGn6cqoDqdSnJZVwRU8e/SK tPpUEaKJzb+t6HY5SdXvcamN4oktwD0xzOv7APNNNccGTWWf4WjNoK1OsnqxzKXDl9CZ nXrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=HUOi7j4p860pOn8VJgM4WJmwVZQ9jtM+xFsmpIuXjJ0=; b=sFPsIxR3er3hWPH0qGrtturC+cHHCbJ1GpQXjsqRVbcAF/lcOE6hiVvVnNVN7R26re uQcIOM5uWHB52u24/lj1TlZvBwCInF3ZXwU5t/drRqTGnje8BkAbiCBEDDQLvr/+3SE9 JynaK0QMSzkH30D5aacpjplRMu4nyqw0xsgyiZ3ySQB9+GiPIydKwewCLzDxtFLGIg+j c5QUympo6jtWpvOKNkccDcIjHzD7DbFxmKHwS9uIRoMXhY7NNivvBCMYtTtc5JANhSRK DIIWe8WHUwMIT9KyvGdm8lVyR4DKAlfTOOBDQCKYfTaLYJIw18LvYa/48REwpzBCGHfZ CZuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w24-v6si1167037pll.346.2018.10.03.03.51.02; Wed, 03 Oct 2018 03:51:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726814AbeJCRic (ORCPT + 99 others); Wed, 3 Oct 2018 13:38:32 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:49430 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726642AbeJCRic (ORCPT ); Wed, 3 Oct 2018 13:38:32 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9DB6318A; Wed, 3 Oct 2018 03:50:41 -0700 (PDT) Received: from [10.4.13.99] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2B6423F5A0; Wed, 3 Oct 2018 03:50:40 -0700 (PDT) Subject: Re: [PATCH v8 1/9] KVM: arm/arm64: Ensure only THP is candidate for adjustment To: Punit Agrawal , kvmarm@lists.cs.columbia.edu Cc: will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com, Christoffer Dall , stable@vger.kernel.org References: <20181001155443.23032-1-punit.agrawal@arm.com> <20181001155443.23032-2-punit.agrawal@arm.com> From: Marc Zyngier Organization: ARM Ltd Message-ID: <0809a9d0-d256-c23a-c3cc-0b2be33aecff@arm.com> Date: Wed, 3 Oct 2018 11:50:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181001155443.23032-2-punit.agrawal@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10/18 16:54, Punit Agrawal wrote: > PageTransCompoundMap() returns true for hugetlbfs and THP > hugepages. This behaviour incorrectly leads to stage 2 faults for > unsupported hugepage sizes (e.g., 64K hugepage with 4K pages) to be > treated as THP faults. > > Tighten the check to filter out hugetlbfs pages. This also leads to > consistently mapping all unsupported hugepage sizes as PTE level > entries at stage 2. > > Signed-off-by: Punit Agrawal > Reviewed-by: Suzuki Poulose > Cc: Christoffer Dall > Cc: Marc Zyngier > Cc: stable@vger.kernel.org # v4.13+ FWIW, I've cherry-picked that single patch from the series and queued it for 4.20. Thanks, M. -- Jazz is not dead. It just smells funny...