Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2436889imm; Wed, 3 Oct 2018 03:59:49 -0700 (PDT) X-Google-Smtp-Source: ACcGV63ymMNDfFsz7C/k97HOJT2SdYVfbrMz7C0QXs9x5NliJU/73+ivgQgZFnnUU/0pbFAgaaeR X-Received: by 2002:a62:1112:: with SMTP id z18-v6mr1035137pfi.200.1538564388956; Wed, 03 Oct 2018 03:59:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538564388; cv=none; d=google.com; s=arc-20160816; b=J7X0WO9i1R2UXnRyzBt+6h965H+QiQJbu3J3mArQ/s+9JA1EvhnbMLj1FLkml7ncHf 9aoxd491Gc2ndL+vNf//vem1UJVOkKZ4wo5TDzHrq6RGPFuTRXq59+WvyeHbLOCqhKx8 STRMSiCuapt/n6bU3teTx25oKbMaid6yjH8/PaDuVPpFNFSepRk+HBVz4NYa3xCcI9Zp SHDWjddBFMXFgvYj6P6A4fAq9c9CqFW/ihbiJIFQm4vXWMXlCuQsbeTy0WlPXlvzqXZ+ 9xT38rT+zEdWKBPM24eATJEwcUXNdjemnVmmiXJel3SzsRsp85qLF0AiAUZlFMiaw1e9 oSdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=yzhXoOvrTnjFREyQ6yejX4oO/FAkBwmwYBW59Aob8pg=; b=X4tgIqwXcvpYZUFXaVob+D+cKNfYkohABKbHoxpc9gKVPspLmdBSJQXl3+SQdW9Rep AIBTfYAQ17nAaNlnD0OgKCGfqYOsoyL3PRUacTPXMfH/Yf95t7ClegveW2OnVjnVb77/ kV+AsF+i3z+3Q5VLtY3TBCo5mH/V0DitpA3EGXiSrbu+QWYCvx37DZnI6PwMltjHnAAX 9Hhnt0lINdoUCZuv2P6ycqPXfqoYDVb6oq3Z/2IDvN9gGSFvNu0G3xPxh9eSiLnHS4NB ARkgj+lO9vwflo/234bvsLF9JDnV9qsyE5dK6KrusDr1+camp2I51I1NNJnAbCsNglSs 6ENg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 69-v6si1296532plc.388.2018.10.03.03.59.33; Wed, 03 Oct 2018 03:59:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726818AbeJCRrF (ORCPT + 99 others); Wed, 3 Oct 2018 13:47:05 -0400 Received: from foss.arm.com ([217.140.101.70]:49588 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbeJCRrE (ORCPT ); Wed, 3 Oct 2018 13:47:04 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 692DA18A; Wed, 3 Oct 2018 03:59:12 -0700 (PDT) Received: from localhost (e105922-lin.Emea.Arm.com [10.4.13.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 07DC23F5A0; Wed, 3 Oct 2018 03:59:11 -0700 (PDT) From: Punit Agrawal To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, will.deacon@arm.com, stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8 1/9] KVM: arm/arm64: Ensure only THP is candidate for adjustment References: <20181001155443.23032-1-punit.agrawal@arm.com> <20181001155443.23032-2-punit.agrawal@arm.com> <0809a9d0-d256-c23a-c3cc-0b2be33aecff@arm.com> Date: Wed, 03 Oct 2018 11:59:10 +0100 In-Reply-To: <0809a9d0-d256-c23a-c3cc-0b2be33aecff@arm.com> (Marc Zyngier's message of "Wed, 3 Oct 2018 11:50:38 +0100") Message-ID: <87tvm3i9dt.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Marc Zyngier writes: > On 01/10/18 16:54, Punit Agrawal wrote: >> PageTransCompoundMap() returns true for hugetlbfs and THP >> hugepages. This behaviour incorrectly leads to stage 2 faults for >> unsupported hugepage sizes (e.g., 64K hugepage with 4K pages) to be >> treated as THP faults. >> >> Tighten the check to filter out hugetlbfs pages. This also leads to >> consistently mapping all unsupported hugepage sizes as PTE level >> entries at stage 2. >> >> Signed-off-by: Punit Agrawal >> Reviewed-by: Suzuki Poulose >> Cc: Christoffer Dall >> Cc: Marc Zyngier >> Cc: stable@vger.kernel.org # v4.13+ > > FWIW, I've cherry-picked that single patch from the series and queued > it for 4.20. Thanks for picking up the fix.