Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 3 Oct 2018 13:10:02 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Leonard Crestez <leonard.crestez@nxp.com>
Cc:     "festevam@gmail.com" <festevam@gmail.com>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        Andy Duan <fugang.duan@nxp.com>,
        "anders.roxell@linaro.org" <anders.roxell@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "john.stultz@linaro.org" <john.stultz@linaro.org>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>
Subject: Re: [PATCH] regulator: fixed: Default enable high on DT regulators
Message-ID: <20181003121002.GA7132@sirena.org.uk>
References: <20181001204346.4655-1-linus.walleij@linaro.org>
 <28e88d54f6503cf1be577eb1872cdf2c50d7dfa3.camel@nxp.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z"
Content-Disposition: inline
In-Reply-To: <28e88d54f6503cf1be577eb1872cdf2c50d7dfa3.camel@nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--Nq2Wo0NMKNjxTN9z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Oct 02, 2018 at 01:42:38PM +0000, Leonard Crestez wrote:

> This turns the phy off and on again instead of leaving it up from uboot
> and it doesn't work for some reason. However looking at
> reg_fixed_voltage_probe introducing an edge seems to be intentional for
> regulators which are not marked with "enabled-at-boot". Right?

No, that's definitely not desired.  We don't want to change the state of
the regulator at all if we can avoid it unless the user explicitly asked
for it.

> It's possible that you exposed an imx board-specific bug: maybe power
> cycling the phy after uboot needs some missing fixup?

It'd probably also be good to sort this out though.

--Nq2Wo0NMKNjxTN9z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlu0sZgACgkQJNaLcl1U
h9ARzwf/TDz782KjZEXYQtLzP0xafi1ECfJMs7Uz0IYjGOsFT3Y3HCMymbvxoz4B
BYrSygqGSpjXhYVXmCsSkWbmmlFMxfb2X4F5KkAA/VDHg0xz9bpCRtRFjvGNWMPw
2Hw82/RbNl6YU2hluVC8PGlR64kRuxjMQfefrytGAX37FZDHDJrSD5RZEMTg8hB1
5k6ndT9Y3vIOw4s4VXFalwdzu+d8TfT2gotgoWG/Up9EK35/ZY5vz+9VGTYif5fz
TiUmQcBTYm+Utwlm87OQpDNtIs3hr/jDReiG2sqMssv2QjebuzUgR90KKKMSNT4l
1uLNAyYhZcDx/oDKuAwoAALp8xb80w==
=SqpF
-----END PGP SIGNATURE-----

--Nq2Wo0NMKNjxTN9z--