Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2593926imm; Wed, 3 Oct 2018 06:23:04 -0700 (PDT) X-Google-Smtp-Source: ACcGV6384cVWAOTM4/HJ3/lUFUSP6QM6iOq6cSsoW4eHeK7Wt92E7qpXK4PGYbuC9+wdAAy1+Neg X-Received: by 2002:a62:4c3:: with SMTP id 186-v6mr1603618pfe.156.1538572984347; Wed, 03 Oct 2018 06:23:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538572984; cv=none; d=google.com; s=arc-20160816; b=e0ss3H45A+GBQZibdSwbOBM5zFtGDtP2Ip3g2HZI5mQlGhlAYOlEqgDuSetm02QFEj 7uWvhNL3EJ9I0QTyRHIwngvdbcz21bh5oecUYnnVMviTTida4mJysVkNJat5lgF3TpHX XnONBEmNn+14ZrbGx46rGhf7mgSlcb1q5ntkxZZiqRtIBPYwqm50UunMIJC1ePNqxZ1x 7dTgA0k5sbw+JbODbm+KD9YBYq94CdoZ6mu7iiaLgtczKcVB0pDqXJx39qqNxEVlnzXL BpOwX92YGTpaXh8as5nnlDoRGPZruIE8980duTyQWvPdQAPWpJxGisGeP+SnCyNIOq/p 7chw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=bDD8DzvTe4/OXjJzhf97FeC16LX+Q3eAo0kaOoV1t8k=; b=jA3oVU15Yx+/xiKFx0bvjRoF8QjkHppwcWZfuXVwpnw5eqXamYSpk2q/iig8QnRhXP IRtCOaZVb9ItOyKgti1wNoS4tJRU7UemNtA6LrT4bx/sq+JSqVo6P8Bq5FWqDGpLncdX ALaJUW3kpFWOUaXJDgWADVelRbwMwSt6iC0ZQyNnVBPOGBaG9PSElmfR28UQ7kRNnyVk IXiR6hSBW2Frysy5FZDs9gCKrglApegCNByql/gTlho8Vb5uZyUe52pYi7jYcf0DLvsZ NQwh4YOqMha2WQFSaJURwndv8x5znPIAz7UpTt45ipsmFbGY8IErIw9cpGui+S3EwAdw +qMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1-v6si1614740plb.291.2018.10.03.06.22.48; Wed, 03 Oct 2018 06:23:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727077AbeJCUKu (ORCPT + 99 others); Wed, 3 Oct 2018 16:10:50 -0400 Received: from mail.bootlin.com ([62.4.15.54]:37368 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726725AbeJCUKu (ORCPT ); Wed, 3 Oct 2018 16:10:50 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id E50902090A; Wed, 3 Oct 2018 15:22:23 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from bbrezillon.fritz.box (AAubervilliers-681-1-24-95.w90-88.abo.wanadoo.fr [90.88.144.95]) by mail.bootlin.com (Postfix) with ESMTPSA id 2BFFE20726; Wed, 3 Oct 2018 15:22:13 +0200 (CEST) From: Boris Brezillon To: Wolfram Sang , linux-i2c@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Greg Kroah-Hartman , Arnd Bergmann Cc: Przemyslaw Sroka , Arkadiusz Golec , Alan Douglas , Bartosz Folta , Damian Kos , Alicja Jurasik-Urbaniak , Cyprian Wronka , Suresh Punnoose , Rafal Ciepiela , Thomas Petazzoni , Nishanth Menon , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vitor Soares , Geert Uytterhoeven , Linus Walleij , Xiang Lin , linux-gpio@vger.kernel.org, Sekhar Nori , Przemyslaw Gaj , Peter Rosin , Mike Shettel , Stephen Boyd , Boris Brezillon Subject: [PATCH v8 00/10] Add the I3C subsystem Date: Wed, 3 Oct 2018 15:22:02 +0200 Message-Id: <20181003132212.12619-1-boris.brezillon@bootlin.com> X-Mailer: git-send-email 2.14.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Sorry for the huge delay between v7 and v8 despite the small amount of things I was asked to fix/rework. This patch series is adding a new subsystem to support I3C devices. This is just adding support for basic features. Extra features will be added afterwards. There are a few design choices that are worth mentioning because they impact the way I3C device drivers can interact with their devices: - all functions used to send I3C/I2C frames must be called in non-atomic context. Mainly done this way to ease implementation, but this is still open to discussion. Please let me know if you think it's worth considering an asynchronous model here - the I3C bus and I3C master controller are now tightly coupled even though they're still allocated separately. There's now a 1:1 relationship between these objects, and the I3C master is no longer represented under the I3C bus object. Arnd, let me know if you had something different in mind, and I'll rework the implementation accordingly. - I2C backward compatibility has been designed to be transparent to I2C drivers and the I2C subsystem. The I3C master just registers an I2C adapter which creates a new I2C bus. I'd say that, from a representation PoV it's not ideal because what should appear as a single I3C bus exposing I3C and I2C devices here appears as 2 different busses connected to each other through the parenting (the I3C master is the parent of the I2C and I3C busses). On the other hand, I don't see a better solution if we want something that is not invasive. Missing features (will be added in separate patch series after initial support has been accepted/merged): - support for HDR modes (has been removed because of lack of real users) - no support for multi-master and the associated concepts (mastership handover, support for secondary masters, ...) - I2C devices can only be described using DT because this is the only use case I have. However, the framework can easily be extended with ACPI and board info support - I3C slave framework. This has been completely omitted, but shouldn't have a huge impact on the I3C framework because I3C slaves don't see the whole bus, it's only about handling master requests and generating IBIs. Some of the struct, constant and enum definitions could be shared, but most of the I3C slave framework logic will be different Note that this patchset is available on the linux-i3c repo[1]. Main change between v7 and v8: - The bus object is now embedded in the master_controller object (as suggested by Arnd) Main changes between v6 and v7: - I3C bus/master representations have been reworked to match what other subsystems are doing (master implicitly represented by the bus object) - I3C dev registration has been fixed - I3C bus mode selection has been fixed - Calls to readsl/writesl() in the Cadence I3C master driver have been fixed Main changes between v5 and v6: - Introduce {i3c,i2c}_dev_desc structures to better match how I3C master controllers (reservation of one HW slot for each device attached to the bus). With this solution, the resource migration that happens when a device lose its dynamic address and is re-assigned a different address is simplified on the driver side, because most of it is now handled in the core (reserve a new dev slot, reserve IBI resources and free all resources attached to the old slot) - Add I3C error codes (M0 to M2) so that the core and device drivers can have fine grained information on what caused an EIO error. Only minor things happened between v3 and v5 (you can go check the changelog in each patch for more details). Main changes between v2 and v3 are: - Reworked the DT bindings as suggested by Rob - Reworked the bus initialization step as suggested by Vitor - Added a driver for an I3C GPIO expander Main changes between the initial RFC and this v2 are: - Add a generic infrastructure to support IBIs. It's worth mentioning that I tried exposing IBIs as a regular IRQs, but after several attempts and a discussion with Mark Zyngier, it appeared that it was not really fitting in the Linux IRQ model (the fact that you have payload attached to IBIs, the fact that most of the time an IBI will generate a transfer on the bus which has to be done in an atomic context, ...) The counterpart of this decision is the latency induced by the workqueue approach, but since I don't have real use cases, I don't know if this can be a problem or not. - Add helpers to support Hot Join - Add support for IBIs and Hot Join in Cadence I3C master driver - Address several issues in how I was using the device model Thanks, Boris [1]https://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux.git/log/?h=i3c/next Boris Brezillon (10): i3c: Add core I3C infrastructure docs: driver-api: Add I3C documentation i3c: Add sysfs ABI spec dt-bindings: i3c: Document core bindings dt-bindings: i3c: Add macros to help fill I3C/I2C device's reg property MAINTAINERS: Add myself as the I3C subsystem maintainer i3c: master: Add driver for Cadence IP dt-bindings: i3c: Document Cadence I3C master bindings gpio: Add a driver for Cadence I3C GPIO expander dt-bindings: gpio: Add bindings for Cadence I3C gpio expander Documentation/ABI/testing/sysfs-bus-i3c | 146 ++ .../devicetree/bindings/gpio/gpio-cdns-i3c.txt | 39 + .../devicetree/bindings/i3c/cdns,i3c-master.txt | 44 + Documentation/devicetree/bindings/i3c/i3c.txt | 140 ++ Documentation/driver-api/i3c/device-driver-api.rst | 9 + Documentation/driver-api/i3c/index.rst | 11 + Documentation/driver-api/i3c/master-driver-api.rst | 10 + Documentation/driver-api/i3c/protocol.rst | 203 ++ Documentation/driver-api/index.rst | 1 + MAINTAINERS | 12 + drivers/Kconfig | 2 + drivers/Makefile | 2 +- drivers/gpio/Kconfig | 11 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-cdns-i3c.c | 411 +++ drivers/i3c/Kconfig | 24 + drivers/i3c/Makefile | 4 + drivers/i3c/device.c | 233 ++ drivers/i3c/internals.h | 26 + drivers/i3c/master.c | 2644 ++++++++++++++++++++ drivers/i3c/master/Kconfig | 6 + drivers/i3c/master/Makefile | 1 + drivers/i3c/master/i3c-master-cdns.c | 1670 +++++++++++++ include/dt-bindings/i3c/i3c.h | 28 + include/linux/i3c/ccc.h | 385 +++ include/linux/i3c/device.h | 331 +++ include/linux/i3c/master.h | 643 +++++ include/linux/mod_devicetable.h | 17 + 28 files changed, 7053 insertions(+), 1 deletion(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-i3c create mode 100644 Documentation/devicetree/bindings/gpio/gpio-cdns-i3c.txt create mode 100644 Documentation/devicetree/bindings/i3c/cdns,i3c-master.txt create mode 100644 Documentation/devicetree/bindings/i3c/i3c.txt create mode 100644 Documentation/driver-api/i3c/device-driver-api.rst create mode 100644 Documentation/driver-api/i3c/index.rst create mode 100644 Documentation/driver-api/i3c/master-driver-api.rst create mode 100644 Documentation/driver-api/i3c/protocol.rst create mode 100644 drivers/gpio/gpio-cdns-i3c.c create mode 100644 drivers/i3c/Kconfig create mode 100644 drivers/i3c/Makefile create mode 100644 drivers/i3c/device.c create mode 100644 drivers/i3c/internals.h create mode 100644 drivers/i3c/master.c create mode 100644 drivers/i3c/master/Kconfig create mode 100644 drivers/i3c/master/Makefile create mode 100644 drivers/i3c/master/i3c-master-cdns.c create mode 100644 include/dt-bindings/i3c/i3c.h create mode 100644 include/linux/i3c/ccc.h create mode 100644 include/linux/i3c/device.h create mode 100644 include/linux/i3c/master.h -- 2.14.1