Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2618225imm;
        Wed, 3 Oct 2018 06:44:44 -0700 (PDT)
X-Google-Smtp-Source: ACcGV62OLJa9UdGYAyQd9wg/3TF7TuBhCpSn4yPDu9H+k30UatXSIxoQRZxfn3wE7fpZuu1q9Aqe
X-Received: by 2002:a65:6204:: with SMTP id d4-v6mr1434903pgv.121.1538574284700;
        Wed, 03 Oct 2018 06:44:44 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1538574284; cv=none;
        d=google.com; s=arc-20160816;
        b=szqBzX0G+Hgq1200xtAClcyP29/NfbwMYTzPUgiWzfukZZzev/HIbgeY0dhKz9QphG
         n257KXxz/I94UucgpvNjBRmyT2qX5SdkwI3LzE7mE26Fj244eiFxQ3lfAN5sk1FYA42e
         wzDcLVt2HyOwQ6TKGRv/gk3JJcbEPdLXQ5IVumOh+5LoMHJx00T3HgtPgDhpgSbJBrA5
         79yKQXzTrUDa6kXowfyjjO5i3DhL/F9jtzAiKb+DUIoCcXpbsMQXwSpV28K6FCJawJfi
         OaCNey+UbleRFvN3Pb6R+CtYGqInnLhNL8xGMErt5ty8z/xnpbFLNEL4cTFHwtpW49ms
         /2Lg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=6j3IWV2p81h9Xqb2FuIIzULA4BXOu8oC3jw19ppoV9Y=;
        b=q8/gSvFHO23/okbChnBCjdRoPMJAzOyxqhvm4ly/Nbfv9iR1K0EvOuoPxbGkq/GhEQ
         barrrJTBtwjD9hyR4ciAayyJ45HX2E4WAMVDbIcZrRhGxd8gWxM7Nb45hXu3xcToF3f5
         W1tF/K7RPWwPCD1I+qUmOHqS8g5qC7HhWb0tOcUW4eMBqXnD/b6rq4GaZQ7QZ4oHnn34
         quZ0bQwBzTFyJEc3x0Dn5ZwpPXbctgg7OVXaNom/SbuXxJY2Oj9XCwP+IAom/OQCoAwS
         M8QR2Fz5qxSR2eDCMjA9EH/Txblr8OOQs5aUR25nvR+i9X7WpB8QeYWjWapnSgX9TSWT
         6kKQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=aUHhjkzJ;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id w31-v6si1624310pla.133.2018.10.03.06.44.29;
        Wed, 03 Oct 2018 06:44:44 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=aUHhjkzJ;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726950AbeJCUcn (ORCPT <rfc822;kerneldev.sdk@gmail.com>
        + 99 others); Wed, 3 Oct 2018 16:32:43 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:8093 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726694AbeJCUcn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 3 Oct 2018 16:32:43 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5bb4c7960000>; Wed, 03 Oct 2018 06:43:50 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Wed, 03 Oct 2018 06:44:14 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Wed, 03 Oct 2018 06:44:14 -0700
Received: from [10.21.132.143] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 3 Oct
 2018 13:44:12 +0000
Subject: Re: [PATCH V2 3/5] usb: xhci: tegra: Add genpd support
To:     Ulf Hansson <ulf.hansson@linaro.org>
CC:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        DTML <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>
References: <1538143910-24400-1-git-send-email-jonathanh@nvidia.com>
 <1538143910-24400-4-git-send-email-jonathanh@nvidia.com>
 <CAPDyKFrfcQX0-QrMKy=E=rif9-SjSfxc+LTMBUn5oqOquRdqRg@mail.gmail.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <4f532f84-4991-6916-b53d-036e7e98be97@nvidia.com>
Date:   Wed, 3 Oct 2018 14:44:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CAPDyKFrfcQX0-QrMKy=E=rif9-SjSfxc+LTMBUn5oqOquRdqRg@mail.gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1538574230; bh=6j3IWV2p81h9Xqb2FuIIzULA4BXOu8oC3jw19ppoV9Y=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=aUHhjkzJj6hHLVmunj8EqFM4NBrvIias0f5vjwjT/3+cOnDYDIOOHFVPPqgf/iyG0
         qib8r71+23BfC0gN4D75OGd+mr5kPIcsMzNwWjqXioQe5PsIbLoiv0XjplNgz26uhD
         gxGIfLwB3A8vIsFxN9BjOVITyAekWnNimI7XsiEyC6+fnrqxDq8VidV7m75SqSmV++
         q/Rz0cuBb32By4wRDB+Ur8HG0HRp/PU9Cuswy9QabPEaNzOvGeXPgRr5i1OsDP+yG3
         pq6YnB80jxi23GFep5h2Fc3z3GT4AInglM0r42aDQxnqkGK74WbWp6imHm/LHtfAUl
         dMp2Lzk4gPdTA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 03/10/18 10:52, Ulf Hansson wrote:
> [...]
> 
>>  static int tegra_xusb_probe(struct platform_device *pdev)
>>  {
>>         struct tegra_xusb_mbox_msg msg;
>> @@ -1038,7 +1095,7 @@ static int tegra_xusb_probe(struct platform_device *pdev)
>>                 goto put_padctl;
>>         }
>>
>> -       if (!pdev->dev.pm_domain) {
>> +       if (!of_property_read_bool(pdev->dev.of_node, "power-domains")) {
> 
> I am assuming the original check was because allowing the two
> power-domains to be (wrongly) modeled as one (or as a
> master+subdomain)?

Actually, the original check was added to prepare for supporting
multiple power-domains and that once we had proper support in place the
'pdev->dev.domain' would then be populated. However, given that this is
not used in the case of multiple power-domains, I simply changed the test.

> I was thinking that, perhaps we should add a new OF helper function,
> where one can get the number of specifiers being listed in the
> power-domains property. Would that help to easier distinguish what to
> do when dealing with backwards compatibility?

We could do, but it is not necessary here, because we never had any form
of genpd support for the Tegra xHCI driver.

Cheers
Jon

-- 
nvpublic