Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2627946imm; Wed, 3 Oct 2018 06:53:53 -0700 (PDT) X-Google-Smtp-Source: ACcGV60dTKC9Pgo13N/0QEJZbjDL42o3fe9SYp6f+67NxqLDRLy/Rv3LVlIBnHhRKWOV3FIan28u X-Received: by 2002:a63:29c6:: with SMTP id p189-v6mr1513080pgp.188.1538574833159; Wed, 03 Oct 2018 06:53:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538574833; cv=none; d=google.com; s=arc-20160816; b=LbESHs5iOtWH57JRSYsCyqvBypGy7XC95dVNANQ+d0nOm30jIjrzhUIlzudjQpGvEp dCcyjQkBXOKbibsyThekgQ5GfEBYoy3EvAFwvBl3djGqQaAUEftmVE7Nzj63yfTlP28z aFLVeengHRyUK/ozOR3XotJGdPlK2Ho+krJod1+Cm6/4PBbcWhsDy2D1IB2SsfcnRQGn LFLHL8zE3URz1fezipEzsFJk9nyaXim51DdHLez+LzEbnflX1jymzuBJOWpGh4ASizX0 ubzkFu7IaZ6RgUHFVKz3RdRhWVfneAaAIrqD4U6vn2pgOr/wk4kn6gMaXY0YAnHRHYN7 7+nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=mwWny6+eop83BvjE3Gi6awWyagNNoeC2NBqjhvX27yc=; b=jCYwB8IbQSy4/a7L6lS9FzR1p1mRTq+LP1MTLShmFYs7pis23VvnwTdjY0wb5JC/vy ZLo3DtC0hSiGOSCdirMxKlvKAqUojTlTGnATVpSQl3WssFt59eKVwPjHypgmNvLQF9TV DDNF9L25R3K3XTuSmMj526L9fnlQPquW1fsOUs/Kz33oRq3BwNLk0y+3WJxFU2e0Z1kR ciQHAGiuwIYhoCSvA+kb+PaydWjjDpoZ7lqR2Wkxj0C+aRn9cIxTjGGk0Sg9STiFDVcg VGXMScr9zAPv0/ei4seSnOX7mgbMTIogxmQIpFWK+dEMKlyQs8SprY98EgZadygInnxr 82QA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6-v6si1641048plr.91.2018.10.03.06.53.37; Wed, 03 Oct 2018 06:53:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727005AbeJCUlx (ORCPT + 99 others); Wed, 3 Oct 2018 16:41:53 -0400 Received: from mail-pl1-f174.google.com ([209.85.214.174]:39753 "EHLO mail-pl1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726694AbeJCUlw (ORCPT ); Wed, 3 Oct 2018 16:41:52 -0400 Received: by mail-pl1-f174.google.com with SMTP id w14-v6so3524788plp.6; Wed, 03 Oct 2018 06:53:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mwWny6+eop83BvjE3Gi6awWyagNNoeC2NBqjhvX27yc=; b=FbTLDeKnoBWMI01r+Qe/b2QantolU16uWfgnbRhm3wYafm6lFIMBfziuxJ5z54/IXz UuPSc6lKOQBRvSBPIx6nBm86MUF99KTeZfWlKxKs8LdBwnIaysMtRwehRUfSMrnK6v0+ /hKnyZWUPcs/CSfU105irS6dH9533PW7eprdBQLBdazsLotfqXCxqV9WTVLK2vUuteWg KCLuYtpkVKtf3w3B4EBZ+IzsnSlnGcfD48E8jezkIM58wUdyZKoDfQQlrcVa3epDvugf cQp06DKUI96CQy1bsatiQnOcPGwEKTPPAr6coaAcsjpRhXEZ+DFQ9r9QLNR6mNfrVKP+ ZmcQ== X-Gm-Message-State: ABuFfog/ByRWVAT2u8hFfsKdob4Nz+zimNQe3fpQ8yxme7vhLXTKVtyX 3txH3VDU21PxsTQcyjM1AmWb7bl0Aa8= X-Received: by 2002:a17:902:6b06:: with SMTP id o6-v6mr1753403plk.6.1538574801831; Wed, 03 Oct 2018 06:53:21 -0700 (PDT) Received: from asus.site ([2601:647:4601:42b4:3842:3e31:3bb6:cf62]) by smtp.gmail.com with ESMTPSA id r81-v6sm3032148pfa.110.2018.10.03.06.53.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Oct 2018 06:53:20 -0700 (PDT) Subject: Re: [PATCH 09/16] scsi: Replace spin_is_locked() with lockdep To: Lance Roy , linux-kernel@vger.kernel.org Cc: "Paul E. McKenney" , Karan Tilak Kumar , Sesidhar Baddela , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org References: <20181003053902.6910-1-ldr709@gmail.com> <20181003053902.6910-10-ldr709@gmail.com> From: Bart Van Assche Message-ID: <9c03e8e2-1fda-dd9e-2716-e45175111509@acm.org> Date: Wed, 3 Oct 2018 06:53:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20181003053902.6910-10-ldr709@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/2/18 10:38 PM, Lance Roy wrote: > lockdep_assert_held() is better suited to checking locking requirements, > since it won't get confused when someone else holds the lock. This is > also a step towards possibly removing spin_is_locked(). Reviewed-by: Bart Van Assche