Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 3 Oct 2018 17:11:14 +0200
From:   Boris Brezillon <boris.brezillon@bootlin.com>
To:     Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc:     David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        Richard Weinberger <richard@nod.at>,
        Zhouyang Jia <jiazhouyang09@gmail.com>,
        linux-mtd@lists.infradead.org,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 6/8] mtd: maps: gpio-addr-flash: Convert to gpiod
Message-ID: <20181003171114.51ab47b8@bbrezillon>
In-Reply-To: <20181001124351.31615-6-ricardo.ribalda@gmail.com>
References: <20181001124351.31615-1-ricardo.ribalda@gmail.com>
        <20181001124351.31615-6-ricardo.ribalda@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Ricardo,

On Mon,  1 Oct 2018 14:43:49 +0200
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> wrote:

> @@ -248,14 +252,19 @@ static int gpio_flash_probe(struct platform_device *pdev)
>  
>  	i = 0;
>  	do {
> -		if (devm_gpio_request(&pdev->dev, state->gpio_addrs[i],
> -				      DRIVER_NAME)) {
> +		unsigned int *gpio_id = (unsigned int *)gpios->start;
> +
> +		if (devm_gpio_request_one(&pdev->dev, gpio_id[i], GPIOD_OUT_LOW,
> +					DRIVER_NAME)) {
>  			dev_err(&pdev->dev, "failed to request gpio %d\n",
> -				state->gpio_addrs[i]);
> +				gpio_id[i]);
>  			return -EBUSY;
>  		}
> -		gpio_direction_output(state->gpio_addrs[i], 0);
> -	} while (++i < state->gpio_count);
> +
> +		state->gpios->desc[i] = gpio_to_desc(gpio_id[i]);
> +		if (!state->gpios->desc[i])
> +			return -EINVAL;
> +	} while (++i < state->gpios->ndescs);

Actually, I was thinking about using devm_gpiod_get_array() here and
defining a gpio lookup table in the board file registering the device.
This way, adding support for DT based parsing is transparent.

Regards,

Boris