Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2740629imm;
        Wed, 3 Oct 2018 08:28:42 -0700 (PDT)
X-Google-Smtp-Source: ACcGV60xyj9/eoxa5ASRG53/yBFAnFM4kHwhQZeRDZjwSRQVepSAmUNQMmwMv+NBcWvKhn3MEc3D
X-Received: by 2002:a62:184a:: with SMTP id 71-v6mr2150773pfy.246.1538580522695;
        Wed, 03 Oct 2018 08:28:42 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1538580522; cv=none;
        d=google.com; s=arc-20160816;
        b=xNwH1pwMAC02zgrA5tPtdWYxH32T0dLqRDOoa/oPdW4/ccumtI0zZouvqlAToa1TAc
         7TCEpa67mOPfRexw1KapI+G2uYiHYTu9NXj6+P1f+ueamKxalwf4ftt+hv3Q3Wr1JSmS
         UBWyXTg+XNR6vTP2lDf3eOnPIhHsqq99MIUj7fVFs1hPqjgUAupqrs/oJ4VQddqUnZ6j
         mOnPyEiFUnF45jNhjE3k24LqSN2hC3ZnsHiw+XyEp1y7li/wUhHihOCMWpqUXCb4i1n/
         m4HzbFkciuE5HwfXx9S8kx9u34OV1DK3h8bPmTvoUdWkV8C4T7XzTAKMDh8IQMZhWvZ+
         z6iA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:date:cc:to:from:subject:message-id;
        bh=aQsNyq2/JoBL5hZc8TOXDgVsinwzDXWFszbxOnMbgMM=;
        b=ESspPL4CnasdcXPaHQyc6FdI9BG9CpuurycT5G9opC1JmxcMif9lwEd+T0I3OznvYC
         AnbTzImQL+OO3CrAw8uu7IObKd785cUq0bRDhwPT0y728ziNhQJ1ywWDwMwQwNYeH66y
         DJR1C0UPDXJIqhzCcqgimfdqebLaa8vSZDeX/3Hi3hkuz24cWh3qh4TugRYWMXtFEuRu
         dRJ6cpHhce3IwQqBojE3P+GfrVofXfGnE7AdTou78ljXG3LterI4t6hLRmB8iRuhHgXt
         bXHY+LXkdsE5cTe3Q4/rAp9QBSV3cNi4bqwT306SSN0R1sp2xvDGjYdchprejt6WvbsX
         ywPQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id bh11-v6si1918071plb.196.2018.10.03.08.28.27;
        Wed, 03 Oct 2018 08:28:42 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727120AbeJCWRF (ORCPT <rfc822;kerneldev.sdk@gmail.com>
        + 99 others); Wed, 3 Oct 2018 18:17:05 -0400
Received: from mail-pl1-f194.google.com ([209.85.214.194]:38755 "EHLO
        mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726819AbeJCWRF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 3 Oct 2018 18:17:05 -0400
Received: by mail-pl1-f194.google.com with SMTP id b5-v6so3654068plr.5
        for <linux-kernel@vger.kernel.org>; Wed, 03 Oct 2018 08:28:13 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=aQsNyq2/JoBL5hZc8TOXDgVsinwzDXWFszbxOnMbgMM=;
        b=Egj/Ec7pRPFuNAWnw4dJZbNGGSH0NsMSKv4sN3L4TuGVKi8MQZAPZP3voJGBnaW7hC
         VLTzxVpkr7XWnKxv2ODaUO9U4yX4FYpsDldf09oKejPbbRIl6qgZ1AbiWSj7JU6QUqvT
         kZCSyxmZN1sQOQmKA/qIDGnqZaKZ6VwSkb6iIcd8upyib4SMYmi1cr/9HIC6ZslOBdae
         FXbQAEDbCNbYWU+gVnejVvzcYIbbwW36LezKJa05+D9+bt2/hRgJmT2+ptt+LD01n2/e
         zcK4D6FmpdpAxl/z/C73M5RD5Scv7A7Sv1Z9YrKk/KJ3WzzEhbkySiMVXBJQ6Ho1noKJ
         Okog==
X-Gm-Message-State: ABuFfohhScVnFqeh5WXHmBVnNmO16IjHthd3p0QqRikg5+wFxPv+wiD3
        iDGCmLd/KjLZkbF6zSDFtlQ=
X-Received: by 2002:a17:902:40d:: with SMTP id 13-v6mr2165949ple.257.1538580493402;
        Wed, 03 Oct 2018 08:28:13 -0700 (PDT)
Received: from ?IPv6:2620:15c:2cd:203:5cdc:422c:7b28:ebb5? ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5])
        by smtp.gmail.com with ESMTPSA id a79-v6sm3079057pfa.124.2018.10.03.08.28.12
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Wed, 03 Oct 2018 08:28:12 -0700 (PDT)
Message-ID: <1538580491.205649.6.camel@acm.org>
Subject: Re: [PATCH 2/6] lib/scatterlist: Use consistent types in sgl API
From:   Bart Van Assche <bvanassche@acm.org>
To:     Tvrtko Ursulin <tursulin@ursulin.net>, linux-kernel@vger.kernel.org
Cc:     tvrtko.ursulin@linux.intel.com,
        Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
        Bart Van Assche <bart.vanassche@wdc.com>,
        Hannes Reinecke <hare@suse.com>,
        Johannes Thumshirn <jthumshirn@suse.de>,
        Jens Axboe <axboe@kernel.dk>
Date:   Wed, 03 Oct 2018 08:28:11 -0700
In-Reply-To: <20180926141625.17727-3-tvrtko.ursulin@linux.intel.com>
References: <20180926141625.17727-1-tvrtko.ursulin@linux.intel.com>
         <20180926141625.17727-3-tvrtko.ursulin@linux.intel.com>
Content-Type: text/plain; charset="UTF-7"
X-Mailer: Evolution 3.26.2-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2018-09-26 at 15:16 +-0100, Tvrtko Ursulin wrote:
+AD4 From: Tvrtko Ursulin +ADw-tvrtko.ursulin+AEA-intel.com+AD4
+AD4 
+AD4 There is an incosistency between data types used for order and number of
              +AF4AXgBeAF4AXgBeAF4AXgBeAF4AXgBe
              inconsistency?
+AD4 sg elements in the API.
+AD4 
+AD4 Fix it so both are always unsigned int which, in the case of number of
+AD4 elements, matches the underlying struct scatterlist.

Anyway,

Reviewed-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4