Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181003110457.9318-1-Eugeniy.Paltsev@synopsys.com>
 <CAKMK7uFP3bMcNSY2L9ZmvFPz6KB51_gMnZ-b7FPCz3NEOafi=w@mail.gmail.com>
 <20181003123047.GK9144@intel.com> <1538577004.11140.5.camel@synopsys.com>
In-Reply-To: <1538577004.11140.5.camel@synopsys.com>
From:   Daniel Vetter <daniel@ffwll.ch>
Date:   Wed, 3 Oct 2018 17:29:34 +0200
Message-ID: <CAKMK7uGEGQbg=Us3_C25JXvKR084fP0qLif1hHttMYq=xNAZ7g@mail.gmail.com>
Subject: Re: [PATCH] drm: fb-helper: Validate requested pixel format against bpp
To:     Eugeniy Paltsev <eugeniy.paltsev@synopsys.com>
Cc:     "Syrjala, Ville" <ville.syrjala@linux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Alexey Brodkin <alexey.brodkin@synopsys.com>,
        linux-snps-arc@lists.infradead.org,
        stable <stable@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Sean Paul <sean@poorly.run>, Dave Airlie <airlied@linux.ie>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Oct 3, 2018 at 4:30 PM Eugeniy Paltsev
<eugeniy.paltsev@synopsys.com> wrote:
>
> On Wed, 2018-10-03 at 15:30 +0300, Ville Syrj=C3=A4l=C3=A4 wrote:
> > On Wed, Oct 03, 2018 at 01:36:00PM +0200, Daniel Vetter wrote:
> > > On Wed, Oct 3, 2018 at 1:05 PM Eugeniy Paltsev
> > > <Eugeniy.Paltsev@synopsys.com> wrote:
> > > >
> > > > Validate requested pixel format against bits_per_pixel to reject
> > > > invalid formats with subcomponents length sum is greater than reque=
sted
> > > > bits_per_pixel.
> > > >
> > > > weston 5.0.0 with fbdev backend tries to set up an ARGB x8r8g8b8 pi=
xel
> > > > format without bits_per_pixel updating. So it can request
> > > > x8r8g8b8 with 16 bpp which is obviously incorrect and should be
> > > > rejected.
> > > >
> > > > Cc: stable@vger.kernel.org
> > > > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> > >
> > > drm fbdev emulation doesn't support changing the pixel format at all.
> > > I think we should reject all such request, not just the invalid ones.
> > > Can you pls respin?
> >
> > FYI I once posted a patch to tighten up the fb-helper pixel format
> > stuff:
> > https://patchwork.freedesktop.org/patch/203189/
>
>
> Hi Daniel,
>
> will you take Ville's patch or should I create the new one which is only =
related
> to new pixel format validation in drm_fb_helper_check_var() ?

Ville's patch isn't the bugfix we're looking for, but a draft version
of what adding proper format support in drm's fbdev emulation could
look like. With lots&lots of open questions. Not anywhere near ready
for merging, and definitely not stable backport material.

So yes, still want the minimal bugfix.
-Daniel

>
>
> > > Thanks, Daniel
> > >
> > > > ---
> > > >  drivers/gpu/drm/drm_fb_helper.c | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_=
fb_helper.c
> > > > index 16ec93b75dbf..4f39da07f053 100644
> > > > --- a/drivers/gpu/drm/drm_fb_helper.c
> > > > +++ b/drivers/gpu/drm/drm_fb_helper.c
> > > > @@ -1610,6 +1610,13 @@ int drm_fb_helper_check_var(struct fb_var_sc=
reeninfo *var,
> > > >                 return -EINVAL;
> > > >         }
> > > >
> > > > +       if ((var->green.length + var->blue.length + var->red.length=
 +
> > > > +           var->transp.length) > var->bits_per_pixel) {
> > > > +               DRM_DEBUG("fb requested pixel format can't fit in %=
d bpp\n",
> > > > +                         var->bits_per_pixel);
> > > > +               return -EINVAL;
> > > > +       }
> > > > +
> > > >         switch (var->bits_per_pixel) {
> > > >         case 16:
> > > >                 depth =3D (var->green.length =3D=3D 6) ? 16 : 15;
> > > > --
> > > > 2.14.4
> > > >
> > > > _______________________________________________
> > > > dri-devel mailing list
> > > > dri-devel@lists.freedesktop.org
> > > > https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__lists.freede=
sktop.org_mailman_listinfo_dri-2Ddevel&d=3DDwIDAw&c=3DDPL6_X_6JkXFx7AXWqB0t=
g&r=3DZlJN
> > > > 1MriPUTkBKCrPSx67GmaplEUGcAEk9yPtCLdUXI&m=3Df12ZyEESIeavtqCUKutiZ9F=
6xtRFC2UUvdqnM4ywBx8&s=3DCPS8taMiYbIgXo-fxhqErOJXvO6PMTzmr-BNnGJIoy0&e=3D
> > >
> > >
> > >
> > > --
> > > Daniel Vetter
> > > Software Engineer, Intel Corporation
> > > +41 (0) 79 365 57 48 - https://urldefense.proofpoint.com/v2/url?u=3Dh=
ttp-3A__blog.ffwll.ch&d=3DDwIDAw&c=3DDPL6_X_6JkXFx7AXWqB0tg&r=3DZlJN1MriPUT=
kBKCrPSx67
> > > GmaplEUGcAEk9yPtCLdUXI&m=3Df12ZyEESIeavtqCUKutiZ9F6xtRFC2UUvdqnM4ywBx=
8&s=3DVt8OX9s9ljSK6GDgbnwsF-Yd35fbBUfe8SBV2jPnVaQ&e=3D
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__lists.freedesk=
top.org_mailman_listinfo_dri-2Ddevel&d=3DDwIDAw&c=3DDPL6_X_6JkXFx7AXWqB0tg&=
r=3DZlJN1M
> > > riPUTkBKCrPSx67GmaplEUGcAEk9yPtCLdUXI&m=3Df12ZyEESIeavtqCUKutiZ9F6xtR=
FC2UUvdqnM4ywBx8&s=3DCPS8taMiYbIgXo-fxhqErOJXvO6PMTzmr-BNnGJIoy0&e=3D
> >
> >
> --
>  Eugeniy Paltsev


--=20
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch