Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp140870imm; Wed, 3 Oct 2018 13:21:54 -0700 (PDT) X-Google-Smtp-Source: ACcGV62n8+CyDAf7p0X3QoCxOs4a3T9aSEH84x0+mCkIx2c9uqRuIMbcOk91zb8S01i5/olnWM0+ X-Received: by 2002:a65:5304:: with SMTP id m4-v6mr2885064pgq.250.1538598114409; Wed, 03 Oct 2018 13:21:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538598114; cv=none; d=google.com; s=arc-20160816; b=Jpm2fgjqlU2SWGH3jCfHvSwlJgY/SYSKP8U45Frhr8mwqXDMezNeQZDVkSveGTL6gu jalyt2DpkG1tl5eYEDyxiMnnFtpZzTM5wIYIRloQd7xX8XfzU97v1qgZOVVFlHY/lkm+ WX7FbxRMP0FU+6TYN0ngV7+aZ3vJSketrfHgAcUlI0I/IIoh48UpJ5a4CNk4jxhFR831 SHqJrBxabq6OOJM2NR/9nxLPQXYY+SlUkV53tNJ3ETGUCYzQYE4HBKS10mnUplmq7Leq SZrGEACP+jqub023Pldj+PzAn1IbzzYdV2B+KHFioMhOdA2tS1uKIZ8exd55AOPGPNuQ 5+KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=033RyFvNKlSbVw6i2VApoFOrFtsU+1DNEbnr5t2beSA=; b=QX7jHGFTMhht6AwmgZOs3zFS+k3+0K3zKuk2FTP6xYkEPws/AAWLQ9HtrIB18fx+sA o7yMTCrUrDyVhwGk89PzUN7c9IiwDqE96nBrT2Df6+XXfnOLCwgbAp2+x9w3mIoPE0B9 iEBQ7e9S/P7ndDCikp3/TPsrlGfMubo9Frw8og+vq4lhbZBGNVcCJtXHQ/2g45W4Ec4n /Tni+PDBUXkbApfiAMi+jA051EdV/6Yym5+7Ydejo+QvSYBjiHncpQSjjWWmyuu1Use8 T8vJvd7DXMOwG5BVmh8a2cHYHaR/1eGuYcQcPiMxHhUM/r5pgIQQxxD90in9Vg/QOY4U D8pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c14-v6si2291795pgm.556.2018.10.03.13.21.37; Wed, 03 Oct 2018 13:21:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727120AbeJDDL0 (ORCPT + 99 others); Wed, 3 Oct 2018 23:11:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46916 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726941AbeJDDL0 (ORCPT ); Wed, 3 Oct 2018 23:11:26 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F0021308FB8A; Wed, 3 Oct 2018 20:21:30 +0000 (UTC) Received: from asgard.redhat.com (ovpn-200-25.brq.redhat.com [10.40.200.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AF20E5D782; Wed, 3 Oct 2018 20:21:17 +0000 (UTC) Date: Wed, 3 Oct 2018 22:21:46 +0200 From: Eugene Syromiatnikov To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue Subject: Re: [RFC PATCH v4 4/9] mm/mmap: Add IBT bitmap size to address space limit check Message-ID: <20181003202146.GG32759@asgard.redhat.com> References: <20180921150553.21016-1-yu-cheng.yu@intel.com> <20180921150553.21016-5-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180921150553.21016-5-yu-cheng.yu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Wed, 03 Oct 2018 20:21:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 21, 2018 at 08:05:48AM -0700, Yu-cheng Yu wrote: > The indirect branch tracking legacy bitmap takes a large address > space. This causes may_expand_vm() failure on the address limit > check. For a IBT-enabled task, add the bitmap size to the > address limit. > > Signed-off-by: Yu-cheng Yu > --- > arch/x86/include/uapi/asm/resource.h | 5 +++++ > include/uapi/asm-generic/resource.h | 3 +++ > mm/mmap.c | 12 +++++++++++- > 3 files changed, 19 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/include/uapi/asm/resource.h b/arch/x86/include/uapi/asm/resource.h > index 04bc4db8921b..0741b2a6101a 100644 > --- a/arch/x86/include/uapi/asm/resource.h > +++ b/arch/x86/include/uapi/asm/resource.h > @@ -1 +1,6 @@ > +/* SPDX-License-Identifier: GPL-2.0+ WITH Linux-syscall-note */ > +#ifdef CONFIG_X86_INTEL_CET > +#define rlimit_as_extra() current->thread.cet.ibt_bitmap_size > +#endif Does this really belong to UAPI? > + > #include > diff --git a/include/uapi/asm-generic/resource.h b/include/uapi/asm-generic/resource.h > index f12db7a0da64..8a7608a09700 100644 > --- a/include/uapi/asm-generic/resource.h > +++ b/include/uapi/asm-generic/resource.h > @@ -58,5 +58,8 @@ > # define RLIM_INFINITY (~0UL) > #endif > > +#ifndef rlimit_as_extra > +#define rlimit_as_extra() 0 > +#endif And this? > #endif /* _UAPI_ASM_GENERIC_RESOURCE_H */ > diff --git a/mm/mmap.c b/mm/mmap.c > index fa581ced3f56..397b8cb0b0af 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -3237,7 +3237,17 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap, > */ > bool may_expand_vm(struct mm_struct *mm, vm_flags_t flags, unsigned long npages) > { > - if (mm->total_vm + npages > rlimit(RLIMIT_AS) >> PAGE_SHIFT) > + unsigned long as_limit = rlimit(RLIMIT_AS); > + unsigned long as_limit_plus = as_limit + rlimit_as_extra(); > + > + /* as_limit_plus overflowed */ > + if (as_limit_plus < as_limit) > + as_limit_plus = RLIM_INFINITY; > + > + if (as_limit_plus > as_limit) > + as_limit = as_limit_plus; > + > + if (mm->total_vm + npages > as_limit >> PAGE_SHIFT) I wonder, how realistic a scenario where a userspace application enables IBT, configures a huge prefetchable IO memory region (that just ignores bits of offset beyond 16, for example), and start repeatedly loading a legacy library there at different linear addresses. > return false; > > if (is_data_mapping(flags) && > -- > 2.17.1 >