Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5BB59DF5.7070106@huawei.com>
Date:   Thu, 4 Oct 2018 12:58:29 +0800
From:   zhong jiang <zhongjiang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     <andrew.donnellan@au1.ibm.com>, <fbarrat@linux.vnet.ibm.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2] misc: cxl: delete possible null pointer dereference
References: <1538621808-28080-1-git-send-email-zhongjiang@huawei.com> <20181004043812.GA8134@kroah.com>
In-Reply-To: <20181004043812.GA8134@kroah.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018/10/4 12:38, Greg KH wrote:
> On Thu, Oct 04, 2018 at 10:56:48AM +0800, zhong jiang wrote:
>> It is safe to dereference an object below a NULL test. For the sake
>> of debugging. Just delete the call of possible null pointer dereference.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>>  drivers/misc/cxl/guest.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
>> index 3bc0c15..472e8db 100644
>> --- a/drivers/misc/cxl/guest.c
>> +++ b/drivers/misc/cxl/guest.c
>> @@ -1018,7 +1018,7 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n
>>  
>>  void cxl_guest_remove_afu(struct cxl_afu *afu)
>>  {
>> -	pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
>> +	pr_devel("in %s\n", __func__);
> This call should just be deleted, it's not needed, ftrace can be used
> instead.
Fine.  Will do.

Sincerely,
zhong jiang
> thanks,
>
> greg k-h
>
> .
>