Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp535145imm; Wed, 3 Oct 2018 22:15:56 -0700 (PDT) X-Google-Smtp-Source: ACcGV60Eja9Yb8wsAwsR6YY6jpWqyvvCZ+yLEgfFNlOMC9fjbkl00GQO73XiA9oSsAfGW00ZoD2Z X-Received: by 2002:a17:902:e088:: with SMTP id cb8-v6mr4841181plb.189.1538630156940; Wed, 03 Oct 2018 22:15:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538630156; cv=none; d=google.com; s=arc-20160816; b=hbS6gPYKR9W+vGkJqi+6R2msHVA7f8Pq/7ARQF2VDAT5DKUukd0zokRY2hKqqHfjGV X82I/Ik3xfl3IrqmJo0oJdnQHn3sPyJwb4Z9WG/wLxkkckWrLassG6wmWJiDeTcCNPBl wdM2rUlvuZeK9AK0HRlx1+4VSu2XVobRLtImg1/nkMLFohzcTgtPZL1eDGnlwOJYQX1m tD8Zj0yYlNnrhTc3gLPc4bdQDS9C3yZYjEcqTL/wfcQxP+FxjxX/4WtGRqOJDv1B96pB FYC6+btdLPrEKlir8J1YXjZLI3/VWrhaKf/W2QRk7BHh8joCJBju3NuNrHmlvCBU6MS2 Gegw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=JKHrNjXr+zEkrIZnA7754GNAfac8jvL126JCsxM4JUQ=; b=nfXEcSZZDD1kXNgMX7OcGW+hlOUGZ8SE4wXLEweNWCebmFLecIJD+ZRcwzCRnc6SL1 xJPET4aWhyWbFwvhO8jNNNUJ+5DaZfqDL+fQyOLSsFUwJNTeyl3v6GrAhxVLsSemhwhb 4HjsiKquxkH0tvxgmUTLtjbeXZ510YvG2X01YfaF/HWcIGOgFCyX0JzQ/MXFmmfnUbrl +0lyr2F8+E1D8QIcKTwmpq8peCyrAu1mwaEzGIIpVyxPahUwToY6poQ2EcMfuqIUIMTG ZXGvYWuuKcwSsAFowFfa5q6K1T6PEzs55GnQQEX2bRun4I8zraNqGVRwogZNJx+r3nfd xhEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d32-v6si3822909pla.93.2018.10.03.22.15.27; Wed, 03 Oct 2018 22:15:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727009AbeJDMGw (ORCPT + 99 others); Thu, 4 Oct 2018 08:06:52 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:43490 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726656AbeJDMGw (ORCPT ); Thu, 4 Oct 2018 08:06:52 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id ED71DA06DC5B6; Thu, 4 Oct 2018 13:15:17 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.399.0; Thu, 4 Oct 2018 13:15:13 +0800 From: zhong jiang To: CC: , , Subject: [RESEND PATCHv2] misc: cxl: Fix possible null pointer dereference Date: Thu, 4 Oct 2018 13:02:53 +0800 Message-ID: <1538629373-33217-1-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is not safe to dereference an object before a null test. It is not needed and just remove them. Ftrace can be used instead. Signed-off-by: zhong jiang --- drivers/misc/cxl/guest.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c index 3bc0c15..5d28d9e 100644 --- a/drivers/misc/cxl/guest.c +++ b/drivers/misc/cxl/guest.c @@ -1018,8 +1018,6 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n void cxl_guest_remove_afu(struct cxl_afu *afu) { - pr_devel("in %s - AFU(%d)\n", __func__, afu->slice); - if (!afu) return; -- 1.7.12.4