Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp581293imm; Wed, 3 Oct 2018 23:15:08 -0700 (PDT) X-Google-Smtp-Source: ACcGV63UkVVf0FShxIxPm47x45OsZjRjJGgINGobV66D9VISBGqK8LuFke4NrnNQxpm8g/pW8kkh X-Received: by 2002:a17:902:aa42:: with SMTP id c2-v6mr4847444plr.119.1538633708501; Wed, 03 Oct 2018 23:15:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538633708; cv=none; d=google.com; s=arc-20160816; b=WJZVyYv8Retpyw/0D19e0I0KjhWKnutCNa/i5nhffWRc6OFkl5B+K0sj9KXAKfN8pz 2Nl7v7nb4DBGzhnL/9P+UhtGrmcsfQTAQ7T0ttnkL4xpVuzzlhgfqEXHEBlvZwLXeJab O+fR63YewPMjbzbrA9McPQs0tPUB1wXqBDnwclpSBMCl8qdCqnA/FYx3Sg9BLJyyylR5 C+xUZ54TVnB6m9awhzxtd6aNQoTt61HdPPVapEU+Ike4H5l//Y41TK4YWfLGjrV4EvBK c6NYLljmk7Dq1wyhi/qu5sLyvrtdVJVPE6yJGUO3nvINQ9c0C1Uk3DNA5JnPMHZdXONh 5rQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to; bh=3Xu9jRco8UipWOf/eLYvyENoGaHcMtIHgCo2ThT0Fxs=; b=K4SjBMLmadRZt9N+ybEKUw1A+fteG2dGojdn2sWtilvCzuWwu1H6uxO4MBvyxFoigf 4y0RFE8PPT8H771EYL/+Y8NHPFEcQdDoWVjf4tMbASau/Qg98u+xVG9bbNbAu5tCFyjY 0a6hmQ//82ge+6wgJAbgejIZd8RIoTtgBc2IkAa2QrpXKOii5eR8AjS3XOaeSQ2j8IAf r4YdXofsq9lALtPTgDdKbpqi0fv3By4SCKEbOOAvUXxhClX6Ou1cnr5XH4Ps/tF6Ka+9 scJiKEyJEzWUkbsNtj/Fr0xBPV9Y8WYP3Uivda16jGVSOsbG7Szi7jORf3jtzjaV1dJR v4aQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2-v6si4092827plh.206.2018.10.03.23.14.52; Wed, 03 Oct 2018 23:15:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727273AbeJDNGP (ORCPT + 99 others); Thu, 4 Oct 2018 09:06:15 -0400 Received: from ozlabs.org ([203.11.71.1]:45599 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726858AbeJDNGP (ORCPT ); Thu, 4 Oct 2018 09:06:15 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 42QjK66drTz9s7h; Thu, 4 Oct 2018 16:14:34 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: c417596d2409125b1814c05e994a21ef9282b894 In-Reply-To: <20180201175922.18930-1-robh@kernel.org> To: Rob Herring From: Michael Ellerman Cc: linuxppc-dev , Paul Mackerras , linux-kernel@vger.kernel.org Subject: Re: [v2] powerpc: pseries: use of_irq_get helper in request_event_sources_irqs Message-Id: <42QjK66drTz9s7h@ozlabs.org> Date: Thu, 4 Oct 2018 16:14:34 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2018-02-01 at 17:59:22 UTC, Rob Herring wrote: > Instead of calling both of_irq_parse_one and irq_create_of_mapping, call > of_irq_get instead which does essentially the same thing. of_irq_get > also calls irq_find_host for deferred probe support, but this should be > fine as irq_create_of_mapping also calls that internally. This gets us > closer to making the former 2 functions static. > > In the process of simplifying request_event_sources_irqs, combine the > the pr_err and WARN_ON calls to just a WARN(). > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Rob Herring Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/c417596d2409125b1814c05e994a21 cheers