Date: Mon, 24 Nov 2003 11:27:18 -0800
From: Andrew Morton <akpm@osdl.org>
To: Mingming Cao <cmm@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, marcelo.tosatti@cyclades.com,
       Paul.McKenney@us.ibm.com
Subject: Re: [BUG]Missing i_sb NULL pointer check in destroy_inode()
Message-Id: <20031124112718.1e650478.akpm@osdl.org>
In-Reply-To: <1069700440.16649.19433.camel@localhost.localdomain>
References: <1068045518.10730.266.camel@socrates>
	<20031105181600.GC18278@thunk.org>
	<1068066524.10726.289.camel@socrates>
	<20031106033817.GB22081@thunk.org>
	<1068145132.10735.322.camel@socrates>
	<20031106123922.Y10197@schatzie.adilger.int>
	<1068148881.10730.337.camel@socrates>
	<1068230146.10726.359.camel@socrates>
	<20031109130826.2b37219d.akpm@osdl.org>
	<1068419747.687.28.camel@socrates>
	<20031109152936.3a9ffb69.akpm@osdl.org>
	<1069700440.16649.19433.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 589
Lines: 14

Mingming Cao <cmm@us.ibm.com> wrote:
>
> destroy_inode() dereferences inode->i_sb without checking if it is NULL.
> This is inconsistent with its caller: iput() and clear_inode(),  both of
> which check inode->i_sb before dereferencing it.

I assume this has only been observed with an out-of-tree filesystem, but
yes, the consistency is good.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/