Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp654391imm; Thu, 4 Oct 2018 00:47:08 -0700 (PDT) X-Google-Smtp-Source: ACcGV62jzfSjDmIL2e9EyFWI09eYnzkCoyxZTyxqI9JuO2XhTnxCp3OurO5rqIxbfsNLLyC0jdp0 X-Received: by 2002:a63:c44a:: with SMTP id m10-v6mr4657879pgg.416.1538639228598; Thu, 04 Oct 2018 00:47:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538639228; cv=none; d=google.com; s=arc-20160816; b=uhZOURmRsHqNYnIAA2yRaP2ebZPjN8fGiXU5+mbmbTRfMGJknrci2rnomBzmYRlYG8 fVS0OZL1ziDAAF49daT7uTwZXMhdyEAIokWfvSdNLyUGJsSKcm90UsB6kTTr8E4flkYh cBGP+PXXqMTfC8YsPRz7HDklALhB2IAEQC9dONg4HzRLbQpc6ovaQIxAN8psRtX8eQG9 uv5LMq+poHgouteLtdi80dZG4qcP5Dy+Iw6OwC8kpgiaUeoC6HTe6hXf6tDE7vAUwgi/ 9iLN+oAA1pNExgLGyK8m1Aqe3CXXnJHNQ9LJK26QdYiRFIQAHkddM4lfe1flLRyd2SA7 PZVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature:dkim-signature; bh=vxTM+OqcctqySKouwvzyEAE4NIC++sPMMSVJnw31UTA=; b=UvAfNDnVGWt3jr8SxQkoOmioD7P5Ez/qypgnTC41z8Da2qsdjkK863M1ZBlf9a+G7z qaf7Wo7aixpePnchrUmscS+GH9sQ+UeW5NNlQemfCIqzlzZpcZLbCGp6yEeYnQqqawCu mrDPm3phvDkhl+7dzfIW/1fMWsrUMDMdvZOfUdytD3rDvJnaa6o5xMr+XrOaNjx8mgqj /xbugG+j0jrTQ5aJjMQYRzUdq0OT88MTh+AloM4hUe4H/IAzQEE/sZ8ubE5rcB4196Em aZ/2cZJxlffQf4uvCThZv3Kzwe4i+VjFSOI35yLbqmb6BQiu9CImWNifHa03LVQlX3LT QjJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=USgm8LgZ; dkim=pass header.i=@codeaurora.org header.s=default header.b=CUoSZaEx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j10-v6si3479861pgk.22.2018.10.04.00.46.52; Thu, 04 Oct 2018 00:47:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=USgm8LgZ; dkim=pass header.i=@codeaurora.org header.s=default header.b=CUoSZaEx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727715AbeJDOiX (ORCPT + 99 others); Thu, 4 Oct 2018 10:38:23 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:40378 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727429AbeJDOiX (ORCPT ); Thu, 4 Oct 2018 10:38:23 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 428BA60C85; Thu, 4 Oct 2018 07:46:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1538639187; bh=hPrj+O7jw+NB3lOsFapTmxWa6itS6tw33wUTru/drLQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=USgm8LgZey2bta0sR3HnyRJEjxowN3DnSa807nXIEBwHzuAotIdnwn6TOfX8BWQp5 EMh+NwA8/bYE0wkMgYR+YyVz7awYsKgtXKYvKXGPCTZy05s1nY8yW1QIlXvwfa6x0X 2Y7M6+kF3fB7Q5AIDS1m3JQiTi6cg4GC6jpTHoEg= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id D6CFB60227; Thu, 4 Oct 2018 07:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1538639186; bh=hPrj+O7jw+NB3lOsFapTmxWa6itS6tw33wUTru/drLQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CUoSZaExpx8vZZNal72Mm0+WNBhPgwiPKFcGLAAfEh6I0UCeDWnH4K7Mvdt5L+Atw Hzb9u0vk2I2eBNFXdDWdMPQkLRBvom82cDiK4q73vsZ+xEgfUI+8uG8XJDa1Gm4nSj zNJu5+8N3GQ2ycD8w1LH6IjwLivc7khyhdHsQ4dA= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 04 Oct 2018 13:16:26 +0530 From: alokc@codeaurora.org To: Doug Anderson Cc: Stephen Boyd , Wolfram Sang , LKML , linux-i2c@vger.kernel.org, linux-arm-msm , Karthikeyan Ramasubramanian , Sagar Dharia , Girish Mahadevan , linux-i2c-owner@vger.kernel.org Subject: Re: [PATCH v3 3/3] i2c: i2c-qcom-geni: Simplify irq handler In-Reply-To: References: <20180924235235.182649-1-swboyd@chromium.org> <20180924235235.182649-3-swboyd@chromium.org> Message-ID: <63135265545c5da50522e346e2a2d311@codeaurora.org> X-Sender: alokc@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-09-26 03:19, Doug Anderson wrote: > Hi, > > On Mon, Sep 24, 2018 at 4:52 PM Stephen Boyd > wrote: >> >> We don't need to use goto here, we can just collapse the if statement >> and goto chain into multiple branches and then combine some duplicate >> completion calls into one big if statement. Let's do it to clean up >> code >> some more. >> >> Cc: Karthikeyan Ramasubramanian >> Cc: Sagar Dharia >> Cc: Girish Mahadevan >> Cc: Doug Anderson >> Signed-off-by: Stephen Boyd >> --- >> drivers/i2c/busses/i2c-qcom-geni.c | 70 >> +++++++++++++----------------- >> 1 file changed, 29 insertions(+), 41 deletions(-) > > It doesn't gleam as powerfully the cleanups in patch 2/3 but this does > have a few nice readability improvements. > > Reviewed-by: Douglas Anderson agree. Reviewed-by: Alok Chauhan -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,a Linux Foundation Collaborative Project