Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp748568imm; Thu, 4 Oct 2018 02:40:55 -0700 (PDT) X-Google-Smtp-Source: ACcGV636GMP734nqCcaCOEk9LqR+3Ncn6gihsl6/33JAoGlOSPSxCHN+ZtE7RoPmLtdCTKSZ4L5G X-Received: by 2002:a17:902:7002:: with SMTP id y2-v6mr5950133plk.125.1538646055420; Thu, 04 Oct 2018 02:40:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538646055; cv=none; d=google.com; s=arc-20160816; b=eeLXMsQg4Z5dAnFWG/IYw+ni1tEOd2oT2r59KDzMQtCKPPyRE9bKOms8xkEUmqaaOs x06Lf5ytQaQF328rMQ0KUpHx+HOJHSrgNN6ta9poo9F5kMQ1iab6t14TwVrPbj8yUw+o 7bYmYoMwwfCIz/9hKU1KFBUyYUlYc03vLBiku23c90AOQBPu7qZJord7PoUFr2TjFwEf hNjrd3VQ1Nz2W8zIAmJs2O/y7ET4Ii/aRCAwiT+H7tiqG5ViAOtx6WXXySZCsbAja6Du yEoiIr4+b+Xo7pJd9rYrEpVBfJi7zz9NmydwHI26Xkbl04KvI0qRG472xh6BsY3gNpwb tRrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=z8r8LoaOZWeDbtwFqOllvDVX+B3ckIINyhYY9egIyLU=; b=MI/yuVObuNz4ufV85rQhib+u6oRKw4AAFInDIgb0KcOZT8gB2Nc1RvET0HJCg4K3XY smRGi3T9nx8EMATQUrCfd+thmp2rP76v/5gFRdsms4pCn7m7gx9uVdRaQnZ416nO4RIy 7XiZpVyl+LX04kFAPSI69jgGqnbM0pR+CnU++vt1ioGX4TdUyF6Ov0/XoZ2RvT6IUbKT 5JlWz+xVrMUucKIwnw1u3TzwGkLNQoihIVVGTyfcV/xugEcGuIKwXDa2/qazNEUcB+z6 SMrxyUO2kNIyITaDY/waxjLWYQlg8aN+cjGPP9CZbrxJ3l1G63fqi9VOkdT4yaRZIT9T s31A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=NiRPWaDg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iki.fi Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v189-v6si3456115pgd.429.2018.10.04.02.40.39; Thu, 04 Oct 2018 02:40:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=NiRPWaDg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iki.fi Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727956AbeJDQat (ORCPT + 99 others); Thu, 4 Oct 2018 12:30:49 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:40673 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727356AbeJDQar (ORCPT ); Thu, 4 Oct 2018 12:30:47 -0400 Received: by mail-lj1-f195.google.com with SMTP id r83-v6so7749207ljr.7 for ; Thu, 04 Oct 2018 02:38:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=z8r8LoaOZWeDbtwFqOllvDVX+B3ckIINyhYY9egIyLU=; b=NiRPWaDgdj9P0Y5ftCTwkUg1AhumcHNy2rcofQKQHHRyfMnQlbptjZapkI1BdG2/qX zKmfcVDjRIbrGBzm74IsoFeVBdnuvLOYCT1nMRYDGLWm73ygxPWjJg20ePmdKVhUHUbx imTlrdCOTTZCbDY8AuNEFw5uGTwDNNEP5eICIuedlLEMPvBsw2rtxDeLRusA9ozCS3rH 8qPPmmr9VLjumUimkrTKGdWgf/WgDXtVJT421E6pjqGq7YDaXgjbPe61RJ38NOOSMCV1 fGoRp4Oklf07LV3pR+y0eWdnXR3ydOvs9x0jnFRj6sbbJh8V/JRzdNkQLT/bN4veQprF 75fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=z8r8LoaOZWeDbtwFqOllvDVX+B3ckIINyhYY9egIyLU=; b=LLrAylhu9sRO6jxzv3TZnEUznS7yCZg/TqI5H75C31Wlmb04BekueIdXKwIFzXbYsU 4FnYmEVIcC4Kf2bjxGKU6NI0ln0QE3zb4DViVcV6zDeGuI4KeBea10JyjcoafZ1t/c5K fqcdY/dKxsjnHRhdJ7POQUTS2OQQUBNnYI+jU3rxiyYeVNcKiEM8CKuYXCakRSClOL3B V9higA6ATXeFGmJBNj33fHajcxopQ7ZdZx8LVE2HSMyjtLZaR/YratqrDePlXBVwBkz+ PyAu3NGCbUEq5jvPKul3G2+LtA7KVqX8UBP57Ba3fPch+KNqyXBslv15sb9hCTd5vUVq Wj4g== X-Gm-Message-State: ABuFfoib8wce89cXuOOxu6oYEcFYra1EiMQ0ZQjb/+NtiWva0CMaRWOq D1F65NZPP+bodlA1fDwRTLs= X-Received: by 2002:a2e:9cd3:: with SMTP id g19-v6mr3850034ljj.161.1538645900398; Thu, 04 Oct 2018 02:38:20 -0700 (PDT) Received: from localhost.localdomain (df8yyyyyyyyyyygn-tkvt-3.rev.dnainternet.fi. [2001:14ba:2700::157f:8223]) by smtp.gmail.com with ESMTPSA id f128-v6sm899738lff.40.2018.10.04.02.38.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Oct 2018 02:38:19 -0700 (PDT) From: Tuomas Tynkkynen To: Greg Kroah-Hartman Cc: Stefan Wahren , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, devel@driverdev.osuosl.org, Tuomas Tynkkynen Subject: [PATCH 1/7] staging: vc04_services: Drop pointless stub functions Date: Thu, 4 Oct 2018 12:37:41 +0300 Message-Id: <20181004093747.21750-2-tuomas.tynkkynen@iki.fi> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181004093747.21750-1-tuomas.tynkkynen@iki.fi> References: <20181004093747.21750-1-tuomas.tynkkynen@iki.fi> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These functions do nothing besides returning NULL and are unused. Just drop them. Signed-off-by: Tuomas Tynkkynen --- .../vc04_services/interface/vchi/vchi.h | 11 -------- .../interface/vchiq_arm/vchiq_shim.c | 27 ------------------- 2 files changed, 38 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging/vc04_services/interface/vchi/vchi.h index 3fe19d72b3ab..392c78200e9d 100644 --- a/drivers/staging/vc04_services/interface/vchi/vchi.h +++ b/drivers/staging/vc04_services/interface/vchi/vchi.h @@ -116,9 +116,6 @@ typedef struct service_info_tag { extern "C" { #endif -extern /*@observer@*/ VCHI_CONNECTION_T *vchi_create_connection(const VCHI_CONNECTION_API_T *function_table, - const VCHI_MESSAGE_DRIVER_T *low_level); - // Routine used to initialise the vchi on both local + remote connections extern int32_t vchi_initialise(VCHI_INSTANCE_T *instance_handle); @@ -292,14 +289,6 @@ extern int32_t vchi_bulk_queue_transmit(VCHI_SERVICE_HANDLE_T handle, Configuration plumbing *****************************************************************************/ -// function prototypes for the different mid layers (the state info gives the different physical connections) -extern const VCHI_CONNECTION_API_T *single_get_func_table(void); -//extern const VCHI_CONNECTION_API_T *local_server_get_func_table(void); -//extern const VCHI_CONNECTION_API_T *local_client_get_func_table(void); - -// declare all message drivers here -const VCHI_MESSAGE_DRIVER_T *vchi_mphi_message_driver_func_table(void); - #ifdef __cplusplus } #endif diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c index dddc828390d0..9235a974dae4 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c @@ -50,33 +50,6 @@ struct shim_service { void *callback_param; }; -/* ---------------------------------------------------------------------- - * return pointer to the mphi message driver function table - * -------------------------------------------------------------------- */ -const VCHI_MESSAGE_DRIVER_T * -vchi_mphi_message_driver_func_table(void) -{ - return NULL; -} - -/* ---------------------------------------------------------------------- - * return a pointer to the 'single' connection driver fops - * -------------------------------------------------------------------- */ -const VCHI_CONNECTION_API_T * -single_get_func_table(void) -{ - return NULL; -} - -VCHI_CONNECTION_T *vchi_create_connection( - const VCHI_CONNECTION_API_T *function_table, - const VCHI_MESSAGE_DRIVER_T *low_level) -{ - (void)function_table; - (void)low_level; - return NULL; -} - /*********************************************************** * Name: vchi_msg_peek * -- 2.18.0