Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 4 Oct 2018 11:20:12 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Leonard Crestez <leonard.crestez@nxp.com>
Cc:     "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andy Duan <fugang.duan@nxp.com>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "anders.roxell@linaro.org" <anders.roxell@linaro.org>,
        "john.stultz@linaro.org" <john.stultz@linaro.org>
Subject: Re: [PATCH] regulator: fixed: Default enable high on DT regulators
Message-ID: <20181004102012.GB6412@sirena.org.uk>
References: <20181001204346.4655-1-linus.walleij@linaro.org>
 <28e88d54f6503cf1be577eb1872cdf2c50d7dfa3.camel@nxp.com>
 <20181003121002.GA7132@sirena.org.uk>
 <c2ace38e09344d325271498fe8133c888470b5f6.camel@nxp.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="CUfgB8w4ZwR/yMy5"
Content-Disposition: inline
In-Reply-To: <c2ace38e09344d325271498fe8133c888470b5f6.camel@nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--CUfgB8w4ZwR/yMy5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Oct 03, 2018 at 06:08:09PM +0000, Leonard Crestez wrote:
> On Wed, 2018-10-03 at 13:10 +0100, Mark Brown wrote:

> > No, that's definitely not desired.  We don't want to change the state of
> > the regulator at all if we can avoid it unless the user explicitly asked
> > for it.

> That also makes sense, for a top level perspective. But
> reg_fixed_voltage_probe contains the following snippet:

...

> In theory it might be possible to request the GPIO while asking to keep
> the value from the bootloader? Maybe I'm confused but I don't see an
> easy way to do this through the GPIO api; functions for requesting in
> output mode all seem to also ask for the initial value.

There isn't one.  You're not supposed to read back an output GPIO at all
unfortunately, it makes this sort of handover stuff a problem.

> GPIOD_ASIS looks close but it doesn't even adjust the direction.

That's new - it's probably closest to what we want but we need to be
able to read back the state as well and will want to make it output if
it isn't already.

--CUfgB8w4ZwR/yMy5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlu16VwACgkQJNaLcl1U
h9AXtgf8CLj4MoHaShDENVRVrMhiytEHU9qh+BpvA7Na96mpdqGkNwtCWlSKwLpm
nqf51ObRrpGYJco0RafiocXvtwS3aVHoXPOf3S/3aRRegxWh6ileRp7vqTifFrcc
214fwVuok5HEgz3RGduj3hsG2WrhmxELYNufn5FOQNfxWRZf0ElLkq/rPwhmpXGP
yaUl72jQV+K17vzOBuLXm+jT+wmQA/H0XUT31gEtfSRhBskaJLn73TPBxusMXNup
QBJo/REEzovmUiE43nVPXvo9GOtPCpM+cpH6P90d8hD4+lKr+iEsu5EF97v0Di7X
q9eOWS+t5novPSdqVN6Y87iItHFIcQ==
=F6cU
-----END PGP SIGNATURE-----

--CUfgB8w4ZwR/yMy5--