Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RESEND PATCHv2] misc: cxl: Fix possible null pointer dereference
To:     zhong jiang <zhongjiang@huawei.com>, gregkh@linuxfoundation.org
Cc:     fbarrat@linux.vnet.ibm.com, linux-kernel@vger.kernel.org
References: <1538629373-33217-1-git-send-email-zhongjiang@huawei.com>
From:   Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Date:   Thu, 4 Oct 2018 21:59:01 +1000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <1538629373-33217-1-git-send-email-zhongjiang@huawei.com>
Content-Language: en-AU
Message-Id: <c8a51f44-937d-3cb7-82ad-0a42d9c7432d@au1.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/10/18 3:02 pm, zhong jiang wrote:
> It is not safe to dereference an object before a null test. It is
> not needed and just remove them. Ftrace can be used instead.
> 
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>

Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

> ---
>   drivers/misc/cxl/guest.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
> index 3bc0c15..5d28d9e 100644
> --- a/drivers/misc/cxl/guest.c
> +++ b/drivers/misc/cxl/guest.c
> @@ -1018,8 +1018,6 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n
>   
>   void cxl_guest_remove_afu(struct cxl_afu *afu)
>   {
> -	pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
> -
>   	if (!afu)
>   		return;
>   
> 

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited