Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1043058imm; Thu, 4 Oct 2018 07:23:14 -0700 (PDT) X-Google-Smtp-Source: ACcGV60qh/FniCHLWuPnKnzTTRDw+AXs/5I8Ezha0hxt1rtSmnVxJF63quMjiRaszZTZ3dS7r6hP X-Received: by 2002:a17:902:bc44:: with SMTP id t4-v6mr6929353plz.210.1538662994116; Thu, 04 Oct 2018 07:23:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538662994; cv=none; d=google.com; s=arc-20160816; b=Hk8yXmaZYBqzdBj61GDAPsjV0gNN2E8BvjGOLCmeyLRyUk95F//zTH+STkqc7RSu/e 6p+RzE3yaC2J/mSXh8wl1LaYk5GSvpkwdR8wlxYRtfJfyUiCT7ah9863uJyj+rvnvP2H LKOEeBe3nWxCOgZsKCvzWfLy5LxHJiHJMRBltLUHNM9KSgYSijr3XYFMen3ScRboUdcE VSZGErB2jZEX+in22YO6ffcl2xH3rY8Hmxyr9TK8VoAI/84+DsqQJJvGTA61Xp3SAPX2 1blvZCnX7FioW/iEpMw7OKKBqI6Gd2bigofwowASvCGvYSXox8l1RerN3npKhVan9eHn 1N6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=JIXjG3W+MSWUb8w6jEjU8q+6CGICrTyYRQIu73tzpn4=; b=Gm2kdhpDdYxCV7gUahxFwO6n1cLNXeNTt6A0G+Pcw3VaJZbyuB9hNB2EffTEZYsLd9 Bu6Ao2rmuzqip2mtP+2QsbIcjkA4hmAcQSDXhO4GlDtSHe2Ehj+jI/pMPCV/brry+vIg 6O8OjigRpBDzi44wVtb3udsivQQhF+A9QlSWe2W+K76mRJ68STYjIUTf/ts3ChxGm8Bt dChssPd71FyHq3lixpmDQcrHiNkczjo+LNHlrb/DncJLWl/C+H6cRwl7RyvoXhaRURmj rhaFLfgg34WchPNHSkuQan8bRBGDIJDzmZIdmFnq8bSU6x3Z3QlFsKZjTmtrgEEQm4Mi XhZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j4-v6si5136133pga.152.2018.10.04.07.22.58; Thu, 04 Oct 2018 07:23:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727576AbeJDVQG (ORCPT + 99 others); Thu, 4 Oct 2018 17:16:06 -0400 Received: from mail.bootlin.com ([62.4.15.54]:41175 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727322AbeJDVQF (ORCPT ); Thu, 4 Oct 2018 17:16:05 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 5AE7B207F3; Thu, 4 Oct 2018 16:22:32 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from bbrezillon (AAubervilliers-681-1-28-153.w90-88.abo.wanadoo.fr [90.88.148.153]) by mail.bootlin.com (Postfix) with ESMTPSA id 1756720726; Thu, 4 Oct 2018 16:22:32 +0200 (CEST) Date: Thu, 4 Oct 2018 16:22:32 +0200 From: Boris Brezillon To: Janusz Krzysztofik Cc: Miquel Raynal , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op() Message-ID: <20181004162232.5ac363be@bbrezillon> In-Reply-To: <38470936.GRFaOSl3cF@z50> References: <20180719081508.5dafebde@bbrezillon> <7546835.d2Xs8Qh0bZ@z50> <20181004155933.0a32c4ac@bbrezillon> <38470936.GRFaOSl3cF@z50> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 04 Oct 2018 16:11:42 +0200 Janusz Krzysztofik wrote: > > Legacy nand_wait_ready() uses a hardcoded timeout value of 400 ms. Should we > follow the same approach in nand_gpio_waitrdy(), or should we rather let > drivers pass the timeout value, like in case of nand_soft_waitrdy()? The latter.