Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1093322imm; Thu, 4 Oct 2018 08:06:14 -0700 (PDT) X-Google-Smtp-Source: ACcGV60rIiBAEhZrSrpISP+tEHPA/XVIKKhYwDn58EYCPL2l82bbAg4yiTnF0UoAIOC7+Q4J8gAQ X-Received: by 2002:a62:4586:: with SMTP id n6-v6mr7063241pfi.3.1538665574790; Thu, 04 Oct 2018 08:06:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538665574; cv=none; d=google.com; s=arc-20160816; b=EeGOVDY1MUew7qpdS7QJmpt4NIzcS62n3scNLUINHNGV9HjI1cs40Xvbq/ubCHb/Q5 08XZWo2Eux4TePysBh5X+NwszELCFcNDfAdM5JrcZ7zPezfFssAmi8Wzx1i9HeTgT9A7 MDmLnTkz9/1YU6StsEQN1XGwHGhxG8rcFx3h4lOdpUczG6IMS2CeXohnGgNMsZwtF6vy 541RDaQ3jCNVXVkRbTzmZicwdqNDOiYzsFJGdaHhJJfCEA35d0xdb1xFOpnoVdyakus5 IaKjwLhZigksHxd4YTpgCNZPjrymIw6qfWkGygyUyk/Jh8qRKFG/nY3Jbe0Uh6LVZw7Q 0gkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:references:in-reply-to:from :organization; bh=S15mpbYDlluEno+c7oN0xXeYKeqW7Dg5do28pMLcfqw=; b=lRU5BoBFJGI6e1gEJgZlCNKshpCnQLYyiWUv6HUG7kIOFKfaMK465n3JVJJZnEfy2h MffFCZQFNwYzsK+cuyk2YXwxo99EzGa24d135TT9EJbB4DKGh8HERTW+UxmFWUJQccnQ G65L0F9DzqINH1YhkgLnz3vjjjvREjHzsZH+D2ybFD/ThgBO+6/zEAPhQXyEvVs32DT3 FqZR2s+LzRDMdi1g5qZm3m2jGvFztYxN12/boPHyavLwpbrxudY1CiH2CTxC9WM0iXDp zSW5Cob6AiUdRQd9UJr24JPw6taO41mLFWqofdW4qtB34lfyYEMIt0w5aQ4aGfVcD+7n 7edA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l12-v6si5452125plc.332.2018.10.04.08.05.58; Thu, 04 Oct 2018 08:06:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727648AbeJDV6n convert rfc822-to-8bit (ORCPT + 99 others); Thu, 4 Oct 2018 17:58:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52274 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727375AbeJDV6n (ORCPT ); Thu, 4 Oct 2018 17:58:43 -0400 Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AC4D7308FB8A; Thu, 4 Oct 2018 15:05:02 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-149.rdu2.redhat.com [10.10.120.149]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0FBC93091322; Thu, 4 Oct 2018 15:05:00 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20180928180048.14259-1-amir73il@gmail.com> References: <20180928180048.14259-1-amir73il@gmail.com> To: Amir Goldstein Cc: dhowells@redhat.com, Miklos Szeredi , linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton , Jan Harkes , Mark Fasheh Subject: Re: [PATCH] fs: fix access beyond unterminated strings in prints MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32346.1538665500.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Thu, 04 Oct 2018 16:05:00 +0100 Message-ID: <32347.1538665500@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Thu, 04 Oct 2018 15:05:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Amir Goldstein wrote: > @@ -47,7 +47,7 @@ static struct dentry *coda_lookup(struct inode *dir, struct dentry *entry, unsig > int type = 0; > > if (length > CODA_MAXNAMLEN) { > - pr_err("name too long: lookup, %s (%*s)\n", > + pr_err("name too long: lookup, %s (%.*s)\n", Use %pd instead? David