Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1096368imm; Thu, 4 Oct 2018 08:08:33 -0700 (PDT) X-Google-Smtp-Source: ACcGV625GDviQMGhDo0o6EmGsO13KlOphix7r6Nw1t9Lt/R042q0EzPYRvOigsO3P8xzWkCVLBwb X-Received: by 2002:a63:bd41:: with SMTP id d1-v6mr6105205pgp.309.1538665713796; Thu, 04 Oct 2018 08:08:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538665713; cv=none; d=google.com; s=arc-20160816; b=kB0vYjRedau7HFbIMlEsacp61EODATOWLzx7GzNKCBhYcKGxCDmuec/aWSJfN40JjC 7+du3NUxFAQAcImKUBsEfwVgRJ+H564S6r1rT/BtRXbZivFOA2QepFRemle2GhBfboz+ fiCiDLJzfD71iczbmMqx9XlUUHtYWL+QM8ao7/viclmerdblxC55K/LVTk1BSVqxlMm+ v8f2kDCgr4zdrnzz7pyEBRkJoLZXNUvz5RFti2RkqjyRg9OumT8bj+TqZL+TIAKZs2W1 ZaGkIZhfFSwn1dB8zwLOLImzmQmk2lESkqvdqRPVkBWJAQAH+/uCqahKtr5l4tgy8Ec4 DtsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=m5H7/2FRtqEpi8aI51OWJIfepvVAF075eMUVuM7jZO0=; b=arhV3bVvyLFmRKQdA7l4Z4egUv+CcXN+UjmsHRJVCTCAvYU+x0GUGOZTvU5mkIx0G3 w3zGv0TXvF+RKuNDqm2jXmL/TIrqUTvC6RJ4wFdKwPtkT+wWlNP8mIreDT2/frZUOXeY GCHU6+TNc/hD/7teGinED9Y0Po85pWR4lxKcmW72XM5z30kzLf3DG27/6l60h5jNNG6s LY04eb68xQYTK9qMmRWgCSfuZby/cWe3oHYRPtQUw+2NkklFl8jpRQihmMBq1jvStMNV aOb5Yh1VG1HcctV5X02+2ZBq8TEUukBeOZi0xB4eS5fFjyZuDkoGHsI8TL5rj4QLhs+t 0E0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e193-v6si5381497pfc.131.2018.10.04.08.08.09; Thu, 04 Oct 2018 08:08:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727530AbeJDWBg (ORCPT + 99 others); Thu, 4 Oct 2018 18:01:36 -0400 Received: from muru.com ([72.249.23.125]:58240 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727354AbeJDWBg (ORCPT ); Thu, 4 Oct 2018 18:01:36 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 4C18A809C; Thu, 4 Oct 2018 15:12:23 +0000 (UTC) Date: Thu, 4 Oct 2018 08:07:51 -0700 From: Tony Lindgren To: Tero Kristo Cc: Andreas Kemnade , mturquette@baylibre.com, sboyd@kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, paul@pwsan.com, letux-kernel@openphoenux.org, Suman Anna Subject: Re: [PATCH RFC 0/2] mach-omap2: handle autoidle denial Message-ID: <20181004150751.GF5662@atomide.com> References: <20181004055147.23048-1-andreas@kemnade.info> <20181004142558.GB5662@atomide.com> <013b01a1-2593-bdc0-dd9a-e5a114388067@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <013b01a1-2593-bdc0-dd9a-e5a114388067@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tero Kristo [181004 14:47]: > On 04/10/18 17:25, Tony Lindgren wrote: > > It seems we should just provide a generic interface for > > clk_allow_autoidle() and clk_deny_autoidle()? Otherwise we'll > > be forever stuck with pdata callbacks it seems. > > The TI clock driver is actually providing these APIs, so that should be > fine. I don't think there is any use / need for pdata callbacks atm, it just > happens hwmod core is calling these at the moment which might have confused > you. Hmm OK. So do we already have some way to deny autoidle for a clock from ti-sysc.c driver without pdata callbacks? Suman pointed out few days ago that for a reset driver to work we must do clkdm_deny_idle() and clkdm_allow_idle() as the hwmod code does. I gues that really just boils down to doing clk deny idle and allow idle on the clockdomain clkctrl clock? Regards, Tony