Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1169612imm; Thu, 4 Oct 2018 09:12:05 -0700 (PDT) X-Google-Smtp-Source: ACcGV63Y9G7z8u75dvUpTDNMID88uMS0BiFxfwJO9z/E+FZFvNwGAXZOejNXSdAsCl/qAqsob2lH X-Received: by 2002:a62:ff09:: with SMTP id b9-v6mr7463187pfn.46.1538669525219; Thu, 04 Oct 2018 09:12:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538669525; cv=none; d=google.com; s=arc-20160816; b=N5OY8144j8qmaeX75WjqTmbhQXcoz/ZcVaWfUkfBaLHUXtoBf4c71Sa7U8olm/Omk1 9krj+Y43GB5wjcHO5sbmiuS4tMWdGFaE89rS8XbEd6r1iRa/jiqJ0SlJ/EQl922KpdGx GnJHC4+fYi8RT/19vktnTmuR1emf3sI6/5rioGP1PvW0l61PDZBhYkYqFbYilFRT6d+m lsmKdrKfR0LzyDbL5DrBVcm5zw029vqQYfGy/MctEqUFvZntxLG3ZZbAAeQx0Di41owr smjavEGdKDfkhc6/YJw6VBysvyAosklCV4hApFICObZctEJUaxcigE3jpWfMMZoa4u2B fBFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=MOrH2TO23lF9QWi/6DZboK9RQVMMFg7wOcky9y7hmL0=; b=LuikhM5D9MlF6K/FNTah5+Xw3H9d6ZYVJgkTRp6Sd1+KKXj1VWQBypyVwIUJiWWMAp KhOdqYNke3Alimjqa05bwkAl3Xa3KFAas3ryomJuzWjsrRVM+59RHYM1YE+XLRxnGw3d 7uonlKsXl5VhG8Yd0WOZvZ8UJpsMtKJclILC0F6jx8cKlxJc6Uz28B6RQhEbmRfbdB7e YO2u+ezjGNINejXixdMFgnCcKtfYl5q6jkm4PMo9VahL6ZL5QAds37qg5FhvCeMIPqNj zWCn9kXFQVLZre5JiFMl0nfB9lkzQq5C+PeyRaQBXMB6fborGq145C1gbT6lJCq/F5Kj 2V7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QL0GlCTk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i23-v6si5649751pfj.269.2018.10.04.09.11.48; Thu, 04 Oct 2018 09:12:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QL0GlCTk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727625AbeJDXFZ (ORCPT + 99 others); Thu, 4 Oct 2018 19:05:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:32968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727505AbeJDXFZ (ORCPT ); Thu, 4 Oct 2018 19:05:25 -0400 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AEE4D2147D for ; Thu, 4 Oct 2018 16:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1538669488; bh=McW8l0g6u/rmKJBjUdIIj6PR8dE10qVwcKAaEBFicnE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QL0GlCTkOPO4qASli0QzgW2694Z1n5Q5Q4HExotJ9AfDwuteN2B1xBBLp4PSsxWpX nmI3LN1ikUeaslRm7KiWa86J2J1Yhkz+K2CcuWhIiSa4mSrLF3zqepu572NWgBN+Ne w7PblTK3Dh6jXr3Cy9xsKpZiJlFkc0jwueIKkxpc= Received: by mail-wr1-f42.google.com with SMTP id a2-v6so3483348wrc.13 for ; Thu, 04 Oct 2018 09:11:27 -0700 (PDT) X-Gm-Message-State: ABuFfogz6g571VWrwzSgl2H/bk1ZSgLtnl6ieM1BXLarYBDbr1LR9JTR SOtpIGTon/JvFxlJnqP1HbGcOx4duFYkR9mlbus6jg== X-Received: by 2002:adf:e387:: with SMTP id e7-v6mr5478846wrm.94.1538669486047; Thu, 04 Oct 2018 09:11:26 -0700 (PDT) MIME-Version: 1.0 References: <20180921150553.21016-1-yu-cheng.yu@intel.com> <20180921150553.21016-4-yu-cheng.yu@intel.com> In-Reply-To: <20180921150553.21016-4-yu-cheng.yu@intel.com> From: Andy Lutomirski Date: Thu, 4 Oct 2018 09:11:14 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v4 3/9] x86/cet/ibt: Add IBT legacy code bitmap allocation function To: Yu-cheng Yu , Eugene Syromiatnikov Cc: X86 ML , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , LKML , linux-doc@vger.kernel.org, Linux-MM , linux-arch , Linux API , Arnd Bergmann , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Florian Weimer , "H. J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , "Shanbhogue, Vedvyas" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 21, 2018 at 8:10 AM Yu-cheng Yu wrote: > > Indirect branch tracking provides an optional legacy code bitmap > that indicates locations of non-IBT compatible code. When set, > each bit in the bitmap represents a page in the linear address is > legacy code. > > We allocate the bitmap only when the application requests it. > Most applications do not need the bitmap. > > Signed-off-by: Yu-cheng Yu > --- > arch/x86/kernel/cet.c | 45 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/x86/kernel/cet.c b/arch/x86/kernel/cet.c > index 6adfe795d692..a65d9745af08 100644 > --- a/arch/x86/kernel/cet.c > +++ b/arch/x86/kernel/cet.c > @@ -314,3 +314,48 @@ void cet_disable_ibt(void) > wrmsrl(MSR_IA32_U_CET, r); > current->thread.cet.ibt_enabled = 0; > } > + > +int cet_setup_ibt_bitmap(void) > +{ > + u64 r; > + unsigned long bitmap; > + unsigned long size; > + > + if (!cpu_feature_enabled(X86_FEATURE_IBT)) > + return -EOPNOTSUPP; > + > + if (!current->thread.cet.ibt_bitmap_addr) { > + /* > + * Calculate size and put in thread header. > + * may_expand_vm() needs this information. > + */ > + size = TASK_SIZE / PAGE_SIZE / BITS_PER_BYTE; > + current->thread.cet.ibt_bitmap_size = size; > + bitmap = do_mmap_locked(0, size, PROT_READ | PROT_WRITE, > + MAP_ANONYMOUS | MAP_PRIVATE, > + VM_DONTDUMP); > + > + if (bitmap >= TASK_SIZE) { > + current->thread.cet.ibt_bitmap_size = 0; > + return -ENOMEM; > + } > + > + current->thread.cet.ibt_bitmap_addr = bitmap; > + } > + > + /* > + * Lower bits of MSR_IA32_CET_LEG_IW_EN are for IBT > + * settings. Clear lower bits even bitmap is already > + * page-aligned. > + */ > + bitmap = current->thread.cet.ibt_bitmap_addr; > + bitmap &= PAGE_MASK; > + > + /* > + * Turn on IBT legacy bitmap. > + */ > + rdmsrl(MSR_IA32_U_CET, r); > + r |= (MSR_IA32_CET_LEG_IW_EN | bitmap); > + wrmsrl(MSR_IA32_U_CET, r); > + return 0; Why are you writing the MSRs in the case where the bitmap was already allocated?