Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Tayar, Tomer" <Tomer.Tayar@cavium.com>
To:     Nathan Chancellor <natechancellor@gmail.com>,
        "Elior, Ariel" <Ariel.Elior@cavium.com>,
        "David S. Miller" <davem@davemloft.net>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Dept-Eng Everest Linux L2 <Dept-EngEverestLinuxL2@cavium.com>
Subject: RE: [PATCH v2] qed: Avoid implicit enum conversion in
 qed_ooo_submit_tx_buffers
Thread-Topic: [PATCH v2] qed: Avoid implicit enum conversion in
 qed_ooo_submit_tx_buffers
Thread-Index: AQHUXAEKHUHyNNXBEE2AFGWeeEnGFKUPSzJg
Date:   Thu, 4 Oct 2018 16:46:31 +0000
Message-ID: <CY1PR07MB2554A3689F2690F70366CA7180EA0@CY1PR07MB2554.namprd07.prod.outlook.com>
References: <20181004000912.22242-1-natechancellor@gmail.com>
 <20181004163919.13972-1-natechancellor@gmail.com>
In-Reply-To: <20181004163919.13972-1-natechancellor@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9292ca05-da4e-41c3-1bc9-08d62a18f02c
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2018 16:46:31.5726
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2347
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Nathan Chancellor <natechancellor@gmail.com>
Sent: Thursday, October 04, 2018 7:39 PM

> Clang warns when one enumerated type is implicitly converted to another.
>=20
> drivers/net/ethernet/qlogic/qed/qed_ll2.c:799:32: warning: implicit
> conversion from enumeration type 'enum core_tx_dest' to different
> enumeration type 'enum qed_ll2_tx_dest' [-Wenum-conversion]
>                 tx_pkt.tx_dest =3D p_ll2_conn->tx_dest;
>                                ~ ~~~~~~~~~~~~^~~~~~~
> 1 warning generated.
>=20
> Fix this by using a switch statement to convert between the enumerated
> values since they are not 1 to 1, which matches how the rest of the
> driver handles this conversion.
>=20
> Link: https://github.com/ClangBuiltLinux/linux/issues/125
> Suggested-by: Tomer Tayar <Tomer.Tayar@cavium.com>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
>=20
> v1 -> v2:
>=20
> * Use an explicit switch statement to convert between the enumerated
>   types like the rest of the driver, as suggested by Tomer.

Thanks
Acked-by: Tomer Tayar <Tomer.Tayar@cavium.com>