Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Alexei Starovoitov <ast@kernel.org>
CC:     "David S . Miller" <davem@davemloft.net>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "luto@amacapital.net" <luto@amacapital.net>,
        "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 1/6] bpf: introduce BPF_PROG_TYPE_FILE_FILTER
Thread-Topic: [PATCH bpf-next 1/6] bpf: introduce BPF_PROG_TYPE_FILE_FILTER
Thread-Index: AQHUW44iIQrL1y3GVkS1yEfPFUvhJaUPfVsA
Date:   Thu, 4 Oct 2018 19:41:28 +0000
Message-ID: <20181004194123.GA12697@castle.DHCP.thefacebook.com>
References: <20181004025750.498303-1-ast@kernel.org>
 <20181004025750.498303-2-ast@kernel.org>
In-Reply-To: <20181004025750.498303-2-ast@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:200::5:e832]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;BY2PR15MB0519;20:pFvTot14ZDCA3HKeHLZwt1s5M4Owih6ruGgDue6FO07scIk4lERXehXrvyDDmPitQTufI0iGgHWV5hfGSgPmtWybXLfNZXpzwHyggr2Ctw8BEKWyJlnT2OR+zZtoGXrgw3OnnaDGyXlsjvuNLG+PEMPJVOZmZL+zuYgT5k9BJFk=
x-ms-office365-filtering-correlation-id: 335c62c2-f000-4089-5f77-08d62a316089
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020);SRVR:BY2PR15MB0519;
x-ms-traffictypediagnostic: BY2PR15MB0519:
x-microsoft-antispam-prvs: <BY2PR15MB0519BF95CAE6BB08437B3C9FBEEA0@BY2PR15MB0519.namprd15.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(192374486261705);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(823302090)(3002001)(93006095)(93001095)(10201501046)(3231355)(11241501184)(944501410)(52105095)(149066)(150057)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(201708071742011)(7699051);SRVR:BY2PR15MB0519;BCL:0;PCL:0;RULEID:;SRVR:BY2PR15MB0519;
x-forefront-prvs: 0815F8251E
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(396003)(376002)(39860400002)(346002)(136003)(189003)(199004)(102836004)(76176011)(33896004)(6246003)(25786009)(6512007)(6506007)(54906003)(52116002)(46003)(386003)(86362001)(316002)(4326008)(9686003)(229853002)(6436002)(2900100001)(71190400001)(53936002)(99286004)(71200400001)(478600001)(5250100002)(97736004)(486006)(68736007)(6116002)(11346002)(81166006)(6486002)(14454004)(105586002)(7736002)(14444005)(5024004)(186003)(5660300001)(106356001)(8936002)(476003)(256004)(33656002)(1076002)(81156014)(446003)(6916009)(8676002)(305945005)(2906002)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR15MB0519;H:BY2PR15MB0167.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-microsoft-antispam-message-info: wRoZB+0NPBUA5JLXM/PyoBHSt3ULtOyt+wJ4m+/hubbz56uOCHlG3Lje5wv5ZV1BV+rm6NpNzC4gE0M4k7hSHZeLnhiPlUqw5UgpbxwsxmVnqO14l2z0kgc33OYuTUn/G9kR9kKcWgIv5I0jkLl8q85NzIuJ6v6u2tybSp+i8c1tVHlZah923d/bblXNnNgeUe/w4NpXNccIVGH+bUcawDnolf8838x8dXypx/K3mCNQDrqOSJEHu1zfCe4mhUH/QUniQpDIaxdE7sr9hP6FV0Rj3NxuibbYD8DDM1u4PiwTGeSOUCdPg8YXRp9CVdc8lNKbL6Ft2GpvwGUF5ChIO0IUvs06YtvZXrUkGg4GKQ8=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1A6F8AA5A92E6241B856E5749AF84C9A@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 335c62c2-f000-4089-5f77-08d62a316089
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2018 19:41:28.7446
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR15MB0519
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-10-04_08:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 03, 2018 at 07:57:45PM -0700, Alexei Starovoitov wrote:
> Similar to networking sandboxing programs and cgroup-v2 based hooks
> (BPF_CGROUP_INET_[INGRESS|EGRESS,] BPF_CGROUP_INET[4|6]_[BIND|CONNECT], e=
tc)
> introduce basic per-container sandboxing for file access via
> new BPF_PROG_TYPE_FILE_FILTER program type that attaches after
> security_file_open() LSM hook and works as additional file_open filter.
> The new cgroup bpf hook is called BPF_CGROUP_FILE_OPEN.
>=20
> Just like other cgroup-bpf programs new BPF_PROG_TYPE_FILE_FILTER type
> is only available to root.
>=20
> This program type has access to single argument 'struct bpf_file_info'
> that contains standard sys_stat fields:
> struct bpf_file_info {
>         __u64 inode;
>         __u32 dev_major;
>         __u32 dev_minor;
>         __u32 fs_magic;
>         __u32 mnt_id;
>         __u32 nlink;
>         __u32 mode;     /* file mode S_ISDIR, S_ISLNK, 0755, etc */
>         __u32 flags;    /* open flags O_RDWR, O_CREAT, etc */
> };

It's probably nice to have file uid/gid as well.

Thanks!