Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1395294imm; Thu, 4 Oct 2018 12:56:30 -0700 (PDT) X-Google-Smtp-Source: ACcGV62TGLqncISc4D1LTOWRZPVVFg22VlZQhrslJrHvAJIb1jvp8QMIakZIz2UIUjb2WmFzaXuE X-Received: by 2002:a17:902:7d8b:: with SMTP id a11-v6mr8045860plm.171.1538682990205; Thu, 04 Oct 2018 12:56:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538682990; cv=none; d=google.com; s=arc-20160816; b=e6XkYxpDR9xo7BuOOuqBpinS2Eq0QkufVxNJgU5qbeEQ2O4IW/T4RICiKNQDd0gaHT 2M/mlL3MrlIYpUDDS8hiKMCnckmSQsV7tyo8ePF9/VqIHBHK8mW+nVuI8WeIbiHJuiDP GNDFqQw1xdxivC5TGAZ92knBUj9p1CHPR0oCsIT1rHxqLvUsDuuYj8pAXA6URCxTQmGW jtFJkCziL1p5ufhkfcDfv/FMB+DDvULO+Jlt5OZDiJ4TOkNvtotcQ4EzsCsGk23rlFJ4 Y2Ys62VbdLFeVPtVMv0pt/a6C2Yf1P+n8AaO21owe4OSSk7zv5qysZKVVzLxoh0N+d0A oFnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Cq+9WXWIVKvbNCa4MgKZ0/wi05P0u/6IrL8aLqRUHv0=; b=OGHNO3g3EIjILToTohNdI0/a7kwA3JKBBcVEuKp1SntCnFnSdXnVwkkBbx1Xf6jlQt 1Jhjfx0PK8UTkRBw2m0wfAVivyCoVKz9CMxCMxhcNHtDI3JWVSKM0d7LvSyORYGjdskm 7fGPWZxI3SRIVpas+Zzw9mX5wcCJdHI2HLOmSDFLTtQCxFJjFoHLg5ZyFU1Oe+4Se3nb hAAMghgk6ibUg/JhK1y/eo4DKsHflpUFhocHdLWM7ri+cR47s6BJYQ96C3svznQgBhPe 7xJLRHu54h5rtwQbCrLY2DiyRXqwqxxr+fr+PTKnhu9+pjw0wI2V1s/bwX7miUuoVsk2 UsYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i21-v6si5193975pgh.53.2018.10.04.12.56.13; Thu, 04 Oct 2018 12:56:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727545AbeJECuy (ORCPT + 99 others); Thu, 4 Oct 2018 22:50:54 -0400 Received: from mail.bootlin.com ([62.4.15.54]:51664 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727489AbeJECuy (ORCPT ); Thu, 4 Oct 2018 22:50:54 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 5BBB3207F3; Thu, 4 Oct 2018 21:56:05 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (LFbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.bootlin.com (Postfix) with ESMTPSA id 2B836206FF; Thu, 4 Oct 2018 21:56:05 +0200 (CEST) Date: Thu, 4 Oct 2018 21:56:05 +0200 From: Maxime Ripard To: Giulio Benetti Cc: David Airlie , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if null Message-ID: <20181004195605.txvbkshvxklyzxyb@flea> References: <9a545739-eed5-7af1-3b75-108bdd3427a2@micronovasrl.com> <20181003142458.33120-1-giulio.benetti@micronovasrl.com> <20181003142458.33120-2-giulio.benetti@micronovasrl.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p6k4kmrvnmdrrg4l" Content-Disposition: inline In-Reply-To: <20181003142458.33120-2-giulio.benetti@micronovasrl.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --p6k4kmrvnmdrrg4l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 03, 2018 at 04:24:58PM +0200, Giulio Benetti wrote: > If using tcon with VGA, We don't have support for VGA at the moment. Or are you talking about using a VGA bridge? > tcon->panel will be null(0), this will cause segmentation fault when > trying to dereference tcon->panel->connector. It's not a segmentation fault, but a null pointer dereference. And that case will also happen with bridges. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --p6k4kmrvnmdrrg4l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlu2cFQACgkQ0rTAlCFN r3TSxw/8Dziy1NiInMstE2LiZhh8Lwqi77TDLFHYbY0jmc86gPC3nQ+HHAldfF3d HYWS7ubeG8FkNnyg4327nGC2pR3iSmWXhNWQlqPx9rggDANSAT/Nv7fo0ZbValL4 iyacp43k4hrWhSpZuPsAvFq349Qh06HsGsQkU/3tS/uTa2hntW1170eA3s+re+BW I2R+DDzRkzkwgNjUTHFW/vG4iG6hlzZbmsi9FgIOg3jNKXNAniveLGOQNICfra62 DdHh3RxGhRjkuqFt8snOM/Y4MkC0BnadnEwyCRBVg9KAfQe0BQv7p3EyGr8n6QW6 ExOjK3HxsWCDYOcnrqR9AvbuYIZGzMOSUkUBKInar2yY3UFXmd/QGG6dT6hjJS7I 8qMExOjZkRN5/oHpMYb93gF3MfW3Z63nfaHCcRPitNnlvANBo36nZqvXHLiVxlZf dNJbw0p1v+mhPNPiIMmnBQiL17xwUqSC/R69U8XXY3FbPBAGGqu6VZORtv2isbKC AJA3mAZGJfIiNr8YJytHU4GTazN/9cUQhLBz+XE8d3W63B8oZSbmPwUc26NK5W7h eCezPgMWjxUYX/orSkiocW9NXRUcIDhBSOnq8wlzb6cIAMX00Nz4bFo/2+BHAgn4 Ujpmxecr5cS/Gyc7f+e3zXJ/GkzXrFgRrTudPq0xS6VqZfoO/tk= =JJRK -----END PGP SIGNATURE----- --p6k4kmrvnmdrrg4l--