Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1428112imm; Thu, 4 Oct 2018 13:30:26 -0700 (PDT) X-Google-Smtp-Source: ACcGV62bBi2dXBgP27FeMDf79KYOsrig8x3yvpwFEIvShihGbvpCZuvHxGQuiN7wX8Zgx9iSe87z X-Received: by 2002:a63:954a:: with SMTP id t10-v6mr7079386pgn.432.1538685026091; Thu, 04 Oct 2018 13:30:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538685026; cv=none; d=google.com; s=arc-20160816; b=cQDhMT8nFUcnT6rpY/u7a9JYDBpUNFsXdyx3hrB+t0ZEzjV0spkiHuiqQFkES0ccE8 AQxU2qsh3z1C/mc259mkK5xWmCTOVL8gEqFhYf2rj2WvqmDPXymu53dQxTbgqaIMnu4P N6U68Ah/pmB1inyBefdscszZap5+RfbhqHOMi3Hwey9vua5/aW6TC+XE5GkCcGLr8iPc 7FtwlupxisNEyRj9twbrq4rHf7MLS0iCNij3LMAYW5K5N2I5modbDx3w9xtW9X1Ynmh1 aQhzuz2/nuen6/YQXjE/aYI2rQeWhLEczWmfSK1bF6Nl44fLM5An1fPxCbSUrp/iyXyC qHiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=YiK7lyO7b2aJXcB42eMi3FeR2xojGMX2RNKuvQuI354=; b=HSPPTkHJihvFGIo18lJma1dI9EyS8y3p6h8e+LqLMlTNqTK5L0VcFAocjfXV8kntRz +PQjVhxCf4sDUrvwZlzo9nzi3//Q6tCSzcTFN+wOq2BmPcWbrhSRkbgm98PFiiGSwM+V XWBM55DLj8bW64EHBRI/yXiINihBBthkISzpWhpYePwLGpcOhcZ4U94pOiItsZ4tsF43 tEvrEwfK5hLZmnDXPs59COP7PgwHpqlum9EUFQDP5VYzOd4xzjcyKyoxj9AkPyvuGgDZ 1d/ZldEDaoPx4JW89hPjJFdk/Jv+/zS92F+MNg3O7yfjgHN/xyRI8MyybcM5ZOaf2/yc vFFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=uaq2eOkF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f94-v6si7336544plb.10.2018.10.04.13.30.11; Thu, 04 Oct 2018 13:30:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=uaq2eOkF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727732AbeJEDYp (ORCPT + 99 others); Thu, 4 Oct 2018 23:24:45 -0400 Received: from mail-yb1-f178.google.com ([209.85.219.178]:41182 "EHLO mail-yb1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727354AbeJEDYp (ORCPT ); Thu, 4 Oct 2018 23:24:45 -0400 Received: by mail-yb1-f178.google.com with SMTP id e16-v6so4466436ybk.8; Thu, 04 Oct 2018 13:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YiK7lyO7b2aJXcB42eMi3FeR2xojGMX2RNKuvQuI354=; b=uaq2eOkFmUbNpetu1c60s5D+IqUxSSfO9pQxGrIUu7FY/ndIBVnRJNO8AUPjYhbWNh z+NtbTHPpUZdFauZoJ2a472aQ+407/2g+OFqcTQ3EcYu9uSJ2ewtoTWJzr+z1CbiBUq7 EnO32/7sM2CdYIK3FnxrWlIxtQ5ytpPFFDs6Abt9ctobGJmPrsMIhu5hnXHMOZYu/xC4 t9M/iyeTYH/Ok7uO7TsxkyVT9AQh5dSa8FaZFGMInPm062lOBTSlUeOfuQvlDTgORX+z 7HPMr3x6kQGTnU78bnG2+2yeWAne7kNQVWFH2Q8eXw/wL38KeqmBOewcUpu5CUdOlUBq J8dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=YiK7lyO7b2aJXcB42eMi3FeR2xojGMX2RNKuvQuI354=; b=qAxmyjYrptwTzxvx8WA++jKdQhERMAWmer3XY10XKlliV/cWWwevjN2TTViIXAp8SC dSSPlkQTxPru2ruSRwkcz8RiLMifSHtB8a5X64ONr/hNH6ogDpejVaAoVIlyohB/+Gpp HJX17SiKUVS9kXbVJsaP3s8UMcBO4KtBa4El6nEFUpmHbqxHYsi3YqUTmGHB/O+uAZ5P YhAFWPJ+l92a5qUUdHuWs4vyO0/321kqg8O5laSsIiWgJcqKN3lo7GfeyNIPnQUw4fnL 20+4SpIRLftJkkAUwOyqZN1WvhBWd3rtF8ipnKZpbtpCaxq2PKg3CyCje0AxuDmEcr5P 9n6Q== X-Gm-Message-State: ABuFfojwLtMfX11/IYWyoCTZ4ZMuYSuSR69i3wg1q+dGZXhJeXbkBfcR GI3YcUpvcGIEG6tAmHNDM/s= X-Received: by 2002:a25:74ce:: with SMTP id p197-v6mr4675444ybc.343.1538684990609; Thu, 04 Oct 2018 13:29:50 -0700 (PDT) Received: from localhost ([2620:10d:c091:200::7:7472]) by smtp.gmail.com with ESMTPSA id u79-v6sm551541ywe.110.2018.10.04.13.29.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Oct 2018 13:29:49 -0700 (PDT) Date: Thu, 4 Oct 2018 13:29:47 -0700 From: Tejun Heo To: "Michael Kerrisk (man-pages)" Cc: lkml , "open list:CONTROL GROUP (CGROUP)" , "Serge E. Hallyn" , Amin Jamali , Joao De Almeida Pereira Subject: Re: Cgroup v2 bug: "domain invalid" node can't be converted to "threaded" Message-ID: <20181004202947.GL270328@devbig004.ftw2.facebook.com> References: <20181002210741.GJ270328@devbig004.ftw2.facebook.com> <0cf4f9de-70d2-cf94-12d2-283759638e20@gmail.com> <20181004182017.GK270328@devbig004.ftw2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181004182017.GK270328@devbig004.ftw2.facebook.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 04, 2018 at 11:20:17AM -0700, Tejun Heo wrote: > Subject: cgroup: Fix dom_cgrp propagation when enabling threaded mode > > A cgroup which is already a threaded domain may be converted into a > threaded cgroup if the prerequisite conditions are met. When this > happens, all threaded descendant should also have their ->dom_cgrp > updated to the new threaded domain cgroup. Unfortunately, this > propagation was missing leading to the following failure. Applied to cgroup/for-4.19-fixes w/ reported-bys added. Thanks. -- tejun