Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1440168imm; Thu, 4 Oct 2018 13:44:22 -0700 (PDT) X-Google-Smtp-Source: ACcGV633WRHsHLWFp+miU1/jDVGMJ8mu4NuyaucvdHrbBpFrhFg6QSpzpH1ZV61KWrK5+LVVuDSZ X-Received: by 2002:a63:dc14:: with SMTP id s20-v6mr7292487pgg.398.1538685862626; Thu, 04 Oct 2018 13:44:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538685862; cv=none; d=google.com; s=arc-20160816; b=Z6ZUNNtA6XzTrh9oF7MwMdKm1cH71E0mMQoKmScoceqsOWj8lEB9CdlnZ1AihxWA+Y xNU+oXGtErRWNernAhZytVeEzCyg7RR2xFFs/OhaxuHxhuq6kFfeYudFZfOmsBQ2jEK0 9CbmfOoIZTI1FRD/CPhFVLMKGn6tdH5P/Sa9zEVzBLxS+ozwGLMvokNv2aIjiDJ1xErq q5LPtH/7ADdI8907j5GJKuA9ZZm8JWS3mZnrs6ogaJjJ0jJPtJjdHPuSo7TIDuynHvsS S/SIz77ffjcq6QLJGvDSA8WjvPskjCU+dBWa+0833OHZglmPZe/ifW3m7IitfBnZc6Gl q+Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=DbXIsGJpanZRqLFoFxZudmTIufsPDI56xmIo9LC980o=; b=F+/sYzwzlITIPNThv4OpVSkruEZ4jr0AYx8sM81qtk2x7D/yKpWdF4wYDcyC3DIssb lKKHOCa9FgU8QkjL6oaecSih8PUBOlJ98e2ydnryV50VynFTKTwsE0WAfhP8MoEEcfLo ifpl0nbaqHxlTprDlKpZvDnr4VVEGNpF+Dl4yGv90QwQ4IgSbq7rwd7XAF2/J9EmttY9 YdFEGgqxjN3r09AR1z/nmiMci4wvpu2MYX7HAD7H5wPqjUhR2pzllDM2Lf2kLrqlvBqc 0cwtmjUBXCdmSo2VKNmdad4nWTy8McbUquQ8szsMZ5w3pRfhI+bgYIq6m7R4szn627lg ApgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 6-v6si5309791pgt.320.2018.10.04.13.44.06; Thu, 04 Oct 2018 13:44:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728118AbeJEDil (ORCPT + 99 others); Thu, 4 Oct 2018 23:38:41 -0400 Received: from mga02.intel.com ([134.134.136.20]:49781 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727709AbeJEDil (ORCPT ); Thu, 4 Oct 2018 23:38:41 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2018 13:43:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,341,1534834800"; d="scan'208";a="92295010" Received: from maru.jf.intel.com ([10.54.51.77]) by fmsmga002.fm.intel.com with ESMTP; 04 Oct 2018 13:43:27 -0700 From: Jae Hyun Yoo To: Brendan Higgins , Wolfram Sang , Benjamin Herrenschmidt , Joel Stanley , Rob Herring , Mark Rutland , Andrew Jeffery , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: Jarkko Nikula , James Feist , Vernon Mauery , Jae Hyun Yoo Subject: [PATCH i2c-next v6 2/5] i2c: Add support reading of 'timeout-ms' and '#retries' properties Date: Thu, 4 Oct 2018 13:43:19 -0700 Message-Id: <20181004204322.20665-3-jae.hyun.yoo@linux.intel.com> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181004204322.20665-1-jae.hyun.yoo@linux.intel.com> References: <20181004204322.20665-1-jae.hyun.yoo@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This commit adds support for 'timeout-ms' and '#retries' properties to set 'timeout' and 'retries' values in 'struct i2c_adapter' in case an adapter node has the properties. Still the values can be set by I2C_TIMEOUT and I2C_RETRIES ioctls on cdev at runtime too. These properties may not be supported by all drivers. However, if a driver wants to support one of them, it should adapt the bindings in the dt-bindings document. Signed-off-by: Jae Hyun Yoo --- drivers/i2c/i2c-core-base.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 9ee9a15e7134..433867e9af2f 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -1214,6 +1214,7 @@ EXPORT_SYMBOL_GPL(i2c_handle_smbus_host_notify); static int i2c_register_adapter(struct i2c_adapter *adap) { int res = -EINVAL; + u32 timeout_ms = 0; /* Can't register until after driver model init */ if (WARN_ON(!is_registered)) { @@ -1239,8 +1240,13 @@ static int i2c_register_adapter(struct i2c_adapter *adap) INIT_LIST_HEAD(&adap->userspace_clients); /* Set default timeout to 1 second if not already set */ - if (adap->timeout == 0) - adap->timeout = HZ; + if (adap->timeout == 0) { + device_property_read_u32(&adap->dev, "timeout-ms", &timeout_ms); + adap->timeout = timeout_ms ? msecs_to_jiffies(timeout_ms) : HZ; + } + + /* Set retries value if it has the property setting */ + device_property_read_u32(&adap->dev, "#retries", &adap->retries); /* register soft irqs for Host Notify */ res = i2c_setup_host_notify_irq_domain(adap); -- 2.19.0