Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1538579279-11614-1-git-send-email-laoar.shao@gmail.com> <9863d8b1-7249-e5ec-0400-4007798e69e2@gmail.com>
In-Reply-To: <9863d8b1-7249-e5ec-0400-4007798e69e2@gmail.com>
From:   Yafang Shao <laoar.shao@gmail.com>
Date:   Fri, 5 Oct 2018 09:54:20 +0800
Message-ID: <CALOAHbDRaH0rVb5cmvKendtrkEEwpfn5cnc5q1yZ49Oj0wTi2w@mail.gmail.com>
Subject: Re: [PATCH net-next] inet: do not set backlog if listen fails
To:     Eric Dumazet <eric.dumazet@gmail.com>
Cc:     Eric Dumazet <edumazet@google.com>,
        David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Oct 3, 2018 at 11:41 PM Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>
>
> On 10/03/2018 08:07 AM, Yafang Shao wrote:
> > These two backlog members are not necessary set in inet_csk_listen_start().
> > Regarding sk_max_ack_backlog, it will be set in the caller inet_listen
> > and dccp_listen_start.
> > Regraing sk_ack_backlog, it is better to put it together with
> > sk_max_ack_backlog in the same function and only set on success.
> >
> > Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> > ---
> >  net/dccp/proto.c                | 1 +
> >  net/ipv4/af_inet.c              | 1 +
> >  net/ipv4/inet_connection_sock.c | 3 ---
> >  3 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/net/dccp/proto.c b/net/dccp/proto.c
> > index 875858c..34d48cd 100644
> > --- a/net/dccp/proto.c
> > +++ b/net/dccp/proto.c
> > @@ -959,6 +959,7 @@ int inet_dccp_listen(struct socket *sock, int backlog)
> >               err = dccp_listen_start(sk, backlog);
> >               if (err)
> >                       goto out;
> > +             sk->sk_ack_backlog = 0;
>
>
> This is racy, remember that dccp and tcp have lockless listeners.
>
> Do not change sk_ack_backlog after a TCP/DCCP socket is ready to accept new flows.

Understood. Thanks for your explanation.