Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp184940imm; Thu, 4 Oct 2018 21:10:30 -0700 (PDT) X-Google-Smtp-Source: ACcGV613hi2shQRj2NGBn/LHsOgcKExGsKtLmL6GRLlGAm/iWOcLn5YkdQR9K5YxziRXrAJGUuzM X-Received: by 2002:a17:902:8a4:: with SMTP id 33-v6mr9689103pll.65.1538712630849; Thu, 04 Oct 2018 21:10:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538712630; cv=none; d=google.com; s=arc-20160816; b=eTsu7C+Q/0gACRQRddm6wGz7Q2GWWfKZ+OEr9Dh3wVifLK6UJxN+MEyBIZ2YbrKORz 6JjieMQDA85Y3HlkhkGE1+Ass3N+C6ZfOEAiuHJkt9fL4DLtSXrHR5ccUI/9AltDPdUA Mf6cbxnFqJczDZjNBnKypuGDELOMqr+H0OUMB0vqT+yCuAkTi8UcQ3zsnDT0MA3oRHTh R1vKvlTbTwznkciteRHLdJ2/lKozoPFnfVOSzfaw7araVrcYTPgy5mZoXvFw0PB8hcXQ YXdcyVeMXGQu7egSVpRwd8vzzwdeLJBaes1FJd9xbkywKgS3IwGBtIH2994UqDNTRPmU ydIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:message-id :in-reply-to:subject:cc:to:from:date; bh=SEg6Mh89mLwRii0r42/UQp51AauuJen9/pHOdeuzlyA=; b=F00vZ8zJQYDS28PfaGi0UEAXwAxVtvn7zozY7olGQj6bGDuqmDtv4nJ4T3gOm40YKD FxlsuG+8iz8J73aJ4lY0TFy5eetpmG/35s8F6tfOuKJuo6dhQE52Ejr+GkZo4JWOzKS1 vFOIlCJQF1BKGqsUVxiVEQa2gnOArgC7fB/GS7/n94hmHlPZjPsOQSuJgGF5YCkgtI9J 2ZeYRsJnXAcJcKSKwlCVCTxoBIffX0kj4MQseftVncTT4194sVIn28zmIUzSCWy/687s j1lXa57FSMgjYrYl+dNfOFoWMz/PrsZWg7EEj+bxi+Xeu6ZmTc3F6QZCyejT0RYU8esU LPkg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c2-v6si7354841plb.384.2018.10.04.21.10.15; Thu, 04 Oct 2018 21:10:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727536AbeJELG6 (ORCPT + 99 others); Fri, 5 Oct 2018 07:06:58 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:49956 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726826AbeJELG6 (ORCPT ); Fri, 5 Oct 2018 07:06:58 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id EE768231E6; Fri, 5 Oct 2018 00:10:05 -0400 (EDT) Date: Fri, 5 Oct 2018 14:10:04 +1000 (AEST) From: Finn Thain To: Leonardo Bras cc: James Bottomley , lkcamp@lists.libreplanetbr.org, Alexander Shishkin , Robert Richter , "James E.J. Bottomley" , Helge Deller , Martin Schwidefsky , Heiko Carstens , Geert Uytterhoeven , linux-kernel , linux-m68k@lists.linux-m68k.org, oprofile-list@lists.sf.net, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v3 3/7] drivers: parisc: Avoids building driver if CONFIG_PARISC is disabled In-Reply-To: Message-ID: References: <20180928020816.11251-1-leobras.c@gmail.com> <20180928020816.11251-4-leobras.c@gmail.com> <1538118915.3593.4.camel@HansenPartnership.com> <1538628062.18776.5.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Oct 2018, Leonardo Bras wrote: > ... > But, why these chosen Makefiles, and not all of them? I think that inconsistency is untenable. If nothing else, it means your changes will get broken by other people who also apply constraints inconsistently. I think you need to consider what happens when you apply this regime tree-wide. Either that or explain why it would make sense to build e.g. drivers/s390 but not drivers/s390/net. --