Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp189498imm; Thu, 4 Oct 2018 21:16:43 -0700 (PDT) X-Google-Smtp-Source: ACcGV63fjcmoxw8M+pYk4GA+Ab8fmJpMDAAHjX+uxhehenyx5DAh6TRXRHz74AiM22l0gWdEZkER X-Received: by 2002:a63:4563:: with SMTP id u35-v6mr8548183pgk.30.1538713003009; Thu, 04 Oct 2018 21:16:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538713002; cv=none; d=google.com; s=arc-20160816; b=LTAWPWf6x6+2JcBtw7ZKluQyyeHobVmJXthbjdmOy54/g906LT5A4TSw+m0RP3spwV QSeoRPwaUAzIrILng7388iVQfIolOTXun1peDpskmTUzyg080BPcvBAPGQwUKOCYUYZb eb3EDDJgzdyWmSsiJWuhONWFuwTMOsD9I8sZMXtRVbgtiuFUgjsNk9zirfkFjDAafO/+ 8OHZCWemNM9zgDzy5u0m2J00QCmZv08cp1Ui8lFAF1X0e8v562R5BSCVvTqaHxCddgZs +P4ImUU/Scw/tzgk7nj3Fm0+zyMaH5DmAVhvoWge20k6Zpe0tBf6tojZpkhZwkvothSm 7dYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=lPoDioj489a2/oR5DkZXnv7vgj2sX9AQIbb7kmBjERc=; b=fwJKp/Z1kpBbQGUw9PbBOx7jdymGoMDBGQ5Y3WF0+EL6zabFbmYkp8CeFXK2Frqjmq AOmCL7o2hQG+n0q4SZnrKJ4qBX4FZ2/XeAH2iXDz+/2rdKIE3a4+oRlLxs/f4V8masvW 8dNdT2LDObkiyE1b3grQM1Wba2URnuDwn0LmVKhGXwHWcJBivvZtuQnpDMlwxmLu58hO sc2uQ3xaSc9Vm7BgEeXwg+mUw3C4N4lPYG0wk97c13ARafNB5i6dUsnDVPsSB8mPM53v hYVw3Ft++gRBRJMBwW42njTdn6sBy2OqLAzYi+iSjRezcuvI8MlwvMlwooXE1151Rln1 HhRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BesHESeR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q22-v6si7371448pgc.393.2018.10.04.21.16.27; Thu, 04 Oct 2018 21:16:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BesHESeR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727640AbeJELLG (ORCPT + 99 others); Fri, 5 Oct 2018 07:11:06 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:33156 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727036AbeJELLE (ORCPT ); Fri, 5 Oct 2018 07:11:04 -0400 Received: by mail-pg1-f195.google.com with SMTP id y18-v6so4148781pge.0; Thu, 04 Oct 2018 21:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lPoDioj489a2/oR5DkZXnv7vgj2sX9AQIbb7kmBjERc=; b=BesHESeR2OkWfLm2eP+lH9kJfeYT3yZJjIVYrS+7g+Y1yN14yPrKCEPwZuZVpu4UQT Y2TU6UhnalnRt9tsYWlBrDmO7/zufQzIIc4VPr41i1xeX9HfD8c3+mVfxRT/G6+li04t /VkqmDVHI+DYo51NjkC5ExsmwFbd5XVwa27b6LqfQEu9/KExiY1IpqiqFMFx8+RfmTHo IEKBL1CBSPHehuYJUH6PLCdfyxxWkNBrLbbsHXf8v+nSn7i/AWHvTsCcNoXrzP1qK1yP UsUpzZgLCXLzzbtUldlNs1VmnTGGXTdqs7b0PtROqUoZhqTzJKRb1BI/kG+UEgUxPD7E 9zww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lPoDioj489a2/oR5DkZXnv7vgj2sX9AQIbb7kmBjERc=; b=Gly3HDGIbKXoowaqwkLEcFhvaV5HDCLxTlZTnYCP2gn8kroHQWNnMzaXzioEbaAqaL b7e9eFoz37KBdMC6Kc5IdA0uBXbdV5FHRYH8L99JnrUV3A+za0UveN2S7y2vfbqaKZAF I2cyl2rh6UAWBT7XJWtv8RsEI8qOodDAi/W/Xc7EscObZUH8L8NRirhpQ/hRtfb2O5ho 3GOBrAwNrmi9QvCn5caQhDcDXwFCHjDW9kr982K0B86PWQ2S9HyqGyyoAY+6ITwKqN2G C436PCoGJ7QgQjd14CnWV4KtnU/NtVHh38hDLWA14yUVvWTe+hwHD4T3VBaeOb3rbIoK LJgA== X-Gm-Message-State: ABuFfojasb5Att8WJkuLgfXtacMJKL0fnsivBkmDr7qFJ7rRTV79pxqy Bgq8Z6R2HNctR4vdgCVmDqth9lNT X-Received: by 2002:a63:64c2:: with SMTP id y185-v6mr8320372pgb.411.1538712853292; Thu, 04 Oct 2018 21:14:13 -0700 (PDT) Received: from localhost.localdomain (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id n63-v6sm277975pfn.9.2018.10.04.21.14.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 04 Oct 2018 21:14:12 -0700 (PDT) From: frowand.list@gmail.com To: Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-fpga@vger.kernel.org Subject: [PATCH 01/16] of: overlay: add tests to validate kfrees from overlay removal Date: Thu, 4 Oct 2018 21:12:32 -0700 Message-Id: <1538712767-30394-2-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1538712767-30394-1-git-send-email-frowand.list@gmail.com> References: <1538712767-30394-1-git-send-email-frowand.list@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand Add checks: - attempted kfree due to refcount reaching zero before overlay is removed - properties linked to an overlay node when the node is removed - node refcount > one during node removal in a changeset destroy, if the node was created by the changeset After applying this patch, several validation warnings will be reported from the devicetree unittest during boot due to pre-existing devicetree bugs. The warnings will be similar to: OF: ERROR: of_node_release() overlay node /testcase-data/overlay-node/test-bus/test-unittest11/test-unittest111 contains unexpected properties OF: ERROR: memory leak - destroy cset entry: attach overlay node /testcase-data-2/substation@100/hvac-medium-2 with refcount 2 Signed-off-by: Frank Rowand --- drivers/of/dynamic.c | 29 +++++++++++++++++++++++++++++ drivers/of/overlay.c | 1 + include/linux/of.h | 15 ++++++++++----- 3 files changed, 40 insertions(+), 5 deletions(-) diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c index f4f8ed9b5454..b04ee021a891 100644 --- a/drivers/of/dynamic.c +++ b/drivers/of/dynamic.c @@ -330,6 +330,25 @@ void of_node_release(struct kobject *kobj) if (!of_node_check_flag(node, OF_DYNAMIC)) return; + if (of_node_check_flag(node, OF_OVERLAY)) { + + if (!of_node_check_flag(node, OF_OVERLAY_FREE_CSET)) { + /* premature refcount of zero, do not free memory */ + pr_err("ERROR: memory leak %s() overlay node %pOF before free overlay changeset\n", + __func__, node); + return; + } + + /* + * If node->properties non-empty then properties were added + * to this node either by different overlay that has not + * yet been removed, or by a non-overlay mechanism. + */ + if (node->properties) + pr_err("ERROR: %s() overlay node %pOF contains unexpected properties\n", + __func__, node); + } + property_list_free(node->properties); property_list_free(node->deadprops); @@ -434,6 +453,16 @@ struct device_node *__of_node_dup(const struct device_node *np, static void __of_changeset_entry_destroy(struct of_changeset_entry *ce) { + if (ce->action == OF_RECONFIG_ATTACH_NODE && + of_node_check_flag(ce->np, OF_OVERLAY)) { + if (kref_read(&ce->np->kobj.kref) > 1) { + pr_err("ERROR: memory leak - destroy cset entry: attach overlay node %pOF with refcount %d\n", + ce->np, kref_read(&ce->np->kobj.kref)); + } else { + of_node_set_flag(ce->np, OF_OVERLAY_FREE_CSET); + } + } + of_node_put(ce->np); list_del(&ce->node); kfree(ce); diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index eda57ef12fd0..1176cb4b6e4e 100644 --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -373,6 +373,7 @@ static int add_changeset_node(struct overlay_changeset *ovcs, return -ENOMEM; tchild->parent = target_node; + of_node_set_flag(tchild, OF_OVERLAY); ret = of_changeset_attach_node(&ovcs->cset, tchild); if (ret) diff --git a/include/linux/of.h b/include/linux/of.h index 4d25e4f952d9..aa1dafaec6ae 100644 --- a/include/linux/of.h +++ b/include/linux/of.h @@ -138,11 +138,16 @@ static inline void of_node_put(struct device_node *node) { } extern struct device_node *of_stdout; extern raw_spinlock_t devtree_lock; -/* flag descriptions (need to be visible even when !CONFIG_OF) */ -#define OF_DYNAMIC 1 /* node and properties were allocated via kmalloc */ -#define OF_DETACHED 2 /* node has been detached from the device tree */ -#define OF_POPULATED 3 /* device already created for the node */ -#define OF_POPULATED_BUS 4 /* of_platform_populate recursed to children of this node */ +/* + * struct device_node flag descriptions + * (need to be visible even when !CONFIG_OF) + */ +#define OF_DYNAMIC 1 /* (and properties) allocated via kmalloc */ +#define OF_DETACHED 2 /* detached from the device tree */ +#define OF_POPULATED 3 /* device already created */ +#define OF_POPULATED_BUS 4 /* platform bus created for children */ +#define OF_OVERLAY 5 /* allocated for an overlay */ +#define OF_OVERLAY_FREE_CSET 6 /* in overlay cset being freed */ #define OF_BAD_ADDR ((u64)-1) -- Frank Rowand