Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp152122imm; Fri, 5 Oct 2018 01:14:03 -0700 (PDT) X-Google-Smtp-Source: ACcGV63zyTQkUUMziKWdvGBrGpErvWuBSQipdfxs0EctZMGB31OBBZq0tTem6iqZ7Whuj7OFvbUQ X-Received: by 2002:a63:904a:: with SMTP id a71-v6mr9394376pge.264.1538727243596; Fri, 05 Oct 2018 01:14:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538727243; cv=none; d=google.com; s=arc-20160816; b=ykOv+7hdLbv9v6i4hoAvOyDGx37ZmMJcx6PTSD4LM4Mi3piX0BRERvvTMC8vN2QNIA 11KfjDmHJMs1l2lllP38rZmQqyR4LHvmH08REWoUSwoKA/lG0PhU8hTjEHg4SZgq+YdO /a39zlDnL2ewFZh9XEq/WcHBnJGpOwcufvQ4C9Z2GkXbhi9xUowoc6IYjVAs27HSkY8M mRQSWERcSf/IbBml7rvY9b1B9X72jGRe4x3VTEK68EYXdrNL27fhSY1DlGrsHo2iMf5O e5HBRfTHRge/2StI7LzasoHUWRGmfDOb+UVLGD+IWrfd4Z94FfE1aloDOr6pdNfkMUfy p8Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=RToyMrnWkRwElXX9qkJ+jSF6Atfxn8Cgp5GN2LSGcsw=; b=aOOhsO6VLRYDlVmuy32Jrflg6a1AgZxIGjL2stemknoLS4WNNbjKDyzPjKRAwJ0uE7 R+viHn63pgsMANy3OOZLup1DKn4DbukO2DkbtwolyBAb1W2BcoPGJJUAPSQ9azPm0Tt8 01KDQexue4chdzMY3YfKnfRO+36LLgUJAS2MWEGCq5f612emmbsiiYND5FTyCBoo37++ 6LOJ/ULBXn/YArOIQygjPNsuychqgus5MZqPpq4v+3i3nwnQMHpOJaNe+anFJmXVH0Ff wauRfKV8WCb0zHf/9npRnRFQDWxF6s8+t2R7Ka6p/T0H0pdE39POtIMhp8OcUAwvFOyT KPwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q85-v6si7821889pfi.183.2018.10.05.01.13.46; Fri, 05 Oct 2018 01:14:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728122AbeJEPK4 (ORCPT + 99 others); Fri, 5 Oct 2018 11:10:56 -0400 Received: from mga05.intel.com ([192.55.52.43]:50176 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727073AbeJEPK4 (ORCPT ); Fri, 5 Oct 2018 11:10:56 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2018 01:13:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,343,1534834800"; d="scan'208";a="97637246" Received: from kromanow-mobl5.ger.corp.intel.com (HELO [10.252.4.128]) ([10.252.4.128]) by orsmga002.jf.intel.com with ESMTP; 05 Oct 2018 01:13:17 -0700 Subject: Re: [PATCH] drm/gvt : fix error message typo To: Peng Hao , zhenyuw@linux.intel.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, airlied@linux.ie Cc: intel-gvt-dev@lists.freedesktop.org, linux-kernel@vger.kernel.org, Peng Hao References: <1538669074-26012-1-git-send-email-penghao122@sina.com.cn> From: Zhi Wang Message-ID: <659e1b3d-8b17-e380-4196-340596ec9740@intel.com> Date: Fri, 5 Oct 2018 04:13:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1538669074-26012-1-git-send-email-penghao122@sina.com.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi: Thanks for the patches. :) Several places needs to be improved: 1. The prefix of the patch should be: "drm/i915/gvt:". 2. You can just cc the maintainers of gvt since the gvt is a sub-module of i915. 3. Better refine the tittle of the patch and also the commit message. An informative title and commit message would be more friendly to people who reading this later, even it's only a small typo. :) Again. Thanks for the patch. :) I will fix that for you and commit it, so you don't need to send it again. Thanks, Zhi. On 10/04/18 12:04, Peng Hao wrote: > > From: Peng Hao > > gvt_err message typo. > > Signed-off-by: Peng Hao > --- > drivers/gpu/drm/i915/gvt/gvt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gvt/gvt.c b/drivers/gpu/drm/i915/gvt/gvt.c > index 46c8b72..31d6809 100644 > --- a/drivers/gpu/drm/i915/gvt/gvt.c > +++ b/drivers/gpu/drm/i915/gvt/gvt.c > @@ -438,7 +438,7 @@ int intel_gvt_init_device(struct drm_i915_private *dev_priv) > > ret = intel_gvt_debugfs_init(gvt); > if (ret) > - gvt_err("debugfs registeration failed, go on.\n"); > + gvt_err("debugfs registration failed, go on.\n"); > > gvt_dbg_core("gvt device initialization is done\n"); > dev_priv->gvt = gvt; >