Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp521722imm; Fri, 5 Oct 2018 07:36:27 -0700 (PDT) X-Google-Smtp-Source: ACcGV63aiWrIqDVtEEHTGrsMKH3JT2fYjoeEigwXlG+SKCmlKpuWGq+jcuoa4NRHKL38IMXUyDty X-Received: by 2002:a17:902:6f16:: with SMTP id w22-v6mr11833855plk.261.1538750187407; Fri, 05 Oct 2018 07:36:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538750187; cv=none; d=google.com; s=arc-20160816; b=yblYhdh/ck0Zs3tMmd0tz9FKbJzwQx+0orL1FWM31a6gT/S2/g1FmS+cyIhLj6OGbH Dx9MpBf/gQrQP82+FTS7F9lRCxcNcFD//05+9IH021K9zX96t38CHgy9EsI5R6EuiaTW 7HDwsIwebTOYoqXCoF6GjQgJXvx18GEjcKBN4hk2y2O0xDSvbsTlaSIAGs7noQHDxvHi cP+4ZYqRPPbfuONdOMZZFFXgYSgkTSqFYkvlTaO/rLBDmqCwftd19RwI0tWM0mMLlXWz q47sedtiv+WMqtcwbvMN3RtwZ8RDIbHGrDJqhkt5Lq+C4zy1a5CGl3OnxbuQi6cD7cE1 UhLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=CNASLxL6+dc1p/aP23fOTzCbIY59oUP6eonCtGObomA=; b=zYeM6CMdRuiDcNrJY6stWmTZvSOacAU+r5VGOVxX9b6RXk5q5osIe0yUxIiuqwAxrY tnUbUGvTMCQqkFyFhRDc4PG/cf6ZzGA6Nviwvg6ErwNeAx8pUVxukRBn41ipqttA7BEV hpo9QBPk/ZU58JBfs5pEpenIxx19VITFYe7ukEynJkltMdtw9vtuO+IChzEcGFnPLgP7 xSxiq4mp3lDMH8fAQXdRvoyrBZv3mblRhaBPCMPLwU1HyvLPg64gkAq9M6UiPEO9dtJX mtb0Ay5u1BsImXBc5K8SGn736VuDqieGxNDbKz7+rpRfOoiwAoifkS1Y9ZwB+MJhUGpm pwAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g12-v6si10129551plm.142.2018.10.05.07.36.11; Fri, 05 Oct 2018 07:36:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728965AbeJEVec convert rfc822-to-8bit (ORCPT + 99 others); Fri, 5 Oct 2018 17:34:32 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:38332 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728643AbeJEVec (ORCPT ); Fri, 5 Oct 2018 17:34:32 -0400 Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1g8RCU-0002Al-Bu; Fri, 05 Oct 2018 16:35:30 +0200 Date: Fri, 5 Oct 2018 16:35:30 +0200 From: Sebastian Andrzej Siewior To: Kurt Kanzenbach Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: Re: [PATCH RT] tty: serial: pl011: fix warning about uninitialized variable Message-ID: <20181005143530.o5g6kuh5i3ym44os@linutronix.de> References: <20180924082901.21191-1-kurt@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20180924082901.21191-1-kurt@linutronix.de> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-09-24 10:29:01 [+0200], Kurt Kanzenbach wrote: > Silence the following gcc warning: > > drivers/tty/serial/amba-pl011.c: In function ‘pl011_console_write’: > ./include/linux/spinlock.h:260:3: warning: ‘flags’ may be used uninitialized in this function [-Wmaybe-uninitialized] > _raw_spin_unlock_irqrestore(lock, flags); \ > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/tty/serial/amba-pl011.c:2214:16: note: ‘flags’ was declared here > unsigned long flags; > ^~~~~ > > The code is correct. Thus, initializing flags to zero doesn't change the > behavior and resolves the warning. > > Signed-off-by: Kurt Kanzenbach applied. Sebastian