Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp595126imm; Fri, 5 Oct 2018 08:40:27 -0700 (PDT) X-Google-Smtp-Source: ACcGV62fKNCS0bbRx75rJDsmIFJdszoSld35e5aVGeC7RY0590LBPz1wV8oVfJlp1gyqdhkOvvG6 X-Received: by 2002:a17:902:a40c:: with SMTP id p12-v6mr12319780plq.165.1538754027507; Fri, 05 Oct 2018 08:40:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538754027; cv=none; d=google.com; s=arc-20160816; b=ZM2xYxUHU2nZa7r7Qcm8AjagZiBe7+MyMkrvDP7dujkjms1p+p7pmdDAiuhHvwP/U/ tcmbkubifCGJeA3luYrLpp3oKPyicS3F0g0PZPz7k5dfVCYD2GW09fG9+6AgqDdguO7f ewD4f+L7ADG8xO9DhisBKAvnnT3A60XMFyHWIfV6HI/2jVSrgFuSIELu0FEoIE7QvJgx JInEN5A6HZu1ruE89RXa/5EuqQ5MoJCUGPVplZo9oNEuzY7wz268ja2jczGtU938gcdV xSihl7Q94VWeAJd8X2FcGwyFX0TnG/2Kmbfxox4oHZbLuPUIEwjuMGKvR7eIo+CJxHJw G3uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization; bh=Xmox+AjxjQqBVFprenP3BwnPsN+oQWl79CZmkOtf8R0=; b=jUK2/wr2xhCkWzauRmG1W+Jv18vAGSRPshLmQqvLcYhqhz8xefwBuuO2vlNPUiX7JX VQzT56LXN2hhYmM0dBzE7ME7aPUY9nGvRnwN5Q65zAVKx8pkU9k06iManM4Re7huNiqC 7Tg97OTbF1FXD+sYUFuJqXX1Esv2Jcd8AJhzBc81s6YRtiXajGUbxL/R9R47DjkTxU3c snQfp7rlmK5EFt4utOC+x61tx3/M5uc9f6BCGGt+PTypsG5DszZVzoOsSIhkulqDpl5Z gqwql9NOkEJZIaxxNrMNiJIx990CqTxrs89HShkaVCUaDRodJdlhkQsPUsfRN/vsQO9T oJ/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l70-v6si8484854pga.498.2018.10.05.08.40.12; Fri, 05 Oct 2018 08:40:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728538AbeJEWi7 (ORCPT + 99 others); Fri, 5 Oct 2018 18:38:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43182 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726082AbeJEWi7 (ORCPT ); Fri, 5 Oct 2018 18:38:59 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8B06130012C3; Fri, 5 Oct 2018 15:39:45 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-149.rdu2.redhat.com [10.10.120.149]) by smtp.corp.redhat.com (Postfix) with ESMTP id 50207308BDA1; Fri, 5 Oct 2018 15:39:44 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <153618445730.7946.10001472635835806478.stgit@warthog.procyon.org.uk> <153618447788.7946.12036865757091293640.stgit@warthog.procyon.org.uk> To: James Morris Cc: dhowells@redhat.com, denkenz@gmail.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/22] KEYS: Provide missing asymmetric key subops for new key type ops MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <21654.1538753983.1@warthog.procyon.org.uk> Date: Fri, 05 Oct 2018 16:39:43 +0100 Message-ID: <21655.1538753983@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 05 Oct 2018 15:39:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org James Morris wrote: > > + pr_devel("==>%s()\n", __func__); > > Are you planning on leaving these pr_devel()s in? Well, they don't do anything unless you #define DEBUG at the top of the file. If they really offend you, I can remove them. David