Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181005071234.GA8803@embeddedor.com>
In-Reply-To: <20181005071234.GA8803@embeddedor.com>
From:   Allen Hubbe <allenbh@gmail.com>
Date:   Fri, 5 Oct 2018 13:03:01 -0400
Message-ID: <CAJ80sasrMXyC4jDGG+-wDLLXSApM6-HdgmgGwNMtH7AMwPdCUg@mail.gmail.com>
Subject: Re: [PATCH] ntb: ntb_transport: Mark expected switch fall-throughs
To:     gustavo@embeddedor.com
Cc:     Jon Mason <jdmason@kudzu.us>, dave.jiang@intel.com,
        linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Oct 5, 2018 at 3:12 AM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1373888 ("Missing break in switch")
> Addresses-Coverity-ID: 1373889 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Acked-by: Allen Hubbe <allenbh@gmail.com>

> ---
>  drivers/ntb/ntb_transport.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index 9398959..c643b9c 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -1278,6 +1278,7 @@ static void ntb_rx_copy_callback(void *data,
>                 case DMA_TRANS_READ_FAILED:
>                 case DMA_TRANS_WRITE_FAILED:
>                         entry->errors++;
> +                       /* fall through */
>                 case DMA_TRANS_ABORTED:
>                 {
>                         struct ntb_transport_qp *qp = entry->qp;
> @@ -1533,6 +1534,7 @@ static void ntb_tx_copy_callback(void *data,
>                 case DMA_TRANS_READ_FAILED:
>                 case DMA_TRANS_WRITE_FAILED:
>                         entry->errors++;
> +                       /* fall through */
>                 case DMA_TRANS_ABORTED:
>                 {
>                         void __iomem *offset =
> --
> 2.7.4