Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 6 Oct 2018 04:23:54 +1000 (AEST)
From:   James Morris <jmorris@namei.org>
To:     David Howells <dhowells@redhat.com>
cc:     denkenz@gmail.com, keyrings@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/22] KEYS: Provide software public key query function
In-Reply-To: <alpine.LRH.2.21.1810060228100.8957@namei.org>
Message-ID: <alpine.LRH.2.21.1810060423370.8957@namei.org>
References: <alpine.LRH.2.21.1810040520570.16168@namei.org> <153618445730.7946.10001472635835806478.stgit@warthog.procyon.org.uk> <153618449119.7946.11025480207548147086.stgit@warthog.procyon.org.uk> <22418.1538754702@warthog.procyon.org.uk>
 <alpine.LRH.2.21.1810060228100.8957@namei.org>
User-Agent: Alpine 2.21 (LRH 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 6 Oct 2018, James Morris wrote:

> On Fri, 5 Oct 2018, David Howells wrote:
> 
> > James Morris <jmorris@namei.org> wrote:
> > 
> > > > +	if (strcmp(encoding, "raw") == 0) {
> > > > +		strcpy(alg_name, pkey->pkey_algo);
> > > > +		return 0;
> > > > +	}
> > > 
> > > Can encoding here also be NULL to indicate raw? per patch 01:
> > 
> > Ummm...  By the letter of the documentation, yes, though in practice it isn't
> > (it is defaulted to "raw") in the keyctl interface.  I wonder if it would be
> > better to require it to say "raw" and never be NULL.
> 
> Probably.

If you respin the patches please add all the signoffs.

-- 
James Morris
<jmorris@namei.org>